fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: <darrick.wong@oracle.com>, <guaneryu@gmail.com>
Cc: <fstests@vger.kernel.org>, Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Subject: [PATCH v1 1/2] generic/054,055: add _require_v2log
Date: Tue, 18 Feb 2020 15:24:10 +0800	[thread overview]
Message-ID: <1582010652-1124-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)

This two case fail on my server machine with GPT disklabe type,
info as below:
mount failed: -o logbsize=32k
dmesg info as below:
[92633.871954] XFS (sda7): logbuf size must be greater than or equal to log stripe size

The min logbuf size is 256k on my server machine. It needs to use _require_v2log to check.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 common/log        | 1 +
 tests/generic/054 | 1 +
 tests/generic/055 | 1 +
 3 files changed, 3 insertions(+)

diff --git a/common/log b/common/log
index c7921f50..f82919a6 100644
--- a/common/log
+++ b/common/log
@@ -494,6 +494,7 @@ _log_version()
 
 _require_v2log()
 {
+    [ "$FSTYP" != xfs ] && return 0
     # test out mkfs to see if it supports "-l version=2"
     export MKFS_OPTIONS="-l version=2"
     if ! _scratch_mkfs_xfs >>$seqres.full 2>&1; then
diff --git a/tests/generic/054 b/tests/generic/054
index 95d40c3c..b4b74615 100755
--- a/tests/generic/054
+++ b/tests/generic/054
@@ -30,6 +30,7 @@ rm -f $seqres.full $tmp.*
 _require_scratch
 _require_scratch_shutdown
 _require_logstate
+_require_v2log
 
 echo "*** init FS"
 _scratch_unmount >/dev/null 2>&1
diff --git a/tests/generic/055 b/tests/generic/055
index 9715f27b..071c4eaf 100755
--- a/tests/generic/055
+++ b/tests/generic/055
@@ -57,6 +57,7 @@ rm -f $seqres.full $tmp.*
 _require_scratch
 _require_scratch_shutdown
 _require_logstate
+_require_v2log
 
 QUOTA_OPTION=`_get_quota_option`
 
-- 
2.18.0




             reply	other threads:[~2020-02-18  7:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18  7:24 Yang Xu [this message]
2020-02-18  7:24 ` [PATCH v1 2/2] common/log: add 16k logbuf size for xfs_log_config Yang Xu
2020-02-19  5:06 ` [PATCH v1 1/2] generic/054,055: add _require_v2log Darrick J. Wong
2020-02-19  8:48   ` Yang Xu
2020-02-19 22:11     ` Darrick J. Wong
2020-02-20  2:01       ` Yang Xu
2020-02-20  2:17         ` Darrick J. Wong
2020-02-20  3:10           ` Yang Xu
2020-02-20  5:38           ` [PATCH v2] common/log: add -l su option in _xfs_log_config Yang Xu
2020-02-23 14:22             ` Eryu Guan
2020-02-23 16:37               ` Darrick J. Wong
2020-02-24  1:51                 ` Yang Xu
2020-02-24  2:14                   ` Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1582010652-1124-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
    --to=xuyang2018.jy@cn.fujitsu.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).