Re: [PATCH v1 1/2] generic/054,055: add _require_v2log

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Tue, Feb 18, 2020 at 03:24:10PM +0800, Yang Xu wrote:
> This two case fail on my server machine with GPT disklabe type,
> info as below:
> mount failed: -o logbsize=32k
> dmesg info as below:
> [92633.871954] XFS (sda7): logbuf size must be greater than or equal to log stripe size
> 
> The min logbuf size is 256k on my server machine. It needs to use _require_v2log to check.

Works fine here.  What is sda7's storage and raid alignment
configuration?

--D

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  common/log        | 1 +
>  tests/generic/054 | 1 +
>  tests/generic/055 | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/common/log b/common/log
> index c7921f50..f82919a6 100644
> --- a/common/log
> +++ b/common/log
> @@ -494,6 +494,7 @@ _log_version()
>  
>  _require_v2log()
>  {
> +    [ "$FSTYP" != xfs ] && return 0
>      # test out mkfs to see if it supports "-l version=2"
>      export MKFS_OPTIONS="-l version=2"
>      if ! _scratch_mkfs_xfs >>$seqres.full 2>&1; then
> diff --git a/tests/generic/054 b/tests/generic/054
> index 95d40c3c..b4b74615 100755
> --- a/tests/generic/054
> +++ b/tests/generic/054
> @@ -30,6 +30,7 @@ rm -f $seqres.full $tmp.*
>  _require_scratch
>  _require_scratch_shutdown
>  _require_logstate
> +_require_v2log
>  
>  echo "*** init FS"
>  _scratch_unmount >/dev/null 2>&1
> diff --git a/tests/generic/055 b/tests/generic/055
> index 9715f27b..071c4eaf 100755
> --- a/tests/generic/055
> +++ b/tests/generic/055
> @@ -57,6 +57,7 @@ rm -f $seqres.full $tmp.*
>  _require_scratch
>  _require_scratch_shutdown
>  _require_logstate
> +_require_v2log
>  
>  QUOTA_OPTION=`_get_quota_option`
>  
> -- 
> 2.18.0
> 
> 
>