* [PATCH] xfs/191-input-validation:Fix issue that the test takes too long
@ 2019-11-26 5:23 Baihua Lu
2019-11-26 15:36 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Baihua Lu @ 2019-11-26 5:23 UTC (permalink / raw)
To: fstests, guaneryu; +Cc: balu, Lili.Deng, Baihua Lu
In this test, we don't need to check filesystem on the scratch device for there is not
really creating the file system. If _check_filesystems executes, xfs_logprint will be
failed for having dirty log and xfs_repaire will take a long time.
Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
tests/xfs/191-input-validation | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..db427349 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -31,7 +31,7 @@ _cleanup()
# Modify as appropriate.
_supported_fs xfs
_supported_os Linux
-_require_scratch
+_require_scratch_nocheck
_require_xfs_mkfs_validation
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs/191-input-validation:Fix issue that the test takes too long
2019-11-26 5:23 [PATCH] xfs/191-input-validation:Fix issue that the test takes too long Baihua Lu
@ 2019-11-26 15:36 ` Darrick J. Wong
0 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2019-11-26 15:36 UTC (permalink / raw)
To: Baihua Lu; +Cc: fstests, guaneryu, balu, Lili.Deng
On Tue, Nov 26, 2019 at 05:23:36AM +0000, Baihua Lu wrote:
> In this test, we don't need to check filesystem on the scratch device for there is not
> really creating the file system. If _check_filesystems executes, xfs_logprint will be
> failed for having dirty log and xfs_repaire will take a long time.
Where did the dirty log come from if we didn't actually format anything?
I thought I had taught fstests to wipefs the scratch device between
each test...
(No objections to the diff itself, I'm simply curious about the commit
message.)
--D
>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
> ---
> tests/xfs/191-input-validation | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
> # Modify as appropriate.
> _supported_fs xfs
> _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
> _require_xfs_mkfs_validation
>
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs/191-input-validation:Fix issue that the test takes too long
2019-11-27 10:41 Baihua Lu
@ 2019-11-27 16:31 ` Darrick J. Wong
0 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2019-11-27 16:31 UTC (permalink / raw)
To: Baihua Lu; +Cc: fstests, guaneryu, balu, Lili.Deng
On Wed, Nov 27, 2019 at 02:41:31AM -0800, Baihua Lu wrote:
> After this test is passed, checking filesystems will execute. Then
> xfs_logprint will be failed and xfs_repair will take a long time because
> there is not really creating the file system in this test and wipefs
> executes before this test. So there is no need checking filesystems.
>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
Ok, looks fine.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/191-input-validation | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
> # Modify as appropriate.
> _supported_fs xfs
> _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
> _require_xfs_mkfs_validation
>
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] xfs/191-input-validation:Fix issue that the test takes too long
@ 2019-11-27 10:41 Baihua Lu
2019-11-27 16:31 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Baihua Lu @ 2019-11-27 10:41 UTC (permalink / raw)
To: fstests, guaneryu, darrick.wong; +Cc: balu, Lili.Deng, Baihua Lu
After this test is passed, checking filesystems will execute. Then
xfs_logprint will be failed and xfs_repair will take a long time because
there is not really creating the file system in this test and wipefs
executes before this test. So there is no need checking filesystems.
Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
tests/xfs/191-input-validation | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..db427349 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -31,7 +31,7 @@ _cleanup()
# Modify as appropriate.
_supported_fs xfs
_supported_os Linux
-_require_scratch
+_require_scratch_nocheck
_require_xfs_mkfs_validation
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] xfs/191-input-validation:Fix issue that the test takes too long
@ 2019-11-20 8:17 Baihua Lu
0 siblings, 0 replies; 5+ messages in thread
From: Baihua Lu @ 2019-11-20 8:17 UTC (permalink / raw)
To: fstests; +Cc: balu, Lili.Deng, Baihua Lu
When test is passed, _check_filesystems will execute. If there is no
mkfs a new XFS filesystem $SCRATCH_DEV in this test, in the check
filesystems stage, xfs_logprint will be failed for having dirty log and
xfs_repaire will take a long time.
Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
tests/xfs/191-input-validation | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..fd239dbb 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -34,7 +34,7 @@ _supported_os Linux
_require_scratch
_require_xfs_mkfs_validation
-
+_scratch_mkfs >/dev/null 2>&1
rm -f $seqres.full
echo silence is golden
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-27 16:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 5:23 [PATCH] xfs/191-input-validation:Fix issue that the test takes too long Baihua Lu
2019-11-26 15:36 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2019-11-27 10:41 Baihua Lu
2019-11-27 16:31 ` Darrick J. Wong
2019-11-20 8:17 Baihua Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).