From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: ira.weiny@intel.com, fstests@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] xfs/XXX: Add xfs/XXX
Date: Tue, 2 Jun 2020 11:14:44 -0700 (PDT) [thread overview]
Message-ID: <20200602181444.GD8230@magnolia> (raw)
In-Reply-To: <5ED61324.6010300@cn.fujitsu.com>
On Tue, Jun 02, 2020 at 04:51:48PM +0800, Xiao Yang wrote:
> On 2020/4/14 0:30, Darrick J. Wong wrote:
> > This might be a good time to introduce a few new helpers:
> >
> > _require_scratch_dax ("Does $SCRATCH_DEV support DAX?")
> > _require_scratch_dax_mountopt ("Does the fs support the DAX mount options?")
> > _require_scratch_daX_iflag ("Does the fs support FS_XFLAG_DAX?")
> Hi Darrick,
>
> Now, I am trying to introduce these new helpers and have some questions:
> 1) There are five testcases related to old dax implementation, should we
> only convert them to new dax implementation or make them compatible with old
> and new dax implementation?
What is the 'old' DAX implementation? ext2 XIP?
> 2) I think _require_xfs_io_command "chattr" "x" is enough to check if fs
> supports FS_XFLAG_DAX. Is it necessary to add _require_scratch_dax_iflag()?
> like this:
> _require_scratch_dax_iflag()
> {
> _require_xfs_io_command "chattr" "x"
> }
I suggested that list based on the major control knobs that will be
visible to userspace programs. Even if this is just a one-line helper,
its name is useful for recognizing which of those knobs we're looking
for.
Yes, you could probably save a trivial amount of time by skipping one
iteration of bash function calling, but now everyone has to remember
that the xfs_io chattr "x" flag means the dax inode flag, and not
confuse it for chmod +x or something else.
--D
> Best Regards,
> Xiao Yang
>
>
next prev parent reply other threads:[~2020-06-02 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 5:44 [PATCH] xfs/XXX: Add xfs/XXX ira.weiny
2020-04-13 7:54 ` Amir Goldstein
2020-04-13 15:53 ` Ira Weiny
2020-04-13 16:11 ` Amir Goldstein
2020-04-13 16:22 ` Darrick J. Wong
2020-04-13 16:30 ` Darrick J. Wong
2020-06-02 8:51 ` Xiao Yang
2020-06-02 18:14 ` Darrick J. Wong [this message]
2020-06-03 1:56 ` Xiao Yang
2020-06-03 3:49 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-04-07 18:30 ira.weiny
2020-02-27 5:38 ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602181444.GD8230@magnolia \
--to=darrick.wong@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).