From: Amir Goldstein <amir73il@gmail.com>
To: ira.weiny@intel.com
Cc: fstests <fstests@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Jeff Moyer <jmoyer@redhat.com>, Ext4 <linux-ext4@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] xfs/XXX: Add xfs/XXX
Date: Mon, 13 Apr 2020 10:54:36 +0300 [thread overview]
Message-ID: <CAOQ4uxguVRysAuVEtQmPj+x=RDtDnGCtNeGvbvXNuvppwagwDg@mail.gmail.com> (raw)
In-Reply-To: <20200413054419.1560503-1-ira.weiny@intel.com>
On Mon, Apr 13, 2020 at 9:06 AM <ira.weiny@intel.com> wrote:
>
> From: Ira Weiny <ira.weiny@intel.com>
>
> Add XXX to test per file DAX operations.
Please change commit title to "xfs: Add test for per file DAX operations"
The title Add xfs/XXX is not useful even if XXX where a number.
But the kernel patch suggests that there is an intention to make
this behavior also applicable to ext4??
If that is the case I would recommend making this a generic tests
which requires filesystem support for -o dax=XXX
>
> The following is tested[*]
>
> 1. There exists an in-kernel access mode flag S_DAX that is set when
> file accesses go directly to persistent memory, bypassing the page
> cache. Applications must call statx to discover the current S_DAX
> state (STATX_ATTR_DAX).
>
> 2. There exists an advisory file inode flag FS_XFLAG_DAX that is
> inherited from the parent directory FS_XFLAG_DAX inode flag at file
> creation time. This advisory flag can be set or cleared at any
> time, but doing so does not immediately affect the S_DAX state.
>
> Unless overridden by mount options (see (3)), if FS_XFLAG_DAX is set
> and the fs is on pmem then it will enable S_DAX at inode load time;
> if FS_XFLAG_DAX is not set, it will not enable S_DAX.
>
> 3. There exists a dax= mount option.
>
> "-o dax=never" means "never set S_DAX, ignore FS_XFLAG_DAX."
>
> "-o dax=always" means "always set S_DAX (at least on pmem),
> and ignore FS_XFLAG_DAX."
>
> "-o dax" is an alias for "dax=always".
>
> "-o dax=inode" means "follow FS_XFLAG_DAX" and is the default.
>
> 4. There exists an advisory directory inode flag FS_XFLAG_DAX that can
> be set or cleared at any time. The flag state is copied into any
> files or subdirectories when they are created within that directory.
>
> 5. Programs that require a specific file access mode (DAX or not DAX)
> can do one of the following:
>
> (a) Create files in directories that the FS_XFLAG_DAX flag set as
> needed; or
>
> (b) Have the administrator set an override via mount option; or
>
> (c) Set or clear the file's FS_XFLAG_DAX flag as needed. Programs
> must then cause the kernel to evict the inode from memory. This
> can be done by:
>
> i> Closing the file and re-opening the file and using statx to
> see if the fs has changed the S_DAX flag; and
>
> ii> If the file still does not have the desired S_DAX access
> mode, either unmount and remount the filesystem, or close
> the file and use drop_caches.
>
> 6. It's not unreasonable that users who want to squeeze every last bit
> of performance out of the particular rough and tumble bits of their
> storage also be exposed to the difficulties of what happens when the
> operating system can't totally virtualize those hardware
> capabilities. Your high performance sports car is not a Toyota
> minivan, as it were.
>
> [*] https://lore.kernel.org/lkml/20200409165927.GD6741@magnolia/
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>
> ---
> Changes from v6 (kernel patch set):
> Start versions tracking the kernel patch set.
> Update for new requirements
>
> Changes from V1 (xfstests patch):
> Add test to ensure moved files preserve their flag
> Check chattr of non-dax flags (check bug found by Darrick)
> ---
...
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -511,3 +511,4 @@
> 511 auto quick quota
> 512 auto quick acl attr
> 513 auto mount
> +999 auto
The test looks also 'quick'
Thanks,
Amir.
next prev parent reply other threads:[~2020-04-13 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 5:44 [PATCH] xfs/XXX: Add xfs/XXX ira.weiny
2020-04-13 7:54 ` Amir Goldstein [this message]
2020-04-13 15:53 ` Ira Weiny
2020-04-13 16:11 ` Amir Goldstein
2020-04-13 16:22 ` Darrick J. Wong
2020-04-13 16:30 ` Darrick J. Wong
2020-06-02 8:51 ` Xiao Yang
2020-06-02 18:14 ` Darrick J. Wong
2020-06-03 1:56 ` Xiao Yang
2020-06-03 3:49 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-04-07 18:30 ira.weiny
2020-02-27 5:38 ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxguVRysAuVEtQmPj+x=RDtDnGCtNeGvbvXNuvppwagwDg@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).