Re: qgit-0.6

* Re: qgit-0.6
@ 2005-06-19 19:54 Marco Costalba
  0 siblings, 0 replies; 8+ messages in thread
From: Marco Costalba @ 2005-06-19 19:54 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: git

Ingo Molnar wrote:

thanks for your feedback
>
>works fine here and is nice and fast, but there are a few minor visual 
>glitches:
>
>- annotated file contents are not properly aligned over each other. E.g.  
>  check commit 7875b50d1a9928e683299b283bfe94778b6c344e in the current 
>  git repository, and select read-tree.c and view it annotated - the 
>  lines start right after the author field ends, not in any aligned way.
>

Yes, it depends on variable spaced font, If you note the number of characters of the header of
each line is always the same and is calculated for each file (the gray color part has always a
fixed number of chars). I have already switched to a fixed font (courier) in my tree,
plus others little things like truncation if exceeds a maximum lenght with 
first name collpasing (Marco Costalba -> M. Costalba).

>- the tree visualization is hard to follow - gitk's output is much 
>  nicer. As an example of nice rendering check out the octopus merge 
>  around commit 211232bae64bcc60bbf5d1b5e5b2344c22ed767e. One glance at 
>  the gitk output shows what happened - qgit's output is in essence 
>  unreadable.
>

You are definitely right! The problem is graph is not drawed! I precalculate at startup all
the diffrents pixmaps and put in a vector, drawing a graph is just correct indexing
the vector for each lane and do some bitblt. This is because QT has good pixmaps handling in
QListView ( the main log list) but not line drawings capapility and because this way is very fast.
But in any case I definitely have to find something better. Suggestions are welcomed :-).

>and a few requests for enhancements if you dont mind:
>
more then welcomed.

> - in annotated mode, it would be nice to select a particular line 
>   and then double-click would jump to the commit that added that line.  
>   This would nicely round up annotation support.
>

Ok, I'll add this. By the way, now you can select the corresponding commit in the 
history list above file content (it's the one with the same number) and the
 main view will update. 
I can make the selection: 'line content number -> line history number' automatic and that
should be enough.

> - plaintext search capability in every window. E.g. in the annotated
>   file window i often would like to search for some code, or to jump to
>   a given line.

Ok. I'll add this.

Marco

__________________________________ 
Discover Yahoo! 
Stay in touch with email, IM, photo sharing and more. Check it out! 
http://discover.yahoo.com/stayintouch.html

^ permalink raw reply	[flat|nested] 8+ messages in thread