git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jean-Noël AVILA" <jn.avila@free.fr>
To: git@vger.kernel.org
Cc: Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [PATCH] i18n: fix mistakes in translated strings
Date: Mon, 03 Sep 2018 19:52:19 +0200	[thread overview]
Message-ID: <4909221.b3sI1bcdIh@cayenne> (raw)
In-Reply-To: <xmqqwosghiw8.fsf@gitster-ct.c.googlers.com>

Le jeudi 23 août 2018, 23:28:55 CEST Junio C Hamano a écrit :
> Jean-Noël Avila <jn.avila@free.fr> writes:
> 
> > -			die(_("run_command returned non-zero status while"
> > +			die(_("run_command returned non-zero status while "
> >  				"recursing in the nested submodules of %s\n."),
> 
> Obviously good.
> 
> > diff --git a/config.c b/config.c
> > index 9a0b10d4bc..3461993f0a 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -124,7 +124,7 @@ static const char include_depth_advice[] = N_(
> >  "	%s\n"
> >  "from\n"
> >  "	%s\n"
> > -"Do you have circular includes?");
> > +"This might be due to circular includes.");
> 
> OK.
Hello,

Has this patch been integrated in a -rc? In which case, would a new round of translation need to be triggered?

Thanks

JN




  reply	other threads:[~2018-09-03 17:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 21:00 [PATCH] i18n: fix mistakes in translated strings Jean-Noël Avila
2018-08-23 21:28 ` Junio C Hamano
2018-09-03 17:52   ` Jean-Noël AVILA [this message]
2018-09-04  1:01     ` [L10N] Kickoff for Git 2.19.0 round 2 Jiang Xin
2018-09-04  1:52 ` [PATCH] i18n: fix mistakes in translated strings Jiang Xin
2018-09-04 14:18   ` [PATCH] i18n: fix dangling dot in die() messages Jean-Noel Avila
2018-09-04 15:05     ` Ævar Arnfjörð Bjarmason
2018-09-04 15:13       ` Jean-Noël Avila
2018-09-04 19:47         ` Junio C Hamano
2018-09-04 15:16       ` Duy Nguyen
2018-09-04 19:32   ` [PATCH] i18n: fix mistakes in translated strings Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4909221.b3sI1bcdIh@cayenne \
    --to=jn.avila@free.fr \
    --cc=git@vger.kernel.org \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).