* 'git rev-parse --show-toplevel' errors out with per-worktree configs
@ 2020-07-14 19:40 Clement Moyroud
2020-07-14 20:38 ` Clement Moyroud
0 siblings, 1 reply; 3+ messages in thread
From: Clement Moyroud @ 2020-07-14 19:40 UTC (permalink / raw)
To: git
Hello,
I have a bare repository clone that I create worktrees off. This works
fine, including 'git rev-parse --show-toplevel'.
I enabled per-worktree configs using 'git config --local
extensions.worktreeconfig=true', and now I can't get the toplevel
anymore:
> git rev-parse --show-toplevel
fatal: this operation must be run in a work tree
Disabling per-worktree configs makes it work again. This also works
fine on a non-bare repository clone.
IOW, this works:
git clone <url> non-bare
(cd non-bare && git worktree add -b master2 ../wtree1 master)
(cd wtree1 && git rev-parse --show-toplevel)
This does not:
git clone -c extensions.worktreeConfig=true <url> bare.git
(cd bare.git && git worktree add -b master2 ../wtree2 master)
(cd wtree2 && git rev-parse --show-toplevel)
Is this a bug, or am I missing something?
Thanks,
Clément
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 'git rev-parse --show-toplevel' errors out with per-worktree configs
2020-07-14 19:40 'git rev-parse --show-toplevel' errors out with per-worktree configs Clement Moyroud
@ 2020-07-14 20:38 ` Clement Moyroud
2020-07-14 21:34 ` Clement Moyroud
0 siblings, 1 reply; 3+ messages in thread
From: Clement Moyroud @ 2020-07-14 20:38 UTC (permalink / raw)
To: git
> IOW, this works:
> git clone <url> non-bare
> (cd non-bare && git worktree add -b master2 ../wtree1 master)
> (cd wtree1 && git rev-parse --show-toplevel)
>
> This does not:
> git clone -c extensions.worktreeConfig=true <url> bare.git
> (cd bare.git && git worktree add -b master2 ../wtree2 master)
> (cd wtree2 && git rev-parse --show-toplevel)
>
Sorry, I mixed up my examples.
This works:
git clone -c extensions.worktreeConfig=true <url> non-bare
(cd non-bare && git worktree add -b master2 ../wtree1 master)
(cd wtree1 && git rev-parse --show-toplevel)
This does not:
git clone -c extensions.worktreeConfig=true --mirror <url> bare.git
(cd bare.git && git worktree add -b master2 ../wtree2 master)
(cd wtree2 && git rev-parse --show-toplevel)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 'git rev-parse --show-toplevel' errors out with per-worktree configs
2020-07-14 20:38 ` Clement Moyroud
@ 2020-07-14 21:34 ` Clement Moyroud
0 siblings, 0 replies; 3+ messages in thread
From: Clement Moyroud @ 2020-07-14 21:34 UTC (permalink / raw)
To: git
> > IOW, this works:
> > git clone <url> non-bare
> > (cd non-bare && git worktree add -b master2 ../wtree1 master)
> > (cd wtree1 && git rev-parse --show-toplevel)
> >
> > This does not:
> > git clone -c extensions.worktreeConfig=true <url> bare.git
> > (cd bare.git && git worktree add -b master2 ../wtree2 master)
> > (cd wtree2 && git rev-parse --show-toplevel)
> >
>
> Sorry, I mixed up my examples.
>
> This works:
> git clone -c extensions.worktreeConfig=true <url> non-bare
> (cd non-bare && git worktree add -b master2 ../wtree1 master)
> (cd wtree1 && git rev-parse --show-toplevel)
>
> This does not:
> git clone -c extensions.worktreeConfig=true --mirror <url> bare.git
> (cd bare.git && git worktree add -b master2 ../wtree2 master)
> (cd wtree2 && git rev-parse --show-toplevel)
OK, I figured it out by looking at environment.c. The issue is that
the base mirror is bare, but the worktree isn't. This makes it work:
(cd wtree2 && git config --worktree core.bare true)
This is confusing - should this be set automatically, or referenced
more clearly in the 'Configuration File' section of the git-worktree
doc?
Thanks,
Clément
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-14 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 19:40 'git rev-parse --show-toplevel' errors out with per-worktree configs Clement Moyroud
2020-07-14 20:38 ` Clement Moyroud
2020-07-14 21:34 ` Clement Moyroud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).