git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Cover letter for the last patch
@ 2012-06-12  6:03 jaseem abid
  0 siblings, 0 replies; only message in thread
From: jaseem abid @ 2012-06-12  6:03 UTC (permalink / raw)
  To: git mailing list; +Cc: Andrew Sayers, Jakub Narębski, Junio C Hamano

Dear list,

Sorry,  I think i missed the cover letter for the last patch.

[PATCH/RFC] gitweb: Adding jasmine test suite files for the browser

JavaScript in gitweb is almost completely handwritten.
It is reimplementing things JavaScript library authors did a lot of times
already. Porting the current code to a library version was proposed as a gsoc
project this year. [ So I think I can skip why this patch is relevant]

A common suggestion was to add tests to the new JavaScript code. Deciding the
testing framework took much more time than expected after several discussions.
People wanted tests that could be run in console with TAP so that it will
integrate well with the existing system but since the code is ultimately going
to be run in a browser, tests in the browser was more important.

After a lot of discussions here and on #git-devel, I have used jasmine BDD
framework, nodejs and jasmine TAP reporter to solve the issues. The specs are
written for the browser and a makefile generates t/t9503-gitweb-javascript.js
which can be run in a console to produce TAP output.


This patch series is for review only. If everyone is ok with the new testing
framework, I will be able to send a patch with actual code in a week or 2. This
patch series adds few sample tests to the existing code, and makes it run in a
browser and console.

I have added gitweb/test/README with instructions on the new test.

Please eyeball the changes to t/Makefile as I am not very sure if that is the
best way to do it.

Reviews most welcome.



-- 
Jaseem Abid
http://jaseemabid.github.com

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-06-12  6:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-12  6:03 Cover letter for the last patch jaseem abid

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).