From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Yang Zhao <yang.zhao@skyboxlabs.com>
Subject: Re: What's cooking in git.git (Jan 2020, #04; Wed, 22)
Date: Thu, 23 Jan 2020 12:56:56 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2001231256350.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20200122235333.GA6837@szeder.dev>
[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]
Hi,
On Thu, 23 Jan 2020, SZEDER Gábor wrote:
> On Wed, Jan 22, 2020 at 02:18:05PM -0800, Junio C Hamano wrote:
> > * yz/p4-py3 (2020-01-15) 14 commits
> > - ci: also run linux-gcc pipeline with python3.5 environment
>
> I still think that this last patch needs to be reworked before this
> series is merged any further.
>
> The only Python script we have is 'git p4', so the Python version is
> only relevant for 'git p4' tests ('t98*'), while the rest of Git and
> the test suite couldn't care less [1]. This patch, however, not only
> builds Git and runs the full test suite for each of the two Python
> versions, but, worse, runs the full test suite _twice_ for each, first
> as a "regular" test run and then again with all the GIT_TEST_* knobs
> enabled. Consequently, it adds ~50mins to every build's runtime.
>
> That's just too wasteful.
>
>
> [1] Well, there is 'contrib/svn-fe/svnrdump_sim.py' as well, but
> that's contrib, though it is used in 't9020-remote-svn.sh'.
For what it's worth, I fully support Gábor's assessment.
Ciao,
Dscho
>
> > - git-p4: use python3's input() everywhere
> > - git-p4: simplify regex pattern generation for parsing diff-tree
> > - git-p4: use dict.items() iteration for python3 compatibility
> > - git-p4: use functools.reduce instead of reduce
> > - git-p4: fix freezing while waiting for fast-import progress
> > - git-p4: use marshal format version 2 when sending to p4
> > - git-p4: open .gitp4-usercache.txt in text mode
> > - git-p4: convert path to unicode before processing them
> > - git-p4: encode/decode communication with git for python3
> > - git-p4: encode/decode communication with p4 for python3
> > - git-p4: remove string type aliasing
> > - git-p4: change the expansion test from basestring to list
> > - git-p4: make python2.7 the oldest supported version
> >
> > Update "git p4" to work with Python 3.
> >
> > Will merge to 'next'.
>
>
next prev parent reply other threads:[~2020-01-23 11:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 22:18 What's cooking in git.git (Jan 2020, #04; Wed, 22) Junio C Hamano
2020-01-22 22:37 ` Elijah Newren
2020-01-22 22:45 ` Junio C Hamano
2020-01-22 23:53 ` SZEDER Gábor
2020-01-23 6:06 ` Junio C Hamano
2020-01-23 12:11 ` yz/p4-py3, was " Johannes Schindelin
2020-01-23 18:27 ` Yang Zhao
2020-01-27 12:55 ` SZEDER Gábor
2020-01-23 14:16 ` SZEDER Gábor
2020-01-23 17:56 ` SZEDER Gábor
2020-01-23 20:52 ` Junio C Hamano
2020-01-24 17:45 ` Yang Zhao
2020-01-25 0:13 ` Johannes Schindelin
2020-01-25 8:31 ` SZEDER Gábor
2020-01-26 9:21 ` Johannes Schindelin
2020-01-23 21:39 ` Johannes Schindelin
2020-01-24 12:02 ` SZEDER Gábor
2020-01-25 0:35 ` Johannes Schindelin
2020-02-05 21:01 ` Junio C Hamano
2020-02-06 0:27 ` SZEDER Gábor
2020-02-06 8:57 ` Johannes Schindelin
2020-02-06 9:06 ` SZEDER Gábor
2020-02-06 11:45 ` Johannes Schindelin
2020-01-23 11:56 ` Johannes Schindelin [this message]
2020-01-23 4:29 ` Denton Liu
2020-01-23 6:08 ` Junio C Hamano
2020-01-23 16:54 ` Christian Couder
2020-01-23 20:23 ` Junio C Hamano
2020-01-26 20:07 ` Denton Liu
2020-01-27 18:29 ` Junio C Hamano
2020-01-27 20:26 ` [PATCH] .mailmap: fix erroneous authorship for Derrick Stolee Denton Liu
2020-01-28 17:56 ` Junio C Hamano
2020-01-29 8:59 ` What's cooking in git.git (Jan 2020, #04; Wed, 22) Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2001231256350.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
--cc=yang.zhao@skyboxlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).