git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, Yang Zhao <yang.zhao@skyboxlabs.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: What's cooking in git.git (Jan 2020, #04; Wed, 22)
Date: Wed, 22 Jan 2020 22:06:19 -0800	[thread overview]
Message-ID: <xmqqftg6671g.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200122235333.GA6837@szeder.dev> ("SZEDER =?utf-8?Q?G=C3=A1?= =?utf-8?Q?bor=22's?= message of "Thu, 23 Jan 2020 00:53:33 +0100")

SZEDER Gábor <szeder.dev@gmail.com> writes:

> On Wed, Jan 22, 2020 at 02:18:05PM -0800, Junio C Hamano wrote:
>> * yz/p4-py3 (2020-01-15) 14 commits
>>  - ci: also run linux-gcc pipeline with python3.5 environment
>
> I still think that this last patch needs to be reworked before this
> series is merged any further.
>
> The only Python script we have is 'git p4', so the Python version is
> only relevant for 'git p4' tests ('t98*'), while the rest of Git and
> the test suite couldn't care less [1].  This patch, however, not only
> builds Git and runs the full test suite for each of the two Python
> versions, but, worse, runs the full test suite _twice_ for each, first
> as a "regular" test run and then again with all the GIT_TEST_* knobs
> enabled.  Consequently, it adds ~50mins to every build's runtime.
>
> That's just too wasteful.

Thanks for a reminder.  Yes, I do recall you raised the above point
and I agree with the assessment.

What's the ideal endgame wrt the tests?  Build with Py$N and run
full test suite once, and run full test suite again with the unusual
knobs enabled, which is what is done without this series, plus build
with Py(5-$N) and run and run only t98?? tests?

  reply	other threads:[~2020-01-23  6:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 22:18 What's cooking in git.git (Jan 2020, #04; Wed, 22) Junio C Hamano
2020-01-22 22:37 ` Elijah Newren
2020-01-22 22:45   ` Junio C Hamano
2020-01-22 23:53 ` SZEDER Gábor
2020-01-23  6:06   ` Junio C Hamano [this message]
2020-01-23 12:11     ` yz/p4-py3, was " Johannes Schindelin
2020-01-23 18:27       ` Yang Zhao
2020-01-27 12:55       ` SZEDER Gábor
2020-01-23 14:16     ` SZEDER Gábor
2020-01-23 17:56       ` SZEDER Gábor
2020-01-23 20:52         ` Junio C Hamano
2020-01-24 17:45           ` Yang Zhao
2020-01-25  0:13             ` Johannes Schindelin
2020-01-25  8:31               ` SZEDER Gábor
2020-01-26  9:21                 ` Johannes Schindelin
2020-01-23 21:39         ` Johannes Schindelin
2020-01-24 12:02           ` SZEDER Gábor
2020-01-25  0:35             ` Johannes Schindelin
2020-02-05 21:01               ` Junio C Hamano
2020-02-06  0:27                 ` SZEDER Gábor
2020-02-06  8:57                   ` Johannes Schindelin
2020-02-06  9:06                     ` SZEDER Gábor
2020-02-06 11:45                       ` Johannes Schindelin
2020-01-23 11:56   ` Johannes Schindelin
2020-01-23  4:29 ` Denton Liu
2020-01-23  6:08   ` Junio C Hamano
2020-01-23 16:54 ` Christian Couder
2020-01-23 20:23   ` Junio C Hamano
2020-01-26 20:07 ` Denton Liu
2020-01-27 18:29   ` Junio C Hamano
2020-01-27 20:26     ` [PATCH] .mailmap: fix erroneous authorship for Derrick Stolee Denton Liu
2020-01-28 17:56       ` Junio C Hamano
2020-01-29  8:59   ` What's cooking in git.git (Jan 2020, #04; Wed, 22) Denton Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftg6671g.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    --cc=yang.zhao@skyboxlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).