* [PATCH 1/3] git-filter-branch.txt: correct argument name typo
2019-11-05 23:31 [PATCH 0/3] Other doc fixes Elijah Newren via GitGitGadget
@ 2019-11-05 23:31 ` Elijah Newren via GitGitGadget
2019-11-05 23:31 ` [PATCH 2/3] hashmap: fix documentation misuses of -> versus Elijah Newren via GitGitGadget
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Elijah Newren via GitGitGadget @ 2019-11-05 23:31 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Elijah Newren
From: Elijah Newren <newren@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
Documentation/git-filter-branch.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index 5876598852..1ba4667b12 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -649,7 +649,7 @@ create hoards of confusing empty commits
commits from before the filtering operation are also pruned instead of
just pruning commits that became empty due to filtering rules.
-* If --prune empty is specified, sometimes empty commits are missed
+* If --prune-empty is specified, sometimes empty commits are missed
and left around anyway (a somewhat rare bug, but it happens...)
* A minor issue, but users who have a goal to update all names and
--
gitgitgadget
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] hashmap: fix documentation misuses of -> versus .
2019-11-05 23:31 [PATCH 0/3] Other doc fixes Elijah Newren via GitGitGadget
2019-11-05 23:31 ` [PATCH 1/3] git-filter-branch.txt: correct argument name typo Elijah Newren via GitGitGadget
@ 2019-11-05 23:31 ` Elijah Newren via GitGitGadget
2019-11-05 23:31 ` [PATCH 3/3] name-hash.c: remove duplicate word in comment Elijah Newren via GitGitGadget
2019-11-06 4:06 ` [PATCH 0/3] Other doc fixes Jeff King
3 siblings, 0 replies; 6+ messages in thread
From: Elijah Newren via GitGitGadget @ 2019-11-05 23:31 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Elijah Newren
From: Elijah Newren <newren@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
hashmap.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hashmap.h b/hashmap.h
index bd2701549f..6036069c23 100644
--- a/hashmap.h
+++ b/hashmap.h
@@ -59,7 +59,7 @@
*
* if (!strcmp("print_all_by_key", action)) {
* struct long2string k, *e;
- * hashmap_entry_init(&k->ent, memhash(&key, sizeof(long)));
+ * hashmap_entry_init(&k.ent, memhash(&key, sizeof(long)));
* k.key = key;
*
* flags &= ~COMPARE_VALUE;
@@ -87,12 +87,12 @@
*
* if (!strcmp("has_exact_match_no_heap_alloc", action)) {
* struct long2string k;
- * hashmap_entry_init(&k->ent, memhash(&key, sizeof(long)));
+ * hashmap_entry_init(&k.ent, memhash(&key, sizeof(long)));
* k.key = key;
*
* flags |= COMPARE_VALUE;
* printf("%sfound\n",
- * hashmap_get(&map, &k->ent, value) ? "" : "not ");
+ * hashmap_get(&map, &k.ent, value) ? "" : "not ");
* }
*
* if (!strcmp("end", action)) {
--
gitgitgadget
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] name-hash.c: remove duplicate word in comment
2019-11-05 23:31 [PATCH 0/3] Other doc fixes Elijah Newren via GitGitGadget
2019-11-05 23:31 ` [PATCH 1/3] git-filter-branch.txt: correct argument name typo Elijah Newren via GitGitGadget
2019-11-05 23:31 ` [PATCH 2/3] hashmap: fix documentation misuses of -> versus Elijah Newren via GitGitGadget
@ 2019-11-05 23:31 ` Elijah Newren via GitGitGadget
2019-11-07 5:41 ` Junio C Hamano
2019-11-06 4:06 ` [PATCH 0/3] Other doc fixes Jeff King
3 siblings, 1 reply; 6+ messages in thread
From: Elijah Newren via GitGitGadget @ 2019-11-05 23:31 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Elijah Newren
From: Elijah Newren <newren@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
name-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/name-hash.c b/name-hash.c
index ceb1d7bd6f..4885bae5da 100644
--- a/name-hash.c
+++ b/name-hash.c
@@ -218,7 +218,7 @@ static int lookup_lazy_params(struct index_state *istate)
* However, the hashmap is going to put items into bucket
* chains based on their hash values. Use that to create n
* mutexes and lock on mutex[bucket(hash) % n]. This will
- * decrease the collision rate by (hopefully) by a factor of n.
+ * decrease the collision rate by (hopefully) a factor of n.
*/
static void init_dir_mutex(void)
{
--
gitgitgadget
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] name-hash.c: remove duplicate word in comment
2019-11-05 23:31 ` [PATCH 3/3] name-hash.c: remove duplicate word in comment Elijah Newren via GitGitGadget
@ 2019-11-07 5:41 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2019-11-07 5:41 UTC (permalink / raw)
To: Elijah Newren via GitGitGadget; +Cc: git, Elijah Newren
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Elijah Newren <newren@gmail.com>
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
> name-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/name-hash.c b/name-hash.c
> index ceb1d7bd6f..4885bae5da 100644
> --- a/name-hash.c
> +++ b/name-hash.c
> @@ -218,7 +218,7 @@ static int lookup_lazy_params(struct index_state *istate)
> * However, the hashmap is going to put items into bucket
> * chains based on their hash values. Use that to create n
> * mutexes and lock on mutex[bucket(hash) % n]. This will
> - * decrease the collision rate by (hopefully) by a factor of n.
> + * decrease the collision rate by (hopefully) a factor of n.
> */
> static void init_dir_mutex(void)
> {
Thanks. Will queue all 3.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Other doc fixes
2019-11-05 23:31 [PATCH 0/3] Other doc fixes Elijah Newren via GitGitGadget
` (2 preceding siblings ...)
2019-11-05 23:31 ` [PATCH 3/3] name-hash.c: remove duplicate word in comment Elijah Newren via GitGitGadget
@ 2019-11-06 4:06 ` Jeff King
3 siblings, 0 replies; 6+ messages in thread
From: Jeff King @ 2019-11-06 4:06 UTC (permalink / raw)
To: Elijah Newren via GitGitGadget; +Cc: git, Junio C Hamano
On Tue, Nov 05, 2019 at 11:31:29PM +0000, Elijah Newren via GitGitGadget wrote:
> In addition to the pile of spelling fixes in my other pull request, here are
> some simple documentation fixes other than spelling errors (remove repeated
> word, '.' vs '->', missing hyphen).
Thanks, these all look trivially correct to me.
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread