git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Hariom Verma <hariom18599@gmail.com>
Subject: [PATCH 0/2] [WIP] removed fetch_if_missing global
Date: Mon, 20 Apr 2020 19:54:35 +0000	[thread overview]
Message-ID: <pull.606.git.1587412477.gitgitgadget@gmail.com> (raw)

We are not much happy with global variable fetch_if_missing. So, in commit
6462d5eb9a ("fetch: remove fetch_if_missing=0", 2019-11-08) Jonathan Tan 
jonathantanmy@google.com [jonathantanmy@google.com] attempted to remove the
need for fetch_if_missing=0 from the fetching mechanism. After that, 
fetch_if_missing is removed from clone and promisor-remote too.

I imitated the same logic to remove fetch_if_missing from fetch-pack & 
index-pack.

I'm looking forward to remove fetch_if_missing from other places too, but I
not sure about how to handle it.

In fsck, fetch_if_missing is set to 0 in the beginning of cmd_fsck().

In rev-list, fetch_if_missing is set to 0 in parse_missing_action_value(),
and in cmd_rev_list() while parsing the command-line parameters.(almost
similar case in pack-objects)

fixes #251

Hariom Verma (2):
  fetch-pack: remove fetch_if_missing=0
  index-pack: remove fetch_if_missing=0

 builtin/fetch-pack.c |  2 --
 builtin/index-pack.c | 11 ++---------
 fetch-pack.c         |  2 +-
 3 files changed, 3 insertions(+), 12 deletions(-)


base-commit: be8661a3286c67a5d4088f4226cbd7f8b76544b0
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-606%2Fharry-hov%2Ffetch-if-missing-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-606/harry-hov/fetch-if-missing-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/606
-- 
gitgitgadget

             reply	other threads:[~2020-04-20 19:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 19:54 Hariom Verma via GitGitGadget [this message]
2020-04-20 19:54 ` [PATCH 1/2] fetch-pack: remove fetch_if_missing=0 Hariom Verma via GitGitGadget
2020-05-07 13:17   ` Christian Couder
2020-05-07 15:02     ` Junio C Hamano
2020-05-09 17:48       ` Hariom verma
2020-05-09 17:40     ` Hariom verma
2020-05-07 19:43   ` Jonathan Tan
2020-05-09 18:00     ` Hariom verma
2023-02-20 18:13     ` Kousik Sanagavarapu
2023-02-22 18:19       ` Jonathan Tan
2023-02-22 17:45     ` Kousik Sanagavarapu
2020-04-20 19:54 ` [PATCH 2/2] index-pack: " Hariom Verma via GitGitGadget
2020-05-07 13:10 ` [PATCH 0/2] [WIP] removed fetch_if_missing global Christian Couder
2020-05-09 17:35   ` Hariom verma
2023-02-17 17:20 ` Kousik Sanagavarapu
2023-02-18 17:00   ` Christian Couder
2023-02-19  3:57     ` Kousik Sanagavarapu
2023-02-19  7:37       ` Christian Couder
2023-02-19 10:40   ` Hariom verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.606.git.1587412477.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hariom18599@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).