From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Hariom Verma via GitGitGadget <gitgitgadget@gmail.com>,
git <git@vger.kernel.org>, Hariom Verma <hariom18599@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH 1/2] fetch-pack: remove fetch_if_missing=0
Date: Thu, 07 May 2020 08:02:09 -0700 [thread overview]
Message-ID: <xmqqmu6j4wlq.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAP8UFD2b_27VeLFg3BrbacoJ5+GAxa+JrF3E2jS_dN-xyCRP_Q@mail.gmail.com> (Christian Couder's message of "Thu, 7 May 2020 15:17:26 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> On Mon, Apr 20, 2020 at 9:57 PM Hariom Verma via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Hariom Verma <hariom18599@gmail.com>
>>
>> Commit 6462d5e ("fetch: remove fetch_if_missing=0", 2019-11-08)
>> strove to remove the need for fetch_if_missing=0 from the fetching
>> mechanism, so it is plausible to attempt removing fetch_if_missing=0
>> from fetch-pack as well.
>
> It's ok to refer to a previous commit, but I think it would be better
> if you could repeat a bit the reasons why removing the
> fetch_if_missing global is a good idea, and not just rely on the
> previous commit.
>
> "it is plausible" also doesn't make it very clear that it's what the
> patch is actually doing.
I had the same reaction. You could even write a random gibberish in
your patch and write "it's plausible this set of random changes made
without understanding what is going on in the current code might
have some chance to work" in your log message, and we would not even
want to touch such a patch with 10-foot pole.
The proposed log message above unfortunately makes this patch
indistinguishable from such a trash, unless we follow the codepaths
that are *not* touched by this patch and think about ramifications
of the removal *ourselves*. In other words, it does nothing to help
the readers to support the change.
next prev parent reply other threads:[~2020-05-07 15:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 19:54 [PATCH 0/2] [WIP] removed fetch_if_missing global Hariom Verma via GitGitGadget
2020-04-20 19:54 ` [PATCH 1/2] fetch-pack: remove fetch_if_missing=0 Hariom Verma via GitGitGadget
2020-05-07 13:17 ` Christian Couder
2020-05-07 15:02 ` Junio C Hamano [this message]
2020-05-09 17:48 ` Hariom verma
2020-05-09 17:40 ` Hariom verma
2020-05-07 19:43 ` Jonathan Tan
2020-05-09 18:00 ` Hariom verma
2023-02-20 18:13 ` Kousik Sanagavarapu
2023-02-22 18:19 ` Jonathan Tan
2023-02-22 17:45 ` Kousik Sanagavarapu
2020-04-20 19:54 ` [PATCH 2/2] index-pack: " Hariom Verma via GitGitGadget
2020-05-07 13:10 ` [PATCH 0/2] [WIP] removed fetch_if_missing global Christian Couder
2020-05-09 17:35 ` Hariom verma
2023-02-17 17:20 ` Kousik Sanagavarapu
2023-02-18 17:00 ` Christian Couder
2023-02-19 3:57 ` Kousik Sanagavarapu
2023-02-19 7:37 ` Christian Couder
2023-02-19 10:40 ` Hariom verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmu6j4wlq.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).