* Bug: git add --patch does not honor "diff.noprefix"
@ 2018-12-06 10:34 Christian Weiske
2018-12-09 1:30 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Christian Weiske @ 2018-12-06 10:34 UTC (permalink / raw)
To: git
Hi,
When running "git add -p" on git version 2.19.2 and "diff.noprefix" set
to true, it still shows the "a/" and "b/" prefixes.
This issue has been reported in 2016 already[1], but is still there in
2.19.2.
[1]
https://public-inbox.org/git/E1D7329A-A54B-4D09-A72A-62ECA8005752@gmail.com/T/
--
Regards/Mit freundlichen Grüßen
Christian Weiske
-=≡ Geeking around in the name of science since 1982 ≡=-
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: git add --patch does not honor "diff.noprefix"
2018-12-06 10:34 Bug: git add --patch does not honor "diff.noprefix" Christian Weiske
@ 2018-12-09 1:30 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-12-09 1:30 UTC (permalink / raw)
To: Christian Weiske; +Cc: git
Christian Weiske <cweiske@cweiske.de> writes:
> When running "git add -p" on git version 2.19.2 and "diff.noprefix" set
> to true, it still shows the "a/" and "b/" prefixes.
>
> This issue has been reported in 2016 already[1], but is still there in
> 2.19.2.
It is very likely because it is a non-issue.
The reason why prefixes are customizable is to match the convention
used to show your patch to others, but the patch to be immediately
consumed within an "add -i/-p" session is viewed only by the user,
so it is much much lower priority to change the code. I guess the
reason why no such change was made is because nobody felt it worth
the trouble to change the code to use a non-standard prefix when
producing the patch to be shown, and then also change the code to
accept a non-standard prefix when using the chosen patch to be
applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-09 1:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 10:34 Bug: git add --patch does not honor "diff.noprefix" Christian Weiske
2018-12-09 1:30 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).