From: Chris Wilson <chris@chris-wilson.co.uk>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev <intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915/gvt: Wean gvt off dev_priv->engine[]
Date: Mon, 21 Oct 2019 09:03:30 +0100 [thread overview]
Message-ID: <157164501001.24426.17278525357815707355@skylake-alporthouse-com> (raw)
In-Reply-To: <20191021053724.GB8745@zhen-hp.sh.intel.com>
Quoting Zhenyu Wang (2019-10-21 06:37:24)
> On 2019.10.16 19:39:02 +0100, Chris Wilson wrote:
> > Stop trying to escape out of the gvt layer to find the engine that we
> > initially setup for use with gvt. Record the engines during initialisation
> > and use them henceforth.
> >
> > add/remove: 1/4 grow/shrink: 22/28 up/down: 341/-1410 (-1069)
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
>
> Thanks for this cleanup! Quick review seems good to me, although it
> looks pretty fine for me on ring_id replacement, this big one also
> includes other changes like indent fix, debugfs item change, etc.
> Could we split them for easier merge? Can have a gvt developer to
> help on that.
Just make gvt/ checkpatch clean so that CI doesn't reject patches
because the surrounding code does not conform to coding style.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-21 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 18:39 [PATCH 1/2] drm/i915/gvt: Wean off struct_mutex Chris Wilson
2019-10-16 18:39 ` [PATCH 2/2] drm/i915/gvt: Wean gvt off dev_priv->engine[] Chris Wilson
2019-10-21 5:37 ` Zhenyu Wang
2019-10-21 8:03 ` Chris Wilson [this message]
2020-01-17 15:15 ` [Intel-gfx] " Jani Nikula
2020-01-19 2:37 ` Zhenyu Wang
2019-10-17 1:38 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gvt: Wean off struct_mutex Patchwork
2019-10-17 2:08 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-21 5:28 ` [PATCH 1/2] " Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157164501001.24426.17278525357815707355@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).