From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Ding, Zhuocheng" <zhuocheng.ding@intel.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev <intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Wean gvt off dev_priv->engine[]
Date: Sun, 19 Jan 2020 10:37:43 +0800 [thread overview]
Message-ID: <20200119023743.GA12595@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <87ftgegllz.fsf@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1356 bytes --]
On 2020.01.17 17:15:36 +0200, Jani Nikula wrote:
> On Mon, 21 Oct 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Zhenyu Wang (2019-10-21 06:37:24)
> >> On 2019.10.16 19:39:02 +0100, Chris Wilson wrote:
> >> > Stop trying to escape out of the gvt layer to find the engine that we
> >> > initially setup for use with gvt. Record the engines during initialisation
> >> > and use them henceforth.
> >> >
> >> > add/remove: 1/4 grow/shrink: 22/28 up/down: 341/-1410 (-1069)
> >> >
> >> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >> > ---
> >>
> >> Thanks for this cleanup! Quick review seems good to me, although it
> >> looks pretty fine for me on ring_id replacement, this big one also
> >> includes other changes like indent fix, debugfs item change, etc.
> >> Could we split them for easier merge? Can have a gvt developer to
> >> help on that.
> >
> > Just make gvt/ checkpatch clean so that CI doesn't reject patches
> > because the surrounding code does not conform to coding style.
>
> Sadly this has fallen between the cracks. Could someone pick this up
> again please, maybe from the gvt team?
>
yes, I've had one person to help on this one, will refresh this later.
Thanks
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-19 2:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 18:39 [PATCH 1/2] drm/i915/gvt: Wean off struct_mutex Chris Wilson
2019-10-16 18:39 ` [PATCH 2/2] drm/i915/gvt: Wean gvt off dev_priv->engine[] Chris Wilson
2019-10-21 5:37 ` Zhenyu Wang
2019-10-21 8:03 ` Chris Wilson
2020-01-17 15:15 ` [Intel-gfx] " Jani Nikula
2020-01-19 2:37 ` Zhenyu Wang [this message]
2019-10-17 1:38 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gvt: Wean off struct_mutex Patchwork
2019-10-17 2:08 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-21 5:28 ` [PATCH 1/2] " Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119023743.GA12595@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).