intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/xe: skip error capture when exec queue is killed
@ 2024-04-25 12:29 Tejas Upadhyay
  2024-04-25 12:21 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (10 more replies)
  0 siblings, 11 replies; 15+ messages in thread
From: Tejas Upadhyay @ 2024-04-25 12:29 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Matthew Brost, Tejas Upadhyay

When user closes exec queue soon after job submission,
we are generating error coredump. Instead check if
exec queue is killed during job timeout then skip
error coredump capture, just free the job and return
proper scheduler state.

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 93e1ee183e4a..376a2c04e899 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -971,7 +971,8 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
 	 * TDR has fired before free job worker. Common if exec queue
 	 * immediately closed after last fence signaled.
 	 */
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &job->fence->flags)) {
+	if (exec_queue_killed(q) || 
+	    test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &job->fence->flags)) {
 		guc_exec_queue_free_job(drm_job);
 
 		return DRM_GPU_SCHED_STAT_NOMINAL;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-04-30 18:50 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 12:29 [PATCH] drm/xe: skip error capture when exec queue is killed Tejas Upadhyay
2024-04-25 12:21 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-25 12:22 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-25 12:23 ` ✓ CI.KUnit: success " Patchwork
2024-04-25 12:34 ` ✓ CI.Build: " Patchwork
2024-04-25 12:37 ` ✓ CI.Hooks: " Patchwork
2024-04-25 12:38 ` ✓ CI.checksparse: " Patchwork
2024-04-25 13:00 ` ✓ CI.BAT: " Patchwork
2024-04-25 16:23 ` [PATCH] " Matthew Brost
2024-04-26 13:46   ` Souza, Jose
2024-04-29 20:32   ` Rodrigo Vivi
2024-04-30  5:19     ` Upadhyay, Tejas
2024-04-26  1:41 ` ✗ CI.FULL: failure for " Patchwork
2024-04-30 15:46 ` [PATCH] " Matthew Brost
2024-04-30 18:49 ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).