* [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
@ 2024-04-26 23:32 Matthew Brost
2024-04-26 23:37 ` ✓ CI.Patch_applied: success for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Matthew Brost @ 2024-04-26 23:32 UTC (permalink / raw)
To: intel-xe; +Cc: Matthew Brost, Thomas Hellström, stable
To be secure, when a userptr is invalidated the pages should be dma
unmapped ensuring the device can no longer touch the invalidated pages.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user pages")
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: stable@vger.kernel.org # 6.8
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_vm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index dfd31b346021..964a5b4d47d8 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct mmu_interval_notifier *mni,
XE_WARN_ON(err);
}
+ if (userptr->sg)
+ xe_hmm_userptr_free_sg(uvma);
+
trace_xe_vma_userptr_invalidate_complete(vma);
return true;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* ✓ CI.Patch_applied: success for drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-26 23:32 [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier Matthew Brost
@ 2024-04-26 23:37 ` Patchwork
2024-04-26 23:37 ` ✓ CI.checkpatch: " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-04-26 23:37 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Unmap userptr in MMU invalidation notifier
URL : https://patchwork.freedesktop.org/series/132978/
State : success
== Summary ==
=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: cd4e45440e67 drm-tip: 2024y-04m-26d-17h-09m-35s UTC integration manifest
=== git am output follows ===
Applying: drm/xe: Unmap userptr in MMU invalidation notifier
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ CI.checkpatch: success for drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-26 23:32 [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier Matthew Brost
2024-04-26 23:37 ` ✓ CI.Patch_applied: success for " Patchwork
@ 2024-04-26 23:37 ` Patchwork
2024-04-26 23:38 ` ✓ CI.KUnit: " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-04-26 23:37 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Unmap userptr in MMU invalidation notifier
URL : https://patchwork.freedesktop.org/series/132978/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f8385750e67305b5cde38af684c52cd2463c4003
Author: Matthew Brost <matthew.brost@intel.com>
Date: Fri Apr 26 16:32:36 2024 -0700
drm/xe: Unmap userptr in MMU invalidation notifier
To be secure, when a userptr is invalidated the pages should be dma
unmapped ensuring the device can no longer touch the invalidated pages.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user pages")
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: stable@vger.kernel.org # 6.8
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
+ /mt/dim checkpatch cd4e45440e6710d7a1d097cd2fbac455bdecb68a drm-intel
f8385750e673 drm/xe: Unmap userptr in MMU invalidation notifier
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ CI.KUnit: success for drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-26 23:32 [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier Matthew Brost
2024-04-26 23:37 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-26 23:37 ` ✓ CI.checkpatch: " Patchwork
@ 2024-04-26 23:38 ` Patchwork
2024-04-29 1:11 ` [PATCH] " Matthew Brost
2024-04-29 13:55 ` Zeng, Oak
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2024-04-26 23:38 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Unmap userptr in MMU invalidation notifier
URL : https://patchwork.freedesktop.org/series/132978/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[23:37:58] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[23:38:02] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
../arch/x86/um/user-offsets.c:17:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
17 | void foo(void)
| ^~~
In file included from ../arch/um/kernel/asm-offsets.c:1:
../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
../arch/x86/um/bugs_64.c:9:6: warning: no previous prototype for ‘arch_check_bugs’ [-Wmissing-prototypes]
9 | void arch_check_bugs(void)
| ^~~~~~~~~~~~~~~
../arch/x86/um/bugs_64.c:13:6: warning: no previous prototype for ‘arch_examine_signal’ [-Wmissing-prototypes]
13 | void arch_examine_signal(int sig, struct uml_pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~
../arch/x86/um/fault.c:18:5: warning: no previous prototype for ‘arch_fixup’ [-Wmissing-prototypes]
18 | int arch_fixup(unsigned long address, struct uml_pt_regs *regs)
| ^~~~~~~~~~
../arch/x86/um/os-Linux/registers.c:146:15: warning: no previous prototype for ‘get_thread_reg’ [-Wmissing-prototypes]
146 | unsigned long get_thread_reg(int reg, jmp_buf *buf)
| ^~~~~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:16:5: warning: no previous prototype for ‘__vdso_clock_gettime’ [-Wmissing-prototypes]
16 | int __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
| ^~~~~~~~~~~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:30:5: warning: no previous prototype for ‘__vdso_gettimeofday’ [-Wmissing-prototypes]
30 | int __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
| ^~~~~~~~~~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:44:21: warning: no previous prototype for ‘__vdso_time’ [-Wmissing-prototypes]
44 | __kernel_old_time_t __vdso_time(__kernel_old_time_t *t)
| ^~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:57:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes]
57 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
| ^~~~~~~~~~~~~
../arch/um/os-Linux/skas/process.c:107:6: warning: no previous prototype for ‘wait_stub_done’ [-Wmissing-prototypes]
107 | void wait_stub_done(int pid)
| ^~~~~~~~~~~~~~
../arch/um/os-Linux/skas/process.c:683:6: warning: no previous prototype for ‘__switch_mm’ [-Wmissing-prototypes]
683 | void __switch_mm(struct mm_id *mm_idp)
| ^~~~~~~~~~~
../arch/x86/um/os-Linux/mcontext.c:7:6: warning: no previous prototype for ‘get_regs_from_mc’ [-Wmissing-prototypes]
7 | void get_regs_from_mc(struct uml_pt_regs *regs, mcontext_t *mc)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:17:5: warning: no previous prototype for ‘init_new_context’ [-Wmissing-prototypes]
17 | int init_new_context(struct task_struct *task, struct mm_struct *mm)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:60:6: warning: no previous prototype for ‘destroy_context’ [-Wmissing-prototypes]
60 | void destroy_context(struct mm_struct *mm)
| ^~~~~~~~~~~~~~~
../arch/um/os-Linux/main.c:187:7: warning: no previous prototype for ‘__wrap_malloc’ [-Wmissing-prototypes]
187 | void *__wrap_malloc(int size)
| ^~~~~~~~~~~~~
../arch/um/os-Linux/main.c:208:7: warning: no previous prototype for ‘__wrap_calloc’ [-Wmissing-prototypes]
208 | void *__wrap_calloc(int n, int size)
| ^~~~~~~~~~~~~
../arch/um/os-Linux/main.c:222:6: warning: no previous prototype for ‘__wrap_free’ [-Wmissing-prototypes]
222 | void __wrap_free(void *ptr)
| ^~~~~~~~~~~
../arch/um/os-Linux/mem.c:28:6: warning: no previous prototype for ‘kasan_map_memory’ [-Wmissing-prototypes]
28 | void kasan_map_memory(void *start, size_t len)
| ^~~~~~~~~~~~~~~~
../arch/um/os-Linux/mem.c:212:13: warning: no previous prototype for ‘check_tmpexec’ [-Wmissing-prototypes]
212 | void __init check_tmpexec(void)
| ^~~~~~~~~~~~~
../arch/um/kernel/skas/process.c:36:12: warning: no previous prototype for ‘start_uml’ [-Wmissing-prototypes]
36 | int __init start_uml(void)
| ^~~~~~~~~
../arch/x86/um/ptrace_64.c:111:5: warning: no previous prototype for ‘poke_user’ [-Wmissing-prototypes]
111 | int poke_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/x86/um/ptrace_64.c:171:5: warning: no previous prototype for ‘peek_user’ [-Wmissing-prototypes]
171 | int peek_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/um/os-Linux/signal.c:75:6: warning: no previous prototype for ‘sig_handler’ [-Wmissing-prototypes]
75 | void sig_handler(int sig, struct siginfo *si, mcontext_t *mc)
| ^~~~~~~~~~~
../arch/um/os-Linux/signal.c:111:6: warning: no previous prototype for ‘timer_alarm_handler’ [-Wmissing-prototypes]
111 | void timer_alarm_handler(int sig, struct siginfo *unused_si, mcontext_t *mc)
| ^~~~~~~~~~~~~~~~~~~
../arch/um/os-Linux/start_up.c:301:12: warning: no previous prototype for ‘parse_iomem’ [-Wmissing-prototypes]
301 | int __init parse_iomem(char *str, int *add)
| ^~~~~~~~~~~
../arch/x86/um/signal.c:560:6: warning: no previous prototype for ‘sys_rt_sigreturn’ [-Wmissing-prototypes]
560 | long sys_rt_sigreturn(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/mem.c:202:8: warning: no previous prototype for ‘pgd_alloc’ [-Wmissing-prototypes]
202 | pgd_t *pgd_alloc(struct mm_struct *mm)
| ^~~~~~~~~
../arch/um/kernel/mem.c:215:7: warning: no previous prototype for ‘uml_kmalloc’ [-Wmissing-prototypes]
215 | void *uml_kmalloc(int size, int flags)
| ^~~~~~~~~~~
../arch/x86/um/syscalls_64.c:48:6: warning: no previous prototype for ‘arch_switch_to’ [-Wmissing-prototypes]
48 | void arch_switch_to(struct task_struct *to)
| ^~~~~~~~~~~~~~
../arch/um/kernel/process.c:51:5: warning: no previous prototype for ‘pid_to_processor_id’ [-Wmissing-prototypes]
51 | int pid_to_processor_id(int pid)
| ^~~~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:87:7: warning: no previous prototype for ‘__switch_to’ [-Wmissing-prototypes]
87 | void *__switch_to(struct task_struct *from, struct task_struct *to)
| ^~~~~~~~~~~
../arch/um/kernel/process.c:140:6: warning: no previous prototype for ‘fork_handler’ [-Wmissing-prototypes]
140 | void fork_handler(void)
| ^~~~~~~~~~~~
../arch/um/kernel/process.c:217:6: warning: no previous prototype for ‘arch_cpu_idle’ [-Wmissing-prototypes]
217 | void arch_cpu_idle(void)
| ^~~~~~~~~~~~~
../arch/um/kernel/process.c:253:5: warning: no previous prototype for ‘copy_to_user_proc’ [-Wmissing-prototypes]
253 | int copy_to_user_proc(void __user *to, void *from, int size)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:263:5: warning: no previous prototype for ‘clear_user_proc’ [-Wmissing-prototypes]
263 | int clear_user_proc(void __user *buf, int size)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/process.c:271:6: warning: no previous prototype for ‘set_using_sysemu’ [-Wmissing-prototypes]
271 | void set_using_sysemu(int value)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:278:5: warning: no previous prototype for ‘get_using_sysemu’ [-Wmissing-prototypes]
278 | int get_using_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:316:12: warning: no previous prototype for ‘make_proc_sysemu’ [-Wmissing-prototypes]
316 | int __init make_proc_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:348:15: warning: no previous prototype for ‘arch_align_stack’ [-Wmissing-prototypes]
348 | unsigned long arch_align_stack(unsigned long sp)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:45:6: warning: no previous prototype for ‘machine_restart’ [-Wmissing-prototypes]
45 | void machine_restart(char * __unused)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:51:6: warning: no previous prototype for ‘machine_power_off’ [-Wmissing-prototypes]
51 | void machine_power_off(void)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:57:6: warning: no previous prototype for ‘machine_halt’ [-Wmissing-prototypes]
57 | void machine_halt(void)
| ^~~~~~~~~~~~
../arch/um/kernel/tlb.c:579:6: warning: no previous prototype for ‘flush_tlb_mm_range’ [-Wmissing-prototypes]
579 | void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
| ^~~~~~~~~~~~~~~~~~
../arch/um/kernel/tlb.c:594:6: warning: no previous prototype for ‘force_flush_all’ [-Wmissing-prototypes]
594 | void force_flush_all(void)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/um_arch.c:408:19: warning: no previous prototype for ‘read_initrd’ [-Wmissing-prototypes]
408 | int __init __weak read_initrd(void)
| ^~~~~~~~~~~
../arch/um/kernel/um_arch.c:461:7: warning: no previous prototype for ‘text_poke’ [-Wmissing-prototypes]
461 | void *text_poke(void *addr, const void *opcode, size_t len)
| ^~~~~~~~~
../arch/um/kernel/um_arch.c:473:6: warning: no previous prototype for ‘text_poke_sync’ [-Wmissing-prototypes]
473 | void text_poke_sync(void)
| ^~~~~~~~~~~~~~
../arch/um/kernel/kmsg_dump.c:60:12: warning: no previous prototype for ‘kmsg_dumper_stdout_init’ [-Wmissing-prototypes]
60 | int __init kmsg_dumper_stdout_init(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
156 | u64 ioread64_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
163 | u64 ioread64_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
170 | u64 ioread64be_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
178 | u64 ioread64be_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
stty: 'standard input': Inappropriate ioctl for device
[23:38:27] Starting KUnit Kernel (1/1)...
[23:38:27] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:38:27] =================== guc_dbm (7 subtests) ===================
[23:38:27] [PASSED] test_empty
[23:38:27] [PASSED] test_default
[23:38:27] ======================== test_size ========================
[23:38:27] [PASSED] 4
[23:38:27] [PASSED] 8
[23:38:27] [PASSED] 32
[23:38:27] [PASSED] 256
[23:38:27] ==================== [PASSED] test_size ====================
[23:38:27] ======================= test_reuse ========================
[23:38:27] [PASSED] 4
[23:38:27] [PASSED] 8
[23:38:27] [PASSED] 32
[23:38:27] [PASSED] 256
[23:38:27] =================== [PASSED] test_reuse ====================
[23:38:27] =================== test_range_overlap ====================
[23:38:27] [PASSED] 4
[23:38:27] [PASSED] 8
[23:38:27] [PASSED] 32
[23:38:27] [PASSED] 256
[23:38:27] =============== [PASSED] test_range_overlap ================
[23:38:27] =================== test_range_compact ====================
[23:38:27] [PASSED] 4
[23:38:27] [PASSED] 8
[23:38:27] [PASSED] 32
[23:38:27] [PASSED] 256
[23:38:27] =============== [PASSED] test_range_compact ================
[23:38:27] ==================== test_range_spare =====================
[23:38:27] [PASSED] 4
[23:38:27] [PASSED] 8
[23:38:27] [PASSED] 32
[23:38:27] [PASSED] 256
[23:38:27] ================ [PASSED] test_range_spare =================
[23:38:27] ===================== [PASSED] guc_dbm =====================
[23:38:27] =================== guc_idm (6 subtests) ===================
[23:38:27] [PASSED] bad_init
[23:38:27] [PASSED] no_init
[23:38:27] [PASSED] init_fini
[23:38:27] [PASSED] check_used
[23:38:27] [PASSED] check_quota
[23:38:27] [PASSED] check_all
[23:38:27] ===================== [PASSED] guc_idm =====================
[23:38:27] ================== no_relay (3 subtests) ===================
[23:38:27] [PASSED] xe_drops_guc2pf_if_not_ready
[23:38:27] [PASSED] xe_drops_guc2vf_if_not_ready
[23:38:27] [PASSED] xe_rejects_send_if_not_ready
[23:38:27] ==================== [PASSED] no_relay =====================
[23:38:27] ================== pf_relay (14 subtests) ==================
[23:38:27] [PASSED] pf_rejects_guc2pf_too_short
[23:38:27] [PASSED] pf_rejects_guc2pf_too_long
[23:38:27] [PASSED] pf_rejects_guc2pf_no_payload
[23:38:27] [PASSED] pf_fails_no_payload
[23:38:27] [PASSED] pf_fails_bad_origin
[23:38:27] [PASSED] pf_fails_bad_type
[23:38:27] [PASSED] pf_txn_reports_error
[23:38:27] [PASSED] pf_txn_sends_pf2guc
[23:38:27] [PASSED] pf_sends_pf2guc
[23:38:27] [SKIPPED] pf_loopback_nop
[23:38:27] [SKIPPED] pf_loopback_echo
[23:38:27] [SKIPPED] pf_loopback_fail
[23:38:27] [SKIPPED] pf_loopback_busy
[23:38:27] [SKIPPED] pf_loopback_retry
[23:38:27] ==================== [PASSED] pf_relay =====================
[23:38:27] ================== vf_relay (3 subtests) ===================
[23:38:27] [PASSED] vf_rejects_guc2vf_too_short
[23:38:27] [PASSED] vf_rejects_guc2vf_too_long
[23:38:27] [PASSED] vf_rejects_guc2vf_no_payload
[23:38:27] ==================== [PASSED] vf_relay =====================
[23:38:27] ================= pf_service (11 subtests) =================
[23:38:27] [PASSED] pf_negotiate_any
[23:38:27] [PASSED] pf_negotiate_base_match
[23:38:27] [PASSED] pf_negotiate_base_newer
[23:38:27] [PASSED] pf_negotiate_base_next
[23:38:27] [SKIPPED] pf_negotiate_base_older
[23:38:27] [PASSED] pf_negotiate_base_prev
[23:38:27] [PASSED] pf_negotiate_latest_match
[23:38:27] [PASSED] pf_negotiate_latest_newer
[23:38:27] [PASSED] pf_negotiate_latest_next
[23:38:27] [SKIPPED] pf_negotiate_latest_older
[23:38:27] [SKIPPED] pf_negotiate_latest_prev
[23:38:27] =================== [PASSED] pf_service ====================
[23:38:27] ===================== lmtt (1 subtest) =====================
[23:38:27] ======================== test_ops =========================
[23:38:27] [PASSED] 2-level
[23:38:27] [PASSED] multi-level
[23:38:27] ==================== [PASSED] test_ops =====================
[23:38:27] ====================== [PASSED] lmtt =======================
[23:38:27] ==================== xe_bo (2 subtests) ====================
[23:38:27] [SKIPPED] xe_ccs_migrate_kunit
[23:38:27] [SKIPPED] xe_bo_evict_kunit
[23:38:27] ===================== [SKIPPED] xe_bo ======================
[23:38:27] ================== xe_dma_buf (1 subtest) ==================
[23:38:27] [SKIPPED] xe_dma_buf_kunit
[23:38:27] =================== [SKIPPED] xe_dma_buf ===================
[23:38:27] ================== xe_migrate (1 subtest) ==================
[23:38:27] [SKIPPED] xe_migrate_sanity_kunit
[23:38:27] =================== [SKIPPED] xe_migrate ===================
[23:38:27] =================== xe_mocs (2 subtests) ===================
[23:38:27] [SKIPPED] xe_live_mocs_kernel_kunit
[23:38:27] [SKIPPED] xe_live_mocs_reset_kunit
[23:38:27] ==================== [SKIPPED] xe_mocs =====================
[23:38:27] =================== xe_pci (2 subtests) ====================
[23:38:27] [PASSED] xe_gmdid_graphics_ip
[23:38:27] [PASSED] xe_gmdid_media_ip
[23:38:27] ===================== [PASSED] xe_pci ======================
[23:38:27] ==================== xe_rtp (1 subtest) ====================
[23:38:27] ================== xe_rtp_process_tests ===================
[23:38:27] [PASSED] coalesce-same-reg
[23:38:27] [PASSED] no-match-no-add
[23:38:27] [PASSED] no-match-no-add-multiple-rules
[23:38:27] [PASSED] two-regs-two-entries
[23:38:27] [PASSED] clr-one-set-other
[23:38:27] [PASSED] set-field
[23:38:27] [PASSED] conflict-duplicate
[23:38:27] [PASSED] conflict-not-disjoint
[23:38:27] [PASSED] conflict-reg-type
[23:38:27] ============== [PASSED] xe_rtp_process_tests ===============
[23:38:27] ===================== [PASSED] xe_rtp ======================
[23:38:27] ==================== xe_wa (1 subtest) =====================
[23:38:27] ======================== xe_wa_gt =========================
[23:38:27] [PASSED] TIGERLAKE (B0)
[23:38:27] [PASSED] DG1 (A0)
[23:38:27] [PASSED] DG1 (B0)
[23:38:27] [PASSED] ALDERLAKE_S (A0)
[23:38:27] [PASSED] ALDERLAKE_S (B0)
[23:38:27] [PASSED] ALDERLAKE_S (C0)
[23:38:27] [PASSED] ALDERLAKE_S (D0)
[23:38:27] [PASSED] ALDERLAKE_P (A0)
[23:38:27] [PASSED] ALDERLAKE_P (B0)
[23:38:27] [PASSED] ALDERLAKE_P (C0)
[23:38:27] [PASSED] ALDERLAKE_S_RPLS (D0)
[23:38:27] [PASSED] ALDERLAKE_P_RPLU (E0)
[23:38:27] [PASSED] DG2_G10 (C0)
[23:38:27] [PASSED] DG2_G11 (B1)
[23:38:27] [PASSED] DG2_G12 (A1)
[23:38:27] [PASSED] METEORLAKE (g:A0, m:A0)
[23:38:27] [PASSED] METEORLAKE (g:A0, m:A0)
[23:38:27] [PASSED] METEORLAKE (g:A0, m:A0)
[23:38:27] [PASSED] LUNARLAKE (g:A0, m:A0)
[23:38:27] [PASSED] LUNARLAKE (g:B0, m:A0)
[23:38:27] ==================== [PASSED] xe_wa_gt =====================
[23:38:27] ====================== [PASSED] xe_wa ======================
[23:38:27] ============================================================
[23:38:27] Testing complete. Ran 98 tests: passed: 84, skipped: 14
[23:38:27] Elapsed time: 29.442s total, 4.212s configuring, 25.011s building, 0.210s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[23:38:28] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[23:38:29] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
In file included from ../arch/um/kernel/asm-offsets.c:1:
../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
../arch/x86/um/syscalls_64.c:48:6: warning: no previous prototype for ‘arch_switch_to’ [-Wmissing-prototypes]
48 | void arch_switch_to(struct task_struct *to)
| ^~~~~~~~~~~~~~
../arch/um/kernel/mem.c:202:8: warning: no previous prototype for ‘pgd_alloc’ [-Wmissing-prototypes]
202 | pgd_t *pgd_alloc(struct mm_struct *mm)
| ^~~~~~~~~
../arch/um/kernel/mem.c:215:7: warning: no previous prototype for ‘uml_kmalloc’ [-Wmissing-prototypes]
215 | void *uml_kmalloc(int size, int flags)
| ^~~~~~~~~~~
../arch/x86/um/ptrace_64.c:111:5: warning: no previous prototype for ‘poke_user’ [-Wmissing-prototypes]
111 | int poke_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/x86/um/ptrace_64.c:171:5: warning: no previous prototype for ‘peek_user’ [-Wmissing-prototypes]
171 | int peek_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/um/kernel/process.c:51:5: warning: no previous prototype for ‘pid_to_processor_id’ [-Wmissing-prototypes]
51 | int pid_to_processor_id(int pid)
| ^~~~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:87:7: warning: no previous prototype for ‘__switch_to’ [-Wmissing-prototypes]
87 | void *__switch_to(struct task_struct *from, struct task_struct *to)
| ^~~~~~~~~~~
../arch/um/kernel/process.c:140:6: warning: no previous prototype for ‘fork_handler’ [-Wmissing-prototypes]
140 | void fork_handler(void)
| ^~~~~~~~~~~~
../arch/um/kernel/process.c:217:6: warning: no previous prototype for ‘arch_cpu_idle’ [-Wmissing-prototypes]
217 | void arch_cpu_idle(void)
| ^~~~~~~~~~~~~
../arch/um/kernel/process.c:253:5: warning: no previous prototype for ‘copy_to_user_proc’ [-Wmissing-prototypes]
253 | int copy_to_user_proc(void __user *to, void *from, int size)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:263:5: warning: no previous prototype for ‘clear_user_proc’ [-Wmissing-prototypes]
263 | int clear_user_proc(void __user *buf, int size)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/process.c:271:6: warning: no previous prototype for ‘set_using_sysemu’ [-Wmissing-prototypes]
271 | void set_using_sysemu(int value)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:278:5: warning: no previous prototype for ‘get_using_sysemu’ [-Wmissing-prototypes]
278 | int get_using_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:316:12: warning: no previous prototype for ‘make_proc_sysemu’ [-Wmissing-prototypes]
316 | int __init make_proc_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/x86/um/signal.c:560:6: warning: no previous prototype for ‘sys_rt_sigreturn’ [-Wmissing-prototypes]
560 | long sys_rt_sigreturn(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:348:15: warning: no previous prototype for ‘arch_align_stack’ [-Wmissing-prototypes]
348 | unsigned long arch_align_stack(unsigned long sp)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:45:6: warning: no previous prototype for ‘machine_restart’ [-Wmissing-prototypes]
45 | void machine_restart(char * __unused)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:51:6: warning: no previous prototype for ‘machine_power_off’ [-Wmissing-prototypes]
51 | void machine_power_off(void)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:57:6: warning: no previous prototype for ‘machine_halt’ [-Wmissing-prototypes]
57 | void machine_halt(void)
| ^~~~~~~~~~~~
../arch/um/kernel/tlb.c:579:6: warning: no previous prototype for ‘flush_tlb_mm_range’ [-Wmissing-prototypes]
579 | void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
| ^~~~~~~~~~~~~~~~~~
../arch/um/kernel/tlb.c:594:6: warning: no previous prototype for ‘force_flush_all’ [-Wmissing-prototypes]
594 | void force_flush_all(void)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/um_arch.c:408:19: warning: no previous prototype for ‘read_initrd’ [-Wmissing-prototypes]
408 | int __init __weak read_initrd(void)
| ^~~~~~~~~~~
../arch/um/kernel/um_arch.c:461:7: warning: no previous prototype for ‘text_poke’ [-Wmissing-prototypes]
461 | void *text_poke(void *addr, const void *opcode, size_t len)
| ^~~~~~~~~
../arch/um/kernel/um_arch.c:473:6: warning: no previous prototype for ‘text_poke_sync’ [-Wmissing-prototypes]
473 | void text_poke_sync(void)
| ^~~~~~~~~~~~~~
../arch/um/kernel/kmsg_dump.c:60:12: warning: no previous prototype for ‘kmsg_dumper_stdout_init’ [-Wmissing-prototypes]
60 | int __init kmsg_dumper_stdout_init(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
../arch/um/kernel/skas/process.c:36:12: warning: no previous prototype for ‘start_uml’ [-Wmissing-prototypes]
36 | int __init start_uml(void)
| ^~~~~~~~~
../arch/um/kernel/skas/mmu.c:17:5: warning: no previous prototype for ‘init_new_context’ [-Wmissing-prototypes]
17 | int init_new_context(struct task_struct *task, struct mm_struct *mm)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:60:6: warning: no previous prototype for ‘destroy_context’ [-Wmissing-prototypes]
60 | void destroy_context(struct mm_struct *mm)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
156 | u64 ioread64_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
163 | u64 ioread64_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
170 | u64 ioread64be_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
178 | u64 ioread64be_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
[23:38:50] Starting KUnit Kernel (1/1)...
[23:38:50] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:38:50] ============ drm_test_pick_cmdline (2 subtests) ============
[23:38:50] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[23:38:50] =============== drm_test_pick_cmdline_named ===============
[23:38:50] [PASSED] NTSC
[23:38:50] [PASSED] NTSC-J
[23:38:50] [PASSED] PAL
[23:38:50] [PASSED] PAL-M
[23:38:50] =========== [PASSED] drm_test_pick_cmdline_named ===========
[23:38:50] ============== [PASSED] drm_test_pick_cmdline ==============
[23:38:50] ================== drm_buddy (7 subtests) ==================
[23:38:50] [PASSED] drm_test_buddy_alloc_limit
[23:38:50] [PASSED] drm_test_buddy_alloc_optimistic
[23:38:50] [PASSED] drm_test_buddy_alloc_pessimistic
[23:38:50] [PASSED] drm_test_buddy_alloc_pathological
[23:38:50] [PASSED] drm_test_buddy_alloc_contiguous
[23:38:50] [PASSED] drm_test_buddy_alloc_clear
[23:38:50] [PASSED] drm_test_buddy_alloc_range_bias
[23:38:50] ==================== [PASSED] drm_buddy ====================
[23:38:50] ============= drm_cmdline_parser (40 subtests) =============
[23:38:50] [PASSED] drm_test_cmdline_force_d_only
[23:38:50] [PASSED] drm_test_cmdline_force_D_only_dvi
[23:38:50] [PASSED] drm_test_cmdline_force_D_only_hdmi
[23:38:50] [PASSED] drm_test_cmdline_force_D_only_not_digital
[23:38:50] [PASSED] drm_test_cmdline_force_e_only
[23:38:50] [PASSED] drm_test_cmdline_res
[23:38:50] [PASSED] drm_test_cmdline_res_vesa
[23:38:50] [PASSED] drm_test_cmdline_res_vesa_rblank
[23:38:50] [PASSED] drm_test_cmdline_res_rblank
[23:38:50] [PASSED] drm_test_cmdline_res_bpp
[23:38:50] [PASSED] drm_test_cmdline_res_refresh
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[23:38:50] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[23:38:50] [PASSED] drm_test_cmdline_res_margins_force_on
[23:38:50] [PASSED] drm_test_cmdline_res_vesa_margins
[23:38:50] [PASSED] drm_test_cmdline_name
[23:38:50] [PASSED] drm_test_cmdline_name_bpp
[23:38:50] [PASSED] drm_test_cmdline_name_option
[23:38:50] [PASSED] drm_test_cmdline_name_bpp_option
[23:38:50] [PASSED] drm_test_cmdline_rotate_0
[23:38:50] [PASSED] drm_test_cmdline_rotate_90
[23:38:50] [PASSED] drm_test_cmdline_rotate_180
[23:38:50] [PASSED] drm_test_cmdline_rotate_270
[23:38:50] [PASSED] drm_test_cmdline_hmirror
[23:38:50] [PASSED] drm_test_cmdline_vmirror
[23:38:50] [PASSED] drm_test_cmdline_margin_options
[23:38:50] [PASSED] drm_test_cmdline_multiple_options
[23:38:50] [PASSED] drm_test_cmdline_bpp_extra_and_option
[23:38:50] [PASSED] drm_test_cmdline_extra_and_option
[23:38:50] [PASSED] drm_test_cmdline_freestanding_options
[23:38:50] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[23:38:50] [PASSED] drm_test_cmdline_panel_orientation
[23:38:50] ================ drm_test_cmdline_invalid =================
[23:38:50] [PASSED] margin_only
[23:38:50] [PASSED] interlace_only
[23:38:50] [PASSED] res_missing_x
[23:38:50] [PASSED] res_missing_y
[23:38:50] [PASSED] res_bad_y
[23:38:50] [PASSED] res_missing_y_bpp
[23:38:50] [PASSED] res_bad_bpp
[23:38:50] [PASSED] res_bad_refresh
[23:38:50] [PASSED] res_bpp_refresh_force_on_off
[23:38:50] [PASSED] res_invalid_mode
[23:38:50] [PASSED] res_bpp_wrong_place_mode
[23:38:50] [PASSED] name_bpp_refresh
[23:38:50] [PASSED] name_refresh
[23:38:50] [PASSED] name_refresh_wrong_mode
[23:38:50] [PASSED] name_refresh_invalid_mode
[23:38:50] [PASSED] rotate_multiple
[23:38:50] [PASSED] rotate_invalid_val
[23:38:50] [PASSED] rotate_truncated
[23:38:50] [PASSED] invalid_option
[23:38:50] [PASSED] invalid_tv_option
[23:38:50] [PASSED] truncated_tv_option
[23:38:50] ============ [PASSED] drm_test_cmdline_invalid =============
[23:38:50] =============== drm_test_cmdline_tv_options ===============
[23:38:50] [PASSED] NTSC
[23:38:50] [PASSED] NTSC_443
[23:38:50] [PASSED] NTSC_J
[23:38:50] [PASSED] PAL
[23:38:50] [PASSED] PAL_M
[23:38:50] [PASSED] PAL_N
[23:38:50] [PASSED] SECAM
[23:38:50] =========== [PASSED] drm_test_cmdline_tv_options ===========
[23:38:50] =============== [PASSED] drm_cmdline_parser ================
[23:38:50] ============= drmm_connector_init (3 subtests) =============
[23:38:50] [PASSED] drm_test_drmm_connector_init
[23:38:50] [PASSED] drm_test_drmm_connector_init_null_ddc
[23:38:50] ========= drm_test_drmm_connector_init_type_valid =========
[23:38:50] [PASSED] Unknown
[23:38:50] [PASSED] VGA
[23:38:50] [PASSED] DVI-I
[23:38:50] [PASSED] DVI-D
[23:38:50] [PASSED] DVI-A
[23:38:50] [PASSED] Composite
[23:38:50] [PASSED] SVIDEO
[23:38:50] [PASSED] LVDS
[23:38:50] [PASSED] Component
[23:38:50] [PASSED] DIN
[23:38:50] [PASSED] DP
[23:38:50] [PASSED] HDMI-A
[23:38:50] [PASSED] HDMI-B
[23:38:50] [PASSED] TV
[23:38:50] [PASSED] eDP
[23:38:50] [PASSED] Virtual
[23:38:50] [PASSED] DSI
[23:38:50] [PASSED] DPI
[23:38:50] [PASSED] Writeback
[23:38:50] [PASSED] SPI
[23:38:50] [PASSED] USB
[23:38:50] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[23:38:50] =============== [PASSED] drmm_connector_init ===============
[23:38:50] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[23:38:50] ========== drm_test_get_tv_mode_from_name_valid ===========
[23:38:50] [PASSED] NTSC
[23:38:50] [PASSED] NTSC-443
[23:38:50] [PASSED] NTSC-J
[23:38:50] [PASSED] PAL
[23:38:50] [PASSED] PAL-M
[23:38:50] [PASSED] PAL-N
[23:38:50] [PASSED] SECAM
[23:38:50] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[23:38:50] [PASSED] drm_test_get_tv_mode_from_name_truncated
[23:38:50] ============ [PASSED] drm_get_tv_mode_from_name ============
[23:38:50] ============= drm_damage_helper (21 subtests) ==============
[23:38:50] [PASSED] drm_test_damage_iter_no_damage
[23:38:50] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[23:38:50] [PASSED] drm_test_damage_iter_no_damage_src_moved
[23:38:50] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[23:38:50] [PASSED] drm_test_damage_iter_no_damage_not_visible
[23:38:50] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[23:38:50] [PASSED] drm_test_damage_iter_no_damage_no_fb
[23:38:50] [PASSED] drm_test_damage_iter_simple_damage
[23:38:50] [PASSED] drm_test_damage_iter_single_damage
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_outside_src
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_src_moved
[23:38:50] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[23:38:50] [PASSED] drm_test_damage_iter_damage
[23:38:50] [PASSED] drm_test_damage_iter_damage_one_intersect
[23:38:50] [PASSED] drm_test_damage_iter_damage_one_outside
[23:38:50] [PASSED] drm_test_damage_iter_damage_src_moved
[23:38:50] [PASSED] drm_test_damage_iter_damage_not_visible
[23:38:50] ================ [PASSED] drm_damage_helper ================
[23:38:50] ============== drm_dp_mst_helper (3 subtests) ==============
[23:38:50] ============== drm_test_dp_mst_calc_pbn_mode ==============
[23:38:50] [PASSED] Clock 154000 BPP 30 DSC disabled
[23:38:50] [PASSED] Clock 234000 BPP 30 DSC disabled
[23:38:50] [PASSED] Clock 297000 BPP 24 DSC disabled
[23:38:50] [PASSED] Clock 332880 BPP 24 DSC enabled
[23:38:50] [PASSED] Clock 324540 BPP 24 DSC enabled
[23:38:50] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[23:38:50] ============== drm_test_dp_mst_calc_pbn_div ===============
[23:38:50] [PASSED] Link rate 2000000 lane count 4
[23:38:50] [PASSED] Link rate 2000000 lane count 2
[23:38:50] [PASSED] Link rate 2000000 lane count 1
[23:38:50] [PASSED] Link rate 1350000 lane count 4
[23:38:50] [PASSED] Link rate 1350000 lane count 2
[23:38:50] [PASSED] Link rate 1350000 lane count 1
[23:38:50] [PASSED] Link rate 1000000 lane count 4
[23:38:50] [PASSED] Link rate 1000000 lane count 2
[23:38:50] [PASSED] Link rate 1000000 lane count 1
[23:38:50] [PASSED] Link rate 810000 lane count 4
[23:38:50] [PASSED] Link rate 810000 lane count 2
[23:38:50] [PASSED] Link rate 810000 lane count 1
[23:38:50] [PASSED] Link rate 540000 lane count 4
[23:38:50] [PASSED] Link rate 540000 lane count 2
[23:38:50] [PASSED] Link rate 540000 lane count 1
[23:38:50] [PASSED] Link rate 270000 lane count 4
[23:38:50] [PASSED] Link rate 270000 lane count 2
[23:38:50] [PASSED] Link rate 270000 lane count 1
[23:38:50] [PASSED] Link rate 162000 lane count 4
[23:38:50] [PASSED] Link rate 162000 lane count 2
[23:38:50] [PASSED] Link rate 162000 lane count 1
[23:38:50] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[23:38:50] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[23:38:50] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[23:38:50] [PASSED] DP_POWER_UP_PHY with port number
[23:38:50] [PASSED] DP_POWER_DOWN_PHY with port number
[23:38:50] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[23:38:50] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[23:38:50] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[23:38:50] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[23:38:50] [PASSED] DP_QUERY_PAYLOAD with port number
[23:38:50] [PASSED] DP_QUERY_PAYLOAD with VCPI
[23:38:50] [PASSED] DP_REMOTE_DPCD_READ with port number
[23:38:50] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[23:38:50] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[23:38:50] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[23:38:50] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[23:38:50] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[23:38:50] [PASSED] DP_REMOTE_I2C_READ with port number
[23:38:50] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[23:38:50] [PASSED] DP_REMOTE_I2C_READ with transactions array
[23:38:50] [PASSED] DP_REMOTE_I2C_WRITE with port number
[23:38:50] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[23:38:50] [PASSED] DP_REMOTE_I2C_WRITE with data array
[23:38:50] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[23:38:50] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[23:38:50] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[23:38:50] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[23:38:50] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[23:38:50] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[23:38:50] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[23:38:50] ================ [PASSED] drm_dp_mst_helper ================
[23:38:50] ================== drm_exec (7 subtests) ===================
[23:38:50] [PASSED] sanitycheck
[23:38:50] [PASSED] test_lock
[23:38:50] [PASSED] test_lock_unlock
[23:38:50] [PASSED] test_duplicates
[23:38:50] [PASSED] test_prepare
[23:38:50] [PASSED] test_prepare_array
[23:38:50] [PASSED] test_multiple_loops
[23:38:50] ==================== [PASSED] drm_exec =====================
[23:38:50] =========== drm_format_helper_test (17 subtests) ===========
[23:38:50] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[23:38:50] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[23:38:50] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[23:38:50] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[23:38:50] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[23:38:50] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[23:38:50] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[23:38:50] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[23:38:50] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[23:38:50] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[23:38:50] ============== drm_test_fb_xrgb8888_to_mono ===============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[23:38:50] ==================== drm_test_fb_swab =====================
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ================ [PASSED] drm_test_fb_swab =================
[23:38:50] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[23:38:50] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[23:38:50] [PASSED] single_pixel_source_buffer
[23:38:50] [PASSED] single_pixel_clip_rectangle
[23:38:50] [PASSED] well_known_colors
[23:38:50] [PASSED] destination_pitch
[23:38:50] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[23:38:50] ================= drm_test_fb_clip_offset =================
[23:38:50] [PASSED] pass through
[23:38:50] [PASSED] horizontal offset
[23:38:50] [PASSED] vertical offset
[23:38:50] [PASSED] horizontal and vertical offset
[23:38:50] [PASSED] horizontal offset (custom pitch)
[23:38:50] [PASSED] vertical offset (custom pitch)
[23:38:50] [PASSED] horizontal and vertical offset (custom pitch)
[23:38:50] ============= [PASSED] drm_test_fb_clip_offset =============
[23:38:50] ============== drm_test_fb_build_fourcc_list ==============
[23:38:50] [PASSED] no native formats
[23:38:50] [PASSED] XRGB8888 as native format
[23:38:50] [PASSED] remove duplicates
[23:38:50] [PASSED] convert alpha formats
[23:38:50] [PASSED] random formats
[23:38:50] ========== [PASSED] drm_test_fb_build_fourcc_list ==========
[23:38:50] =================== drm_test_fb_memcpy ====================
[23:38:50] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[23:38:50] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[23:38:50] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[23:38:50] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[23:38:50] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[23:38:50] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[23:38:50] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[23:38:50] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[23:38:50] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[23:38:50] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[23:38:50] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[23:38:50] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[23:38:50] =============== [PASSED] drm_test_fb_memcpy ================
[23:38:50] ============= [PASSED] drm_format_helper_test ==============
[23:38:50] ================= drm_format (18 subtests) =================
[23:38:50] [PASSED] drm_test_format_block_width_invalid
[23:38:50] [PASSED] drm_test_format_block_width_one_plane
[23:38:50] [PASSED] drm_test_format_block_width_two_plane
[23:38:50] [PASSED] drm_test_format_block_width_three_plane
[23:38:50] [PASSED] drm_test_format_block_width_tiled
[23:38:50] [PASSED] drm_test_format_block_height_invalid
[23:38:50] [PASSED] drm_test_format_block_height_one_plane
[23:38:50] [PASSED] drm_test_format_block_height_two_plane
[23:38:50] [PASSED] drm_test_format_block_height_three_plane
[23:38:50] [PASSED] drm_test_format_block_height_tiled
[23:38:50] [PASSED] drm_test_format_min_pitch_invalid
[23:38:50] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[23:38:50] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[23:38:50] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[23:38:50] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[23:38:50] [PASSED] drm_test_format_min_pitch_two_plane
[23:38:50] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[23:38:50] [PASSED] drm_test_format_min_pitch_tiled
[23:38:50] =================== [PASSED] drm_format ====================
[23:38:50] =============== drm_framebuffer (1 subtest) ================
[23:38:50] =============== drm_test_framebuffer_create ===============
[23:38:50] [PASSED] ABGR8888 normal sizes
[23:38:50] [PASSED] ABGR8888 max sizes
[23:38:50] [PASSED] ABGR8888 pitch greater than min required
[23:38:50] [PASSED] ABGR8888 pitch less than min required
[23:38:50] [PASSED] ABGR8888 Invalid width
[23:38:50] [PASSED] ABGR8888 Invalid buffer handle
[23:38:50] [PASSED] No pixel format
[23:38:50] [PASSED] ABGR8888 Width 0
[23:38:50] [PASSED] ABGR8888 Height 0
[23:38:50] [PASSED] ABGR8888 Out of bound height * pitch combination
[23:38:50] [PASSED] ABGR8888 Large buffer offset
[23:38:50] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[23:38:50] [PASSED] ABGR8888 Valid buffer modifier
[23:38:50] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[23:38:50] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] NV12 Normal sizes
[23:38:50] [PASSED] NV12 Max sizes
[23:38:50] [PASSED] NV12 Invalid pitch
[23:38:50] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[23:38:50] [PASSED] NV12 different modifier per-plane
[23:38:50] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[23:38:50] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] NV12 Modifier for inexistent plane
[23:38:50] [PASSED] NV12 Handle for inexistent plane
[23:38:50] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[23:38:50] [PASSED] YVU420 Normal sizes
[23:38:50] [PASSED] YVU420 Max sizes
[23:38:50] [PASSED] YVU420 Invalid pitch
[23:38:50] [PASSED] YVU420 Different pitches
[23:38:50] [PASSED] YVU420 Different buffer offsets/pitches
[23:38:50] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[23:38:50] [PASSED] YVU420 Valid modifier
[23:38:50] [PASSED] YVU420 Different modifiers per plane
[23:38:50] [PASSED] YVU420 Modifier for inexistent plane
[23:38:50] [PASSED] X0L2 Normal sizes
[23:38:50] [PASSED] X0L2 Max sizes
[23:38:50] [PASSED] X0L2 Invalid pitch
[23:38:50] [PASSED] X0L2 Pitch greater than minimum required
[23:38:50] [PASSED] X0L2 Handle for inexistent plane
[23:38:50] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[23:38:50] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[23:38:50] [PASSED] X0L2 Valid modifier
[23:38:50] [PASSED] X0L2 Modifier for inexistent plane
[23:38:50] =========== [PASSED] drm_test_framebuffer_create ===========
[23:38:50] ================= [PASSED] drm_framebuffer =================
[23:38:50] ================ drm_gem_shmem (8 subtests) ================
[23:38:50] [PASSED] drm_gem_shmem_test_obj_create
[23:38:50] [PASSED] drm_gem_shmem_test_obj_create_private
[23:38:50] [PASSED] drm_gem_shmem_test_pin_pages
[23:38:50] [PASSED] drm_gem_shmem_test_vmap
[23:38:50] [PASSED] drm_gem_shmem_test_get_pages_sgt
[23:38:50] [PASSED] drm_gem_shmem_test_get_sg_table
[23:38:50] [PASSED] drm_gem_shmem_test_madvise
[23:38:50] [PASSED] drm_gem_shmem_test_purge
[23:38:50] ================== [PASSED] drm_gem_shmem ==================
[23:38:50] ================= drm_managed (2 subtests) =================
[23:38:50] [PASSED] drm_test_managed_release_action
[23:38:50] [PASSED] drm_test_managed_run_action
[23:38:50] =================== [PASSED] drm_managed ===================
[23:38:50] =================== drm_mm (6 subtests) ====================
[23:38:50] [PASSED] drm_test_mm_init
[23:38:50] [PASSED] drm_test_mm_debug
[23:38:50] [PASSED] drm_test_mm_align32
[23:38:50] [PASSED] drm_test_mm_align64
[23:38:50] [PASSED] drm_test_mm_lowest
[23:38:50] [PASSED] drm_test_mm_highest
[23:38:50] ===================== [PASSED] drm_mm ======================
[23:38:50] ============= drm_modes_analog_tv (4 subtests) =============
[23:38:50] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[23:38:50] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[23:38:50] [PASSED] drm_test_modes_analog_tv_pal_576i
[23:38:50] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[23:38:50] =============== [PASSED] drm_modes_analog_tv ===============
[23:38:50] ============== drm_plane_helper (2 subtests) ===============
[23:38:50] =============== drm_test_check_plane_state ================
[23:38:50] [PASSED] clipping_simple
[23:38:50] [PASSED] clipping_rotate_reflect
[23:38:50] [PASSED] positioning_simple
[23:38:50] [PASSED] upscaling
[23:38:50] [PASSED] downscaling
[23:38:50] [PASSED] rounding1
[23:38:50] [PASSED] rounding2
[23:38:50] [PASSED] rounding3
[23:38:50] [PASSED] rounding4
[23:38:50] =========== [PASSED] drm_test_check_plane_state ============
[23:38:50] =========== drm_test_check_invalid_plane_state ============
[23:38:50] [PASSED] positioning_invalid
[23:38:50] [PASSED] upscaling_invalid
[23:38:50] [PASSED] downscaling_invalid
[23:38:50] ======= [PASSED] drm_test_check_invalid_plane_state ========
[23:38:50] ================ [PASSED] drm_plane_helper =================
[23:38:50] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[23:38:50] ====== drm_test_connector_helper_tv_get_modes_check =======
[23:38:50] [PASSED] None
[23:38:50] [PASSED] PAL
[23:38:50] [PASSED] NTSC
[23:38:50] [PASSED] Both, NTSC Default
[23:38:50] [PASSED] Both, PAL Default
[23:38:50] [PASSED] Both, NTSC Default, with PAL on command-line
[23:38:50] [PASSED] Both, PAL Default, with NTSC on command-line
[23:38:50] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[23:38:50] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[23:38:50] ================== drm_rect (9 subtests) ===================
[23:38:50] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[23:38:50] [PASSED] drm_test_rect_clip_scaled_not_clipped
[23:38:50] [PASSED] drm_test_rect_clip_scaled_clipped
stty: 'standard input': Inappropriate ioctl for device
[23:38:50] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[23:38:50] ================= drm_test_rect_intersect =================
[23:38:50] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[23:38:50] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[23:38:50] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[23:38:50] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[23:38:50] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[23:38:50] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[23:38:50] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[23:38:50] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[23:38:50] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[23:38:50] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[23:38:50] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[23:38:50] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[23:38:50] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[23:38:50] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[23:38:50] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[23:38:50] ============= [PASSED] drm_test_rect_intersect =============
[23:38:50] ================ drm_test_rect_calc_hscale ================
[23:38:50] [PASSED] normal use
[23:38:50] [PASSED] out of max range
[23:38:50] [PASSED] out of min range
[23:38:50] [PASSED] zero dst
[23:38:50] [PASSED] negative src
[23:38:50] [PASSED] negative dst
[23:38:50] ============ [PASSED] drm_test_rect_calc_hscale ============
[23:38:50] ================ drm_test_rect_calc_vscale ================
[23:38:50] [PASSED] normal use
[23:38:50] [PASSED] out of max range
[23:38:50] [PASSED] out of min range
[23:38:50] [PASSED] zero dst
[23:38:50] [PASSED] negative src
[23:38:50] [PASSED] negative dst
[23:38:50] ============ [PASSED] drm_test_rect_calc_vscale ============
[23:38:50] ================== drm_test_rect_rotate ===================
[23:38:50] [PASSED] reflect-x
[23:38:50] [PASSED] reflect-y
[23:38:50] [PASSED] rotate-0
[23:38:50] [PASSED] rotate-90
[23:38:50] [PASSED] rotate-180
[23:38:50] [PASSED] rotate-270
[23:38:50] ============== [PASSED] drm_test_rect_rotate ===============
[23:38:50] ================ drm_test_rect_rotate_inv =================
[23:38:50] [PASSED] reflect-x
[23:38:50] [PASSED] reflect-y
[23:38:50] [PASSED] rotate-0
[23:38:50] [PASSED] rotate-90
[23:38:50] [PASSED] rotate-180
[23:38:50] [PASSED] rotate-270
[23:38:50] ============ [PASSED] drm_test_rect_rotate_inv =============
[23:38:50] ==================== [PASSED] drm_rect =====================
[23:38:50] ============================================================
[23:38:50] Testing complete. Ran 417 tests: passed: 417
[23:38:51] Elapsed time: 22.982s total, 1.660s configuring, 21.152s building, 0.149s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-26 23:32 [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier Matthew Brost
` (2 preceding siblings ...)
2024-04-26 23:38 ` ✓ CI.KUnit: " Patchwork
@ 2024-04-29 1:11 ` Matthew Brost
2024-04-29 13:05 ` Thomas Hellström
2024-04-29 13:55 ` Zeng, Oak
4 siblings, 1 reply; 11+ messages in thread
From: Matthew Brost @ 2024-04-29 1:11 UTC (permalink / raw)
To: intel-xe; +Cc: Thomas Hellström, stable
On Fri, Apr 26, 2024 at 04:32:36PM -0700, Matthew Brost wrote:
> To be secure, when a userptr is invalidated the pages should be dma
> unmapped ensuring the device can no longer touch the invalidated pages.
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user pages")
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: stable@vger.kernel.org # 6.8
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index dfd31b346021..964a5b4d47d8 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct mmu_interval_notifier *mni,
> XE_WARN_ON(err);
> }
>
> + if (userptr->sg)
> + xe_hmm_userptr_free_sg(uvma);
> +
I thought about this a bit, I think here we only dma unmap the SG, not
free it. Freeing it could cause a current bind walk to access corrupt
memory. Freeing can be deferred to the next attempt to bind the userptr
or userptr destroy.
Matt
> trace_xe_vma_userptr_invalidate_complete(vma);
>
> return true;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-29 1:11 ` [PATCH] " Matthew Brost
@ 2024-04-29 13:05 ` Thomas Hellström
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Hellström @ 2024-04-29 13:05 UTC (permalink / raw)
To: Matthew Brost, intel-xe; +Cc: stable
On Mon, 2024-04-29 at 01:11 +0000, Matthew Brost wrote:
> On Fri, Apr 26, 2024 at 04:32:36PM -0700, Matthew Brost wrote:
> > To be secure, when a userptr is invalidated the pages should be dma
> > unmapped ensuring the device can no longer touch the invalidated
> > pages.
> >
> > Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel
> > GPUs")
> > Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user
> > pages")
> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Cc: stable@vger.kernel.org # 6.8
> > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > ---
> > drivers/gpu/drm/xe/xe_vm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c
> > b/drivers/gpu/drm/xe/xe_vm.c
> > index dfd31b346021..964a5b4d47d8 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct
> > mmu_interval_notifier *mni,
> > XE_WARN_ON(err);
> > }
> >
> > + if (userptr->sg)
> > + xe_hmm_userptr_free_sg(uvma);
> > +
>
> I thought about this a bit, I think here we only dma unmap the SG,
> not
> free it. Freeing it could cause a current bind walk to access corrupt
> memory. Freeing can be deferred to the next attempt to bind the
> userptr
> or userptr destroy.
Yes, makes sense.
/Thomas
>
> Matt
>
> > trace_xe_vma_userptr_invalidate_complete(vma);
> >
> > return true;
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-26 23:32 [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier Matthew Brost
` (3 preceding siblings ...)
2024-04-29 1:11 ` [PATCH] " Matthew Brost
@ 2024-04-29 13:55 ` Zeng, Oak
2024-04-29 17:18 ` Matthew Brost
4 siblings, 1 reply; 11+ messages in thread
From: Zeng, Oak @ 2024-04-29 13:55 UTC (permalink / raw)
To: Brost, Matthew, intel-xe; +Cc: Brost, Matthew, Thomas Hellström, stable
Hi Matt
> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> Matthew Brost
> Sent: Friday, April 26, 2024 7:33 PM
> To: intel-xe@lists.freedesktop.org
> Cc: Brost, Matthew <matthew.brost@intel.com>; Thomas Hellström
> <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> Subject: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
>
> To be secure, when a userptr is invalidated the pages should be dma
> unmapped ensuring the device can no longer touch the invalidated pages.
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user
> pages")
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: stable@vger.kernel.org # 6.8
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index dfd31b346021..964a5b4d47d8 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct
> mmu_interval_notifier *mni,
> XE_WARN_ON(err);
> }
>
> + if (userptr->sg)
> + xe_hmm_userptr_free_sg(uvma);
Just some thoughts here. I think when we introduce system allocator, above should be made conditional. We should dma unmap userptr only for normal userptr but not for userptr created for system allocator (fault usrptr in the system allocator series). Because for system allocator the dma-unmapping would be part of the garbage collector and vma destroy process. Right?
Oak
> +
> trace_xe_vma_userptr_invalidate_complete(vma);
>
> return true;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-29 13:55 ` Zeng, Oak
@ 2024-04-29 17:18 ` Matthew Brost
2024-04-30 15:11 ` Zeng, Oak
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Brost @ 2024-04-29 17:18 UTC (permalink / raw)
To: Zeng, Oak; +Cc: intel-xe, Thomas Hellström, stable
On Mon, Apr 29, 2024 at 07:55:22AM -0600, Zeng, Oak wrote:
> Hi Matt
>
> > -----Original Message-----
> > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> > Matthew Brost
> > Sent: Friday, April 26, 2024 7:33 PM
> > To: intel-xe@lists.freedesktop.org
> > Cc: Brost, Matthew <matthew.brost@intel.com>; Thomas Hellström
> > <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> > Subject: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
> >
> > To be secure, when a userptr is invalidated the pages should be dma
> > unmapped ensuring the device can no longer touch the invalidated pages.
> >
> > Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> > Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user
> > pages")
> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Cc: stable@vger.kernel.org # 6.8
> > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > ---
> > drivers/gpu/drm/xe/xe_vm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index dfd31b346021..964a5b4d47d8 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct
> > mmu_interval_notifier *mni,
> > XE_WARN_ON(err);
> > }
> >
> > + if (userptr->sg)
> > + xe_hmm_userptr_free_sg(uvma);
>
> Just some thoughts here. I think when we introduce system allocator, above should be made conditional. We should dma unmap userptr only for normal userptr but not for userptr created for system allocator (fault usrptr in the system allocator series). Because for system allocator the dma-unmapping would be part of the garbage collector and vma destroy process. Right?
>
I don't think it should be conditional. In any case when a CPU address
is invalidated we need to ensure the dma mapping (IOMMU mapping) is
also invalid to ensure no path to the old (invalidate) pages exists.
This is an extra security that must be enforced. With removing the dma
mapping, in theory rouge accesses from the GPU could still access the
old pages.
Matt
> Oak
>
> > +
> > trace_xe_vma_userptr_invalidate_complete(vma);
> >
> > return true;
> > --
> > 2.34.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-29 17:18 ` Matthew Brost
@ 2024-04-30 15:11 ` Zeng, Oak
2024-04-30 15:42 ` Matthew Brost
0 siblings, 1 reply; 11+ messages in thread
From: Zeng, Oak @ 2024-04-30 15:11 UTC (permalink / raw)
To: Brost, Matthew; +Cc: intel-xe, Thomas Hellström, stable
> -----Original Message-----
> From: Brost, Matthew <matthew.brost@intel.com>
> Sent: Monday, April 29, 2024 1:18 PM
> To: Zeng, Oak <oak.zeng@intel.com>
> Cc: intel-xe@lists.freedesktop.org; Thomas Hellström
> <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> Subject: Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
>
> On Mon, Apr 29, 2024 at 07:55:22AM -0600, Zeng, Oak wrote:
> > Hi Matt
> >
> > > -----Original Message-----
> > > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> > > Matthew Brost
> > > Sent: Friday, April 26, 2024 7:33 PM
> > > To: intel-xe@lists.freedesktop.org
> > > Cc: Brost, Matthew <matthew.brost@intel.com>; Thomas Hellström
> > > <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> > > Subject: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
> > >
> > > To be secure, when a userptr is invalidated the pages should be dma
> > > unmapped ensuring the device can no longer touch the invalidated pages.
> > >
> > > Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel
> GPUs")
> > > Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user
> > > pages")
> > > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > > Cc: stable@vger.kernel.org # 6.8
> > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > ---
> > > drivers/gpu/drm/xe/xe_vm.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > > index dfd31b346021..964a5b4d47d8 100644
> > > --- a/drivers/gpu/drm/xe/xe_vm.c
> > > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > > @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct
> > > mmu_interval_notifier *mni,
> > > XE_WARN_ON(err);
> > > }
> > >
> > > + if (userptr->sg)
> > > + xe_hmm_userptr_free_sg(uvma);
> >
> > Just some thoughts here. I think when we introduce system allocator,
> above should be made conditional. We should dma unmap userptr only for
> normal userptr but not for userptr created for system allocator (fault usrptr
> in the system allocator series). Because for system allocator the dma-
> unmapping would be part of the garbage collector and vma destroy process.
> Right?
> >
>
> I don't think it should be conditional. In any case when a CPU address
> is invalidated we need to ensure the dma mapping (IOMMU mapping) is
> also invalid to ensure no path to the old (invalidate) pages exists.
I understand for both normal userptr and fault userptr we need to dma unmap.
I was saying, for fault userptr, the dma unmap would be done in the garbage collector codes (we destroy fault userptr vma there and dma unmap along with vam destroy), so we don't need dma unmap in your above codes. It would something like this:
If (userptr && not fault userptr)
Dma-unmap sg
If (fault userptr)
Trigger garbage collector - this will deal with dma-unmap
Oak
> This is an extra security that must be enforced. With removing the dma
> mapping, in theory rouge accesses from the GPU could still access the
> old pages.
>
> Matt
>
> > Oak
> >
> > > +
> > > trace_xe_vma_userptr_invalidate_complete(vma);
> > >
> > > return true;
> > > --
> > > 2.34.1
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-30 15:11 ` Zeng, Oak
@ 2024-04-30 15:42 ` Matthew Brost
2024-05-01 0:40 ` Zeng, Oak
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Brost @ 2024-04-30 15:42 UTC (permalink / raw)
To: Zeng, Oak; +Cc: intel-xe, Thomas Hellström, stable
On Tue, Apr 30, 2024 at 09:11:42AM -0600, Zeng, Oak wrote:
>
>
> > -----Original Message-----
> > From: Brost, Matthew <matthew.brost@intel.com>
> > Sent: Monday, April 29, 2024 1:18 PM
> > To: Zeng, Oak <oak.zeng@intel.com>
> > Cc: intel-xe@lists.freedesktop.org; Thomas Hellström
> > <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> > Subject: Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
> >
> > On Mon, Apr 29, 2024 at 07:55:22AM -0600, Zeng, Oak wrote:
> > > Hi Matt
> > >
> > > > -----Original Message-----
> > > > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> > > > Matthew Brost
> > > > Sent: Friday, April 26, 2024 7:33 PM
> > > > To: intel-xe@lists.freedesktop.org
> > > > Cc: Brost, Matthew <matthew.brost@intel.com>; Thomas Hellström
> > > > <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> > > > Subject: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
> > > >
> > > > To be secure, when a userptr is invalidated the pages should be dma
> > > > unmapped ensuring the device can no longer touch the invalidated pages.
> > > >
> > > > Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel
> > GPUs")
> > > > Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate user
> > > > pages")
> > > > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > > > Cc: stable@vger.kernel.org # 6.8
> > > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > > ---
> > > > drivers/gpu/drm/xe/xe_vm.c | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > > > index dfd31b346021..964a5b4d47d8 100644
> > > > --- a/drivers/gpu/drm/xe/xe_vm.c
> > > > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > > > @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct
> > > > mmu_interval_notifier *mni,
> > > > XE_WARN_ON(err);
> > > > }
> > > >
> > > > + if (userptr->sg)
> > > > + xe_hmm_userptr_free_sg(uvma);
> > >
> > > Just some thoughts here. I think when we introduce system allocator,
> > above should be made conditional. We should dma unmap userptr only for
> > normal userptr but not for userptr created for system allocator (fault usrptr
> > in the system allocator series). Because for system allocator the dma-
> > unmapping would be part of the garbage collector and vma destroy process.
> > Right?
> > >
> >
> > I don't think it should be conditional. In any case when a CPU address
> > is invalidated we need to ensure the dma mapping (IOMMU mapping) is
> > also invalid to ensure no path to the old (invalidate) pages exists.
>
> I understand for both normal userptr and fault userptr we need to dma unmap.
>
> I was saying, for fault userptr, the dma unmap would be done in the garbage collector codes (we destroy fault userptr vma there and dma unmap along with vam destroy), so we don't need dma unmap in your above codes. It would something like this:
>
I understand what you are suggesting, but no this is always needed.
> If (userptr && not fault userptr)
> Dma-unmap sg
>
With what you suggest, there is a window between the MMU notifier
completing and garbage collector running in which the dma-mapping is
valid. This is not allowed per the security model. Thus we need always
invalidate dma-addresses in the notifier.
Matt
> If (fault userptr)
> Trigger garbage collector - this will deal with dma-unmap
>
>
> Oak
>
>
> > This is an extra security that must be enforced. With removing the dma
> > mapping, in theory rouge accesses from the GPU could still access the
> > old pages.
> >
> > Matt
> >
> > > Oak
> > >
> > > > +
> > > > trace_xe_vma_userptr_invalidate_complete(vma);
> > > >
> > > > return true;
> > > > --
> > > > 2.34.1
> > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
2024-04-30 15:42 ` Matthew Brost
@ 2024-05-01 0:40 ` Zeng, Oak
0 siblings, 0 replies; 11+ messages in thread
From: Zeng, Oak @ 2024-05-01 0:40 UTC (permalink / raw)
To: Brost, Matthew; +Cc: intel-xe, Thomas Hellström, stable
> -----Original Message-----
> From: Brost, Matthew <matthew.brost@intel.com>
> Sent: Tuesday, April 30, 2024 11:42 AM
> To: Zeng, Oak <oak.zeng@intel.com>
> Cc: intel-xe@lists.freedesktop.org; Thomas Hellström
> <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> Subject: Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier
>
> On Tue, Apr 30, 2024 at 09:11:42AM -0600, Zeng, Oak wrote:
> >
> >
> > > -----Original Message-----
> > > From: Brost, Matthew <matthew.brost@intel.com>
> > > Sent: Monday, April 29, 2024 1:18 PM
> > > To: Zeng, Oak <oak.zeng@intel.com>
> > > Cc: intel-xe@lists.freedesktop.org; Thomas Hellström
> > > <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> > > Subject: Re: [PATCH] drm/xe: Unmap userptr in MMU invalidation
> notifier
> > >
> > > On Mon, Apr 29, 2024 at 07:55:22AM -0600, Zeng, Oak wrote:
> > > > Hi Matt
> > > >
> > > > > -----Original Message-----
> > > > > From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf
> Of
> > > > > Matthew Brost
> > > > > Sent: Friday, April 26, 2024 7:33 PM
> > > > > To: intel-xe@lists.freedesktop.org
> > > > > Cc: Brost, Matthew <matthew.brost@intel.com>; Thomas Hellström
> > > > > <thomas.hellstrom@linux.intel.com>; stable@vger.kernel.org
> > > > > Subject: [PATCH] drm/xe: Unmap userptr in MMU invalidation
> notifier
> > > > >
> > > > > To be secure, when a userptr is invalidated the pages should be dma
> > > > > unmapped ensuring the device can no longer touch the invalidated
> pages.
> > > > >
> > > > > Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel
> > > GPUs")
> > > > > Fixes: 12f4b58a37f4 ("drm/xe: Use hmm_range_fault to populate
> user
> > > > > pages")
> > > > > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > > > > Cc: stable@vger.kernel.org # 6.8
> > > > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/xe/xe_vm.c | 3 +++
> > > > > 1 file changed, 3 insertions(+)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/xe/xe_vm.c
> b/drivers/gpu/drm/xe/xe_vm.c
> > > > > index dfd31b346021..964a5b4d47d8 100644
> > > > > --- a/drivers/gpu/drm/xe/xe_vm.c
> > > > > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > > > > @@ -637,6 +637,9 @@ static bool vma_userptr_invalidate(struct
> > > > > mmu_interval_notifier *mni,
> > > > > XE_WARN_ON(err);
> > > > > }
> > > > >
> > > > > + if (userptr->sg)
> > > > > + xe_hmm_userptr_free_sg(uvma);
> > > >
> > > > Just some thoughts here. I think when we introduce system allocator,
> > > above should be made conditional. We should dma unmap userptr only
> for
> > > normal userptr but not for userptr created for system allocator (fault
> usrptr
> > > in the system allocator series). Because for system allocator the dma-
> > > unmapping would be part of the garbage collector and vma destroy
> process.
> > > Right?
> > > >
> > >
> > > I don't think it should be conditional. In any case when a CPU address
> > > is invalidated we need to ensure the dma mapping (IOMMU mapping) is
> > > also invalid to ensure no path to the old (invalidate) pages exists.
> >
> > I understand for both normal userptr and fault userptr we need to dma
> unmap.
> >
> > I was saying, for fault userptr, the dma unmap would be done in the
> garbage collector codes (we destroy fault userptr vma there and dma unmap
> along with vam destroy), so we don't need dma unmap in your above codes.
> It would something like this:
> >
>
> I understand what you are suggesting, but no this is always needed.
>
> > If (userptr && not fault userptr)
> > Dma-unmap sg
> >
>
> With what you suggest, there is a window between the MMU notifier
> completing and garbage collector running in which the dma-mapping is
> valid. This is not allowed per the security model. Thus we need always
> invalidate dma-addresses in the notifier.
That make sense. Thanks for explain.
Oak
>
> Matt
>
> > If (fault userptr)
> > Trigger garbage collector - this will deal with dma-unmap
> >
> >
> > Oak
> >
> >
> > > This is an extra security that must be enforced. With removing the dma
> > > mapping, in theory rouge accesses from the GPU could still access the
> > > old pages.
> > >
> > > Matt
> > >
> > > > Oak
> > > >
> > > > > +
> > > > > trace_xe_vma_userptr_invalidate_complete(vma);
> > > > >
> > > > > return true;
> > > > > --
> > > > > 2.34.1
> > > >
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-05-01 0:41 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-26 23:32 [PATCH] drm/xe: Unmap userptr in MMU invalidation notifier Matthew Brost
2024-04-26 23:37 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-26 23:37 ` ✓ CI.checkpatch: " Patchwork
2024-04-26 23:38 ` ✓ CI.KUnit: " Patchwork
2024-04-29 1:11 ` [PATCH] " Matthew Brost
2024-04-29 13:05 ` Thomas Hellström
2024-04-29 13:55 ` Zeng, Oak
2024-04-29 17:18 ` Matthew Brost
2024-04-30 15:11 ` Zeng, Oak
2024-04-30 15:42 ` Matthew Brost
2024-05-01 0:40 ` Zeng, Oak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).