From: Andy Lutomirski <luto@amacapital.net>
To: Kristen Carlson Accardi <kristen@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, arjan@linux.intel.com, keescook@chromium.org,
rick.p.edgecombe@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [RFC PATCH 03/11] x86/boot: Allow a "silent" kaslr random byte fetch
Date: Wed, 5 Feb 2020 17:08:55 -0800 [thread overview]
Message-ID: <B173D69E-DC6C-4658-B5CB-391D3C6A6597@amacapital.net> (raw)
In-Reply-To: <20200205223950.1212394-4-kristen@linux.intel.com>
> On Feb 5, 2020, at 2:39 PM, Kristen Carlson Accardi <kristen@linux.intel.com> wrote:
>
> From: Kees Cook <keescook@chromium.org>
>
> Under earlyprintk, each RNG call produces a debug report line. When
> shuffling hundreds of functions, this is not useful information (each
> line is identical and tells us nothing new). Instead, allow for a NULL
> "purpose" to suppress the debug reporting.
Have you counted how many RDRAND calls this causes? RDRAND is exceedingly slow on all CPUs I’ve looked at. The whole “RDRAND has great bandwidth” marketing BS actually means that it has decent bandwidth if all CPUs hammer it at the same time. The latency is abysmal. I have asked Intel to improve this, but the latency of that request will be quadrillions of cycles :)
It wouldn’t shock me if just the RDRAND calls account for a respectable fraction of total time. The RDTSC fallback, on the other hand, may be so predictable as to be useless.
I would suggest adding a little ChaCha20 DRBG or similar to the KASLR environment instead. What crypto primitives are available there?
next prev parent reply other threads:[~2020-02-06 1:09 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 22:39 [RFC PATCH 00/11] Finer grained kernel address space randomization Kristen Carlson Accardi
2020-02-05 22:39 ` [RFC PATCH 01/11] modpost: Support >64K sections Kristen Carlson Accardi
2020-02-06 12:38 ` Kees Cook
2020-02-05 22:39 ` [RFC PATCH 02/11] x86: tools/relocs: Support >64K section headers Kristen Carlson Accardi
2020-02-06 12:39 ` Kees Cook
2020-02-05 22:39 ` [RFC PATCH 03/11] x86/boot: Allow a "silent" kaslr random byte fetch Kristen Carlson Accardi
2020-02-06 1:08 ` Andy Lutomirski [this message]
2020-02-06 11:48 ` Kees Cook
2020-02-06 16:58 ` Kristen Carlson Accardi
2020-02-05 22:39 ` [RFC PATCH 04/11] x86/boot/KASLR: Introduce PRNG for faster shuffling Kristen Carlson Accardi
2020-02-06 1:11 ` Andy Lutomirski
2020-02-06 15:10 ` Jason A. Donenfeld
2020-02-07 7:23 ` Jean-Philippe Aumasson
2020-02-07 9:05 ` Kees Cook
2020-02-07 16:52 ` Kristen Carlson Accardi
2020-02-05 22:39 ` [RFC PATCH 05/11] x86: Makefile: Add build and config option for CONFIG_FG_KASLR Kristen Carlson Accardi
2020-02-06 10:30 ` Peter Zijlstra
2020-02-06 11:52 ` Kees Cook
2020-02-25 17:55 ` Arvind Sankar
2020-02-26 19:13 ` Kristen Carlson Accardi
2020-03-24 21:24 ` Kristen Carlson Accardi
2020-03-25 15:34 ` Kees Cook
2020-02-05 22:39 ` [RFC PATCH 06/11] x86: make sure _etext includes function sections Kristen Carlson Accardi
2020-02-06 12:26 ` Kees Cook
2020-02-06 13:15 ` Jann Horn
2020-02-06 16:27 ` David Laight
2020-02-06 14:39 ` Arvind Sankar
2020-02-06 15:29 ` Arvind Sankar
2020-02-06 16:11 ` Andy Lutomirski
2020-02-06 14:57 ` Arvind Sankar
2020-02-06 15:45 ` Arvind Sankar
2020-02-06 19:41 ` Kristen Carlson Accardi
2020-02-06 20:02 ` Andy Lutomirski
2020-02-07 9:24 ` Peter Zijlstra
2020-02-10 1:43 ` Kees Cook
2020-02-10 10:51 ` Peter Zijlstra
2020-02-10 15:54 ` Arjan van de Ven
2020-02-10 16:36 ` Arvind Sankar
2020-02-21 19:50 ` Josh Poimboeuf
2020-02-21 23:05 ` Arvind Sankar
2020-02-05 22:39 ` [RFC PATCH 07/11] x86/tools: Adding relative relocs for randomized functions Kristen Carlson Accardi
2020-02-06 12:37 ` Kees Cook
2020-02-05 22:39 ` [RFC PATCH 08/11] x86: Add support for finer grained KASLR Kristen Carlson Accardi
2020-02-06 1:17 ` Andy Lutomirski
2020-02-06 11:56 ` Kees Cook
2020-02-06 17:36 ` Kristen Carlson Accardi
2020-02-06 10:38 ` Peter Zijlstra
2020-02-06 12:06 ` Kees Cook
2020-02-06 14:52 ` Peter Zijlstra
2020-02-06 17:25 ` Kristen Carlson Accardi
2020-02-06 17:35 ` Peter Zijlstra
2020-02-06 17:43 ` Kristen Carlson Accardi
2020-02-25 17:49 ` Arvind Sankar
2020-02-26 19:26 ` Kristen Carlson Accardi
2020-02-05 22:39 ` [RFC PATCH 09/11] kallsyms: hide layout and expose seed Kristen Carlson Accardi
2020-02-06 12:32 ` Kees Cook
2020-02-06 17:51 ` Kristen Carlson Accardi
2020-02-06 19:27 ` Jann Horn
2020-03-02 19:01 ` Kristen Carlson Accardi
2020-03-02 19:08 ` Kees Cook
2020-03-02 19:19 ` Kristen Carlson Accardi
2020-02-27 2:42 ` Baoquan He
2020-02-27 16:02 ` Kees Cook
2020-02-28 3:36 ` Baoquan He
2020-02-05 22:39 ` [RFC PATCH 10/11] module: Reorder functions Kristen Carlson Accardi
2020-02-06 12:41 ` Kees Cook
2020-02-11 12:39 ` Jessica Yu
2020-02-05 22:39 ` [RFC PATCH 11/11] x86/boot: Move "boot heap" out of .bss Kristen Carlson Accardi
2020-02-06 0:11 ` Arvind Sankar
2020-02-06 0:33 ` Kristen Carlson Accardi
2020-02-06 11:13 ` Kees Cook
2020-02-06 14:25 ` Arvind Sankar
2020-02-06 21:32 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B173D69E-DC6C-4658-B5CB-391D3C6A6597@amacapital.net \
--to=luto@amacapital.net \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).