* [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()
@ 2015-07-09 8:21 Dan Carpenter
2015-07-09 14:59 ` Nicolin Chen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-07-09 8:21 UTC (permalink / raw)
To: Timur Tabi, Fabio Estevam
Cc: Nicolin Chen, Xiubo Li, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors
We need "i" to be signed or it leads to a forever loop in the error
handling.
Fixes: fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 3ee4539..7a92f30 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
struct platform_device *pdev = spdif_priv->pdev;
struct regmap *regmap = spdif_priv->regmap;
- u32 scr, mask, i;
+ u32 scr, mask;
+ int i;
int ret;
/* Reset module and interrupts only for first initialization */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()
2015-07-09 8:21 [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup() Dan Carpenter
@ 2015-07-09 14:59 ` Nicolin Chen
0 siblings, 0 replies; 2+ messages in thread
From: Nicolin Chen @ 2015-07-09 14:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Timur Tabi, Fabio Estevam, Xiubo Li, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors
On Thu, Jul 09, 2015 at 11:21:03AM +0300, Dan Carpenter wrote:
> We need "i" to be signed or it leads to a forever loop in the error
> handling.
>
> Fixes: fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 3ee4539..7a92f30 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
> struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
> struct platform_device *pdev = spdif_priv->pdev;
> struct regmap *regmap = spdif_priv->regmap;
> - u32 scr, mask, i;
> + u32 scr, mask;
> + int i;
> int ret;
>
> /* Reset module and interrupts only for first initialization */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-09 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-09 8:21 [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup() Dan Carpenter
2015-07-09 14:59 ` Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).