* [PATCH] scsi: elx: efct: fix uninitialized variable in debug output
@ 2021-06-18 13:42 Dan Carpenter
2021-06-18 22:58 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-06-18 13:42 UTC (permalink / raw)
To: James Smart
Cc: Ram Vegesna, James E.J. Bottomley, Martin K. Petersen,
Hannes Reinecke, Daniel Wagner, linux-scsi, target-devel,
kernel-janitors
Move the debug output down a couple lines so that "id" is initialized.
Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/elx/efct/efct_lio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/elx/efct/efct_lio.c b/drivers/scsi/elx/efct/efct_lio.c
index e1bab2b17e4d..b7d69ff29c09 100644
--- a/drivers/scsi/elx/efct/efct_lio.c
+++ b/drivers/scsi/elx/efct/efct_lio.c
@@ -1212,12 +1212,12 @@ static void efct_lio_setup_session(struct work_struct *work)
return;
}
- efc_log_debug(efct, "new initiator sess=%p node=%p id: %llx\n",
- se_sess, node, id);
-
tgt_node = node->tgt_node;
id = (u64) tgt_node->port_fc_id << 32 | tgt_node->node_fc_id;
+ efc_log_debug(efct, "new initiator sess=%p node=%p id: %llx\n",
+ se_sess, node, id);
+
if (xa_err(xa_store(&efct->lookup, id, tgt_node, GFP_KERNEL)))
efc_log_err(efct, "Node lookup store failed\n");
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: elx: efct: fix uninitialized variable in debug output
2021-06-18 13:42 [PATCH] scsi: elx: efct: fix uninitialized variable in debug output Dan Carpenter
@ 2021-06-18 22:58 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2021-06-18 22:58 UTC (permalink / raw)
To: Dan Carpenter, James Smart
Cc: Ram Vegesna, James E.J. Bottomley, Martin K. Petersen,
Hannes Reinecke, Daniel Wagner, linux-scsi, target-devel,
kernel-janitors
On 6/18/2021 6:42 AM, Dan Carpenter wrote:
> Move the debug output down a couple lines so that "id" is initialized.
>
> Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/elx/efct/efct_lio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Yep!
Same patch sent by Nathan Chancellor:
https://lore.kernel.org/linux-scsi/20210617061721.2405511-1-nathan@kernel.org/
-- james
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 13:42 [PATCH] scsi: elx: efct: fix uninitialized variable in debug output Dan Carpenter
2021-06-18 22:58 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).