kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"
@ 2024-05-01 11:20 Colin Ian King
  2024-05-07 20:19 ` Andrii Nakryiko
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-05-01 11:20 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, John Fastabend, KP Singh,
	Stanislav Fomichev, Hao Luo, Jiri Olsa, Mykola Lysenko,
	Shuah Khan, bpf, linux-kselftest
  Cc: kernel-janitors, linux-kernel

There are two spelling mistakes in .descr literal strings. Fix them.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt.c b/tools/testing/selftests/bpf/prog_tests/sockopt.c
index eaac83a7f388..ecf5a7a047a4 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt.c
@@ -933,7 +933,7 @@ static struct sockopt_test {
 	/* ==================== prog_type ====================  */
 
 	{
-		.descr = "can attach only BPF_CGROUP_SETSOCKOP",
+		.descr = "can attach only BPF_CGROUP_SETSOCKOPT",
 		.insns = {
 			/* return 1 */
 			BPF_MOV64_IMM(BPF_REG_0, 1),
@@ -947,7 +947,7 @@ static struct sockopt_test {
 	},
 
 	{
-		.descr = "can attach only BPF_CGROUP_GETSOCKOP",
+		.descr = "can attach only BPF_CGROUP_GETSOCKOPT",
 		.insns = {
 			/* return 1 */
 			BPF_MOV64_IMM(BPF_REG_0, 1),
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"
  2024-05-01 11:20 [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT" Colin Ian King
@ 2024-05-07 20:19 ` Andrii Nakryiko
  0 siblings, 0 replies; 2+ messages in thread
From: Andrii Nakryiko @ 2024-05-07 20:19 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, John Fastabend, KP Singh,
	Stanislav Fomichev, Hao Luo, Jiri Olsa, Mykola Lysenko,
	Shuah Khan, bpf, linux-kselftest, kernel-janitors, linux-kernel

On Wed, May 1, 2024 at 4:21 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There are two spelling mistakes in .descr literal strings. Fix them.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

This doesn't apply cleanly onto bpf-next/master, unfortunately. Can
you please rebase and resend?

pw-bot: cr


> diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt.c b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> index eaac83a7f388..ecf5a7a047a4 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockopt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> @@ -933,7 +933,7 @@ static struct sockopt_test {
>         /* ==================== prog_type ====================  */
>
>         {
> -               .descr = "can attach only BPF_CGROUP_SETSOCKOP",
> +               .descr = "can attach only BPF_CGROUP_SETSOCKOPT",
>                 .insns = {
>                         /* return 1 */
>                         BPF_MOV64_IMM(BPF_REG_0, 1),
> @@ -947,7 +947,7 @@ static struct sockopt_test {
>         },
>
>         {
> -               .descr = "can attach only BPF_CGROUP_GETSOCKOP",
> +               .descr = "can attach only BPF_CGROUP_GETSOCKOPT",
>                 .insns = {
>                         /* return 1 */
>                         BPF_MOV64_IMM(BPF_REG_0, 1),
> --
> 2.39.2
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-07 20:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-01 11:20 [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT" Colin Ian King
2024-05-07 20:19 ` Andrii Nakryiko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).