* Re: [PATCH] aoe: fix the potential use-after-free problem in more places
[not found] <20240514054214.924-1-jlee@suse.com>
@ 2024-05-14 7:42 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-05-14 7:42 UTC (permalink / raw)
To: Chun-Yi Lee, linux-block, kernel-janitors
Cc: LKML, Chun-Yi Lee, David S . Miller, Jens Axboe, Justin Sanders,
Kirill Korotaev, Nicolai Stange, Pavel Emelianov
Please add a version identification to your patch subject.
…
> This patch adds …
Please use imperative wordings for improved change descriptions also in your patches.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94
> v2:
> - Base on submitting-patches.rst document to improve patch description.
…
* Was any information overlooked here?
* Such version descriptions should be put behind a marker line.
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aoe: fix the potential use-after-free problem in more places
2024-04-30 16:16 ` Markus Elfring
@ 2024-05-13 11:56 ` joeyli
0 siblings, 0 replies; 3+ messages in thread
From: joeyli @ 2024-05-13 11:56 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-block, kernel-janitors, Justin Sanders, LKML, Chun-Yi Lee,
David S. Miller, Jens Axboe, Kirill Korotaev, Nicolai Stange,
Pavel Emelianov
Hi Markus,
Thanks for your review! I will send v2 patch.
Joey Lee
On Tue, Apr 30, 2024 at 06:16:00PM +0200, Markus Elfring wrote:
> > For fixing CVE-2023-6270, f98364e92662 patch moved dev_put() from
> …
>
> Please add a subject for the mentioned commit hash.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n99
>
>
> > This patch adds dev_hold() to those functions and also uses dev_put()
> > when the skb_clone() returns NULL.
>
> Please improve this change description with a corresponding imperative wording.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n94
>
>
> …
> > Fixes: f98364e92662 ("aoe: fix the potential use-after-free problem in
> > aoecmd_cfg_pkts")
>
> I suggest to omit a line break for this tag.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n145
>
>
> …
> > +++ b/drivers/block/aoe/aoecmd.c
> …
> > @@ -401,7 +402,8 @@ aoecmd_ata_rw(struct aoedev *d)
> > __skb_queue_head_init(&queue);
> > __skb_queue_tail(&queue, skb);
> > aoenet_xmit(&queue);
> > - }
> > + } else
> > + dev_put(f->t->ifp->nd);
> > return 1;
> > }
> >
> …
> > @@ -617,7 +622,8 @@ probe(struct aoetgt *t)
> > __skb_queue_head_init(&queue);
> > __skb_queue_tail(&queue, skb);
> > aoenet_xmit(&queue);
> > - }
> > + } else
> > + dev_put(f->t->ifp->nd);
> > }
> >
> > static long
> …
>
> Should curly brackets be used for both if branches in these function implementations?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.9-rc6#n213
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aoe: fix the potential use-after-free problem in more places
[not found] <20240410134858.6313-1-jlee@suse.com>
@ 2024-04-30 16:16 ` Markus Elfring
2024-05-13 11:56 ` joeyli
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2024-04-30 16:16 UTC (permalink / raw)
To: Chun-Yi Lee, linux-block, kernel-janitors, Justin Sanders
Cc: LKML, Chun-Yi Lee, David S. Miller, Jens Axboe, Kirill Korotaev,
Nicolai Stange, Pavel Emelianov
> For fixing CVE-2023-6270, f98364e92662 patch moved dev_put() from
…
Please add a subject for the mentioned commit hash.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n99
> This patch adds dev_hold() to those functions and also uses dev_put()
> when the skb_clone() returns NULL.
Please improve this change description with a corresponding imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n94
…
> Fixes: f98364e92662 ("aoe: fix the potential use-after-free problem in
> aoecmd_cfg_pkts")
I suggest to omit a line break for this tag.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n145
…
> +++ b/drivers/block/aoe/aoecmd.c
…
> @@ -401,7 +402,8 @@ aoecmd_ata_rw(struct aoedev *d)
> __skb_queue_head_init(&queue);
> __skb_queue_tail(&queue, skb);
> aoenet_xmit(&queue);
> - }
> + } else
> + dev_put(f->t->ifp->nd);
> return 1;
> }
>
…
> @@ -617,7 +622,8 @@ probe(struct aoetgt *t)
> __skb_queue_head_init(&queue);
> __skb_queue_tail(&queue, skb);
> aoenet_xmit(&queue);
> - }
> + } else
> + dev_put(f->t->ifp->nd);
> }
>
> static long
…
Should curly brackets be used for both if branches in these function implementations?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.9-rc6#n213
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-14 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240514054214.924-1-jlee@suse.com>
2024-05-14 7:42 ` [PATCH] aoe: fix the potential use-after-free problem in more places Markus Elfring
[not found] <20240410134858.6313-1-jlee@suse.com>
2024-04-30 16:16 ` Markus Elfring
2024-05-13 11:56 ` joeyli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).