* [PATCH] net: qlcnic: Deletion of unnecessary memset
@ 2015-07-13 19:51 Christophe JAILLET
2015-07-14 8:48 ` Shahed Shaikh
2015-07-16 0:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2015-07-13 19:51 UTC (permalink / raw)
To: shahed.shaikh, Dept-GELinuxNICDev
Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET
There is no need to memset memory allocated with vzalloc.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 2f6cc42..7dbab3c 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2403,7 +2403,6 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter *adapter,
qlcnic_free_tx_rings(adapter);
return -ENOMEM;
}
- memset(cmd_buf_arr, 0, TX_BUFF_RINGSIZE(tx_ring));
tx_ring->cmd_buf_arr = cmd_buf_arr;
spin_lock_init(&tx_ring->tx_clean_lock);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] net: qlcnic: Deletion of unnecessary memset
2015-07-13 19:51 [PATCH] net: qlcnic: Deletion of unnecessary memset Christophe JAILLET
@ 2015-07-14 8:48 ` Shahed Shaikh
2015-07-16 0:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shahed Shaikh @ 2015-07-14 8:48 UTC (permalink / raw)
To: Christophe JAILLET, Dept-GE Linux NIC Dev
Cc: netdev, linux-kernel, kernel-janitors
> -----Original Message-----
> From: Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr]
> Sent: Tuesday, July 14, 2015 1:22 AM
> To: Shahed Shaikh; Dept-GE Linux NIC Dev
> Cc: netdev; linux-kernel; kernel-janitors@vger.kernel.org; Christophe JAILLET
> Subject: [PATCH] net: qlcnic: Deletion of unnecessary memset
>
> There is no need to memset memory allocated with vzalloc.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 2f6cc42..7dbab3c 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -2403,7 +2403,6 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter
> *adapter,
> qlcnic_free_tx_rings(adapter);
> return -ENOMEM;
> }
> - memset(cmd_buf_arr, 0, TX_BUFF_RINGSIZE(tx_ring));
> tx_ring->cmd_buf_arr = cmd_buf_arr;
> spin_lock_init(&tx_ring->tx_clean_lock);
> }
Acked-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Thanks,
Shahed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: qlcnic: Deletion of unnecessary memset
2015-07-13 19:51 [PATCH] net: qlcnic: Deletion of unnecessary memset Christophe JAILLET
2015-07-14 8:48 ` Shahed Shaikh
@ 2015-07-16 0:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-07-16 0:20 UTC (permalink / raw)
To: christophe.jaillet
Cc: shahed.shaikh, Dept-GELinuxNICDev, netdev, linux-kernel, kernel-janitors
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Mon, 13 Jul 2015 21:51:38 +0200
> There is no need to memset memory allocated with vzalloc.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-16 0:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-13 19:51 [PATCH] net: qlcnic: Deletion of unnecessary memset Christophe JAILLET
2015-07-14 8:48 ` Shahed Shaikh
2015-07-16 0:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).