From: "Thomas Schmitt" <scdbackup@gmx.net>
To: kernelnewbies@kernelnewbies.org
Cc: lukas.bulwahn@gmail.com, garritfranke@gmail.com, greg@kroah.com
Subject: Re: Please give advise about my first patch attempt
Date: Thu, 03 Sep 2020 17:59:28 +0200 [thread overview]
Message-ID: <16413737425884866123@scdbackup.webframe.org> (raw)
In-Reply-To: <8257736897954643869@scdbackup.webframe.org>
Hi,
i'm back at work with my patch for automatic CD loading, but the target
moves faster than i can follow.
Meanwhile the sr part of my change plays on a fresh construction site
of linux-scsi:
https://lore.kernel.org/linux-scsi/730eced4-c804-a78f-3d52-2a448dbd1b84@interlog.com/T/#t
"rework check_disk_change()"
2020-09-02 14:11 Christoph Hellwig
Currently our plans overlap by [PATCH 17/19] "sr: use
bdev_check_media_change" although they do not (yet) really conflict
https://lore.kernel.org/linux-scsi/730eced4-c804-a78f-3d52-2a448dbd1b84@interlog.com/T/#m9d4c4b6145ed41d6467f2dc4728d6fd0345e94f1
It seems unwise to propose changes while Christoph Hellwig is actively
working on the same code.
(And i don't even know where to get the git branch with such a recent
change when it is committed.)
What is the socially acceptable way to coordinate plans with him ?
- Shall i patiently wait until he is done with cdrom and sr ?
- Shall i announce my interest in fixing automatic tray loading and
other things in a brief mail to the list ?
- Shall i post my patches (*) as they are and just wait for instructions ?
(*)
Studying Christoph's work in linux-scsi brought me to the prediction
that they will want separate patches for cdrom and sr.
Also i reworked my implementation along his design pattern of factoring
out and exporting functions and then calling them where beneficial.
(I.e. my -EDEADLK hack is dead. Long live cdrom_handle_open_tray().
Larger cdrom patch, but also nicer looking code.)
Have a nice day :)
Thomas
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2020-09-03 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 8:49 Please give advise about my first patch attempt Thomas Schmitt
2020-08-27 9:26 ` Lukas Bulwahn
2020-08-27 16:34 ` Thomas Schmitt
2020-08-27 17:30 ` Lukas Bulwahn
2020-08-28 13:03 ` Thomas Schmitt
2020-09-03 15:59 ` Thomas Schmitt [this message]
2020-08-27 9:52 ` Garrit Franke
2020-08-27 13:19 ` Greg KH
2020-08-27 14:02 ` Leam Hall
2020-08-27 16:01 ` Greg KH
2020-08-27 18:32 ` Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16413737425884866123@scdbackup.webframe.org \
--to=scdbackup@gmx.net \
--cc=garritfranke@gmail.com \
--cc=greg@kroah.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).