kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Garrit Franke <garritfranke@gmail.com>
Cc: Thomas Schmitt <scdbackup@gmx.net>,
	Linux Kernel List <kernelnewbies@kernelnewbies.org>
Subject: Re: Please give advise about my first patch attempt
Date: Thu, 27 Aug 2020 15:19:59 +0200	[thread overview]
Message-ID: <20200827131959.GA547311@kroah.com> (raw)
In-Reply-To: <CAD16O86pfM5=-OQ=GrHCn9-pYA+M5qZPTFATKXT=WFW_VXgARA@mail.gmail.com>

On Thu, Aug 27, 2020 at 11:52:56AM +0200, Garrit Franke wrote:
> Hi Thomas,
> 
> Noob here.
> 
> On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt <scdbackup@gmx.net> wrote:
> >
> > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched
> > sr_drive_status() away from indirectly using sr_do_ioctl() for sending
> > TEST UNIT READY commands. sr_do_ioctl() has a wait-and-retry loop for
> > the drive's intermediate sense reply:
> 
> In a recent Patch of mine, Greg nicely pointed out that commits should
> have a standard format across mailing lists: sha ("Commit Message").
> 
> See: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2235132.html

That is also documented in the ever-growing submitting patches document
somewhere...

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2020-08-27 13:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  8:49 Please give advise about my first patch attempt Thomas Schmitt
2020-08-27  9:26 ` Lukas Bulwahn
2020-08-27 16:34   ` Thomas Schmitt
2020-08-27 17:30     ` Lukas Bulwahn
2020-08-28 13:03       ` Thomas Schmitt
2020-09-03 15:59         ` Thomas Schmitt
2020-08-27  9:52 ` Garrit Franke
2020-08-27 13:19   ` Greg KH [this message]
2020-08-27 14:02     ` Leam Hall
2020-08-27 16:01       ` Greg KH
2020-08-27 18:32 ` Pawan Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827131959.GA547311@kroah.com \
    --to=greg@kroah.com \
    --cc=garritfranke@gmail.com \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=scdbackup@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).