From: Jason Wang <jasowang@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: mtosatti@redhat.com, avi@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-test 5/6] Add a simple kvmclock driver
Date: Sun, 29 Aug 2010 23:25:54 -0400 (EDT) [thread overview]
Message-ID: <1424287319.826241283138754729.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <206398826.826221283138725330.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
----- "Glauber Costa" <glommer@redhat.com> wrote:
> On Fri, Aug 27, 2010 at 01:49:45PM +0800, Jason Wang wrote:
> > +#define unlikely(x) __builtin_expect(!!(x), 0)
> > +
> > +struct pvclock_vcpu_time_info hv_clock[MAX_CPU];
> this structure have to be 4-byte aligned. Let the compiler
> help you guaranteeing it here.
>
> > +#define MAX_CPU 4
> > +
> Any particular reason for the number 4? I'd like
> to see these tests running in really big boxes,
> where things get really interesting.
Just because the max cpu num was limited by smp initialization code. I
would change it to 64.
next parent reply other threads:[~2010-08-30 3:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <206398826.826221283138725330.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2010-08-30 3:25 ` Jason Wang [this message]
2010-08-27 5:49 [PATCH kvm-unit-test 0/6] Kvmclock test Jason Wang
2010-08-27 5:49 ` [PATCH kvm-unit-test 5/6] Add a simple kvmclock driver Jason Wang
2010-08-27 11:31 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424287319.826241283138754729.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com \
--to=jasowang@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).