From: Steven Sistare <steven.sistare@oracle.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: kvm@vger.kernel.org, Alex Williamson <alex.williamson@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [PATCH V3 1/9] vfio: option to unmap all
Date: Mon, 1 Feb 2021 07:52:04 -0500 [thread overview]
Message-ID: <1c152346-88ad-80da-f093-a7ebc516a239@oracle.com> (raw)
In-Reply-To: <20210201124206.49d3c71b.cohuck@redhat.com>
On 2/1/2021 6:42 AM, Cornelia Huck wrote:
> On Fri, 29 Jan 2021 08:54:04 -0800
> Steve Sistare <steven.sistare@oracle.com> wrote:
>
>> For the UNMAP_DMA ioctl, delete all mappings if VFIO_DMA_UNMAP_FLAG_ALL
>> is set. Define the corresponding VFIO_UNMAP_ALL extension.
>>
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>> ---
>> include/uapi/linux/vfio.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
>> index 9204705..55578b6 100644
>> --- a/include/uapi/linux/vfio.h
>> +++ b/include/uapi/linux/vfio.h
>> @@ -46,6 +46,9 @@
>> */
>> #define VFIO_NOIOMMU_IOMMU 8
>>
>> +/* Supports VFIO_DMA_UNMAP_FLAG_ALL */
>> +#define VFIO_UNMAP_ALL 9
>> +
>> /*
>> * The IOCTL interface is designed for extensibility by embedding the
>> * structure length (argsz) and flags into structures passed between
>> @@ -1074,6 +1077,7 @@ struct vfio_bitmap {
>> * field. No guarantee is made to the user that arbitrary unmaps of iova
>> * or size different from those used in the original mapping call will
>> * succeed.
>> + *
>> * VFIO_DMA_UNMAP_FLAG_GET_DIRTY_BITMAP should be set to get the dirty bitmap
>> * before unmapping IO virtual addresses. When this flag is set, the user must
>> * provide a struct vfio_bitmap in data[]. User must provide zero-allocated
>> @@ -1083,11 +1087,15 @@ struct vfio_bitmap {
>> * indicates that the page at that offset from iova is dirty. A Bitmap of the
>> * pages in the range of unmapped size is returned in the user-provided
>> * vfio_bitmap.data.
>> + *
>> + * If flags & VFIO_DMA_UNMAP_FLAG_ALL, unmap all addresses. iova and size
>> + * must be 0. This may not be combined with the get-dirty-bitmap flag.
>
> wording nit: s/may not/cannot/
OK. So, the same edit should be applied to this from patch 4:
+ * iova's vaddr will block. DMA to already-mapped pages continues. This may
+ * not be combined with the get-dirty-bitmap flag.
Alex, can you make these edits please?
- Steve
> Or maybe
>
> "VFIO_DMA_UNMAP_FLAG_GET_DIRTY_BITMAP and VFIO_DMA_UNMAP_FLAG_ALL are
> mutually exclusive."
>
> ?
>
>> */
>> struct vfio_iommu_type1_dma_unmap {
>> __u32 argsz;
>> __u32 flags;
>> #define VFIO_DMA_UNMAP_FLAG_GET_DIRTY_BITMAP (1 << 0)
>> +#define VFIO_DMA_UNMAP_FLAG_ALL (1 << 1)
>> __u64 iova; /* IO virtual address */
>> __u64 size; /* Size of mapping (bytes) */
>> __u8 data[];
>
next prev parent reply other threads:[~2021-02-01 12:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 16:54 [PATCH V3 0/9] vfio virtual address update Steve Sistare
2021-01-29 16:54 ` [PATCH V3 1/9] vfio: option to unmap all Steve Sistare
2021-02-01 11:42 ` Cornelia Huck
2021-02-01 12:52 ` Steven Sistare [this message]
2021-02-01 13:13 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 2/9] vfio/type1: unmap cleanup Steve Sistare
2021-02-01 11:50 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 3/9] vfio/type1: implement unmap all Steve Sistare
2021-02-01 11:59 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 4/9] vfio: interfaces to update vaddr Steve Sistare
2021-02-01 13:13 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 5/9] vfio/type1: massage unmap iteration Steve Sistare
2021-01-29 21:56 ` Alex Williamson
2021-01-30 16:51 ` Steven Sistare
2021-02-01 12:11 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 6/9] vfio/type1: implement interfaces to update vaddr Steve Sistare
2021-01-29 21:56 ` Alex Williamson
2021-01-30 16:51 ` Steven Sistare
2021-02-01 12:27 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 7/9] vfio: iommu driver notify callback Steve Sistare
2021-01-29 21:57 ` Alex Williamson
2021-01-30 16:51 ` Steven Sistare
2021-02-01 12:34 ` Cornelia Huck
2021-02-01 12:52 ` Steven Sistare
2021-02-01 13:17 ` Cornelia Huck
2021-02-01 13:17 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 8/9] vfio/type1: implement " Steve Sistare
2021-02-01 12:40 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 9/9] vfio/type1: block on invalid vaddr Steve Sistare
2021-02-01 12:47 ` Cornelia Huck
2021-01-29 21:55 ` [PATCH V3 0/9] vfio virtual address update Alex Williamson
2021-01-29 22:14 ` Steven Sistare
2021-01-30 16:54 ` Steven Sistare
2021-02-01 20:23 ` Alex Williamson
2021-02-01 21:13 ` Steven Sistare
2021-02-02 7:54 ` Cornelia Huck
2021-02-02 17:21 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c152346-88ad-80da-f093-a7ebc516a239@oracle.com \
--to=steven.sistare@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).