From: Cornelia Huck <cohuck@redhat.com>
To: Steven Sistare <steven.sistare@oracle.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [PATCH V3 7/9] vfio: iommu driver notify callback
Date: Mon, 1 Feb 2021 14:17:12 +0100 [thread overview]
Message-ID: <20210201141712.255725b7.cohuck@redhat.com> (raw)
In-Reply-To: <b7c5896d-d3f3-9dd2-15fa-a8137d56964c@oracle.com>
On Mon, 1 Feb 2021 07:52:16 -0500
Steven Sistare <steven.sistare@oracle.com> wrote:
> On 2/1/2021 7:34 AM, Cornelia Huck wrote:
> > On Sat, 30 Jan 2021 11:51:41 -0500
> > Steven Sistare <steven.sistare@oracle.com> wrote:
> >
> >> On 1/29/2021 4:57 PM, Alex Williamson wrote:
> >>> On Fri, 29 Jan 2021 08:54:10 -0800
> >>> Steve Sistare <steven.sistare@oracle.com> wrote:
> >>>
> >>>> Define a vfio_iommu_driver_ops notify callback, for sending events to
> >>>> the driver. Drivers are not required to provide the callback, and
> >>>> may ignore any events. The handling of events is driver specific.
> >>>>
> >>>> Define the CONTAINER_CLOSE event, called when the container's file
> >>>> descriptor is closed. This event signifies that no further state changes
> >>>> will occur via container ioctl's.
> >>>>
> >>>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> >>>> ---
> >>>> drivers/vfio/vfio.c | 5 +++++
> >>>> include/linux/vfio.h | 5 +++++
> >>>> 2 files changed, 10 insertions(+)
> >>>> diff --git a/include/linux/vfio.h b/include/linux/vfio.h
> >>>> index 38d3c6a..9642579 100644
> >>>> --- a/include/linux/vfio.h
> >>>> +++ b/include/linux/vfio.h
> >>>> @@ -57,6 +57,9 @@ extern int vfio_add_group_dev(struct device *dev,
> >>>> extern void vfio_device_put(struct vfio_device *device);
> >>>> extern void *vfio_device_data(struct vfio_device *device);
> >>>>
> >>>> +/* events for the backend driver notify callback */
> >>>> +#define VFIO_DRIVER_NOTIFY_CONTAINER_CLOSE 1
> >>>
> >>> We should use an enum for type checking.
> >>
> >> Agreed.
> >> I see you changed the value to 0. Do you want to reserve 0 for invalid-event?
> >> (I know, this is internal and can be changed). Your call.
> >
> > I'm not sure what we would use an invalid-event event for... the type
> > checking provided by the enum should be enough?
>
> I should have described it as no-event or null-event. It can be useful when
> initializing a struct member that stores an event, eg, last-event-received.
I think we could just use -1 for that. Anyway, easy to change if a need
comes up.
next prev parent reply other threads:[~2021-02-01 13:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 16:54 [PATCH V3 0/9] vfio virtual address update Steve Sistare
2021-01-29 16:54 ` [PATCH V3 1/9] vfio: option to unmap all Steve Sistare
2021-02-01 11:42 ` Cornelia Huck
2021-02-01 12:52 ` Steven Sistare
2021-02-01 13:13 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 2/9] vfio/type1: unmap cleanup Steve Sistare
2021-02-01 11:50 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 3/9] vfio/type1: implement unmap all Steve Sistare
2021-02-01 11:59 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 4/9] vfio: interfaces to update vaddr Steve Sistare
2021-02-01 13:13 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 5/9] vfio/type1: massage unmap iteration Steve Sistare
2021-01-29 21:56 ` Alex Williamson
2021-01-30 16:51 ` Steven Sistare
2021-02-01 12:11 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 6/9] vfio/type1: implement interfaces to update vaddr Steve Sistare
2021-01-29 21:56 ` Alex Williamson
2021-01-30 16:51 ` Steven Sistare
2021-02-01 12:27 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 7/9] vfio: iommu driver notify callback Steve Sistare
2021-01-29 21:57 ` Alex Williamson
2021-01-30 16:51 ` Steven Sistare
2021-02-01 12:34 ` Cornelia Huck
2021-02-01 12:52 ` Steven Sistare
2021-02-01 13:17 ` Cornelia Huck [this message]
2021-02-01 13:17 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 8/9] vfio/type1: implement " Steve Sistare
2021-02-01 12:40 ` Cornelia Huck
2021-01-29 16:54 ` [PATCH V3 9/9] vfio/type1: block on invalid vaddr Steve Sistare
2021-02-01 12:47 ` Cornelia Huck
2021-01-29 21:55 ` [PATCH V3 0/9] vfio virtual address update Alex Williamson
2021-01-29 22:14 ` Steven Sistare
2021-01-30 16:54 ` Steven Sistare
2021-02-01 20:23 ` Alex Williamson
2021-02-01 21:13 ` Steven Sistare
2021-02-02 7:54 ` Cornelia Huck
2021-02-02 17:21 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201141712.255725b7.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).