From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Peter Xu <zhexu@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
peterx@redhat.com
Subject: Re: [PATCH 1/3] KVM: X86: Trace vcpu_id for vmexit
Date: Mon, 29 Jul 2019 09:28:15 -0700 [thread overview]
Message-ID: <20190729162815.GF21120@linux.intel.com> (raw)
In-Reply-To: <20190729053243.9224-2-peterx@redhat.com>
On Mon, Jul 29, 2019 at 01:32:41PM +0800, Peter Xu wrote:
> It helps to pair vmenters and vmexis with multi-core systems.
Typo "vmexis". The wording is also a bit funky. How about:
Tracing the ID helps to pair vmenters and vmexits for guests with
multiple vCPUs.
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> arch/x86/kvm/trace.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index 4d47a2631d1f..26423d2e45df 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -232,17 +232,20 @@ TRACE_EVENT(kvm_exit,
> __field( u32, isa )
> __field( u64, info1 )
> __field( u64, info2 )
> + __field( int, vcpu_id )
> ),
>
> TP_fast_assign(
> __entry->exit_reason = exit_reason;
> __entry->guest_rip = kvm_rip_read(vcpu);
> __entry->isa = isa;
> + __entry->vcpu_id = vcpu->vcpu_id;
> kvm_x86_ops->get_exit_info(vcpu, &__entry->info1,
> &__entry->info2);
> ),
>
> - TP_printk("reason %s rip 0x%lx info %llx %llx",
> + TP_printk("vcpu %d reason %s rip 0x%lx info %llx %llx",
> + __entry->vcpu_id,
> (__entry->isa == KVM_ISA_VMX) ?
> __print_symbolic(__entry->exit_reason, VMX_EXIT_REASONS) :
> __print_symbolic(__entry->exit_reason, SVM_EXIT_REASONS),
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-07-29 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 5:32 [PATCH 0/3] KVM: X86: Some tracepoint enhancements Peter Xu
2019-07-29 5:32 ` [PATCH 1/3] KVM: X86: Trace vcpu_id for vmexit Peter Xu
2019-07-29 16:28 ` Sean Christopherson [this message]
2019-07-30 1:49 ` Peter Xu
2019-07-31 21:49 ` Krish Sadhukhan
2019-07-29 5:32 ` [PATCH 2/3] KVM: X86: Remove tailing newline for tracepoints Peter Xu
2019-08-01 0:19 ` Krish Sadhukhan
2019-08-01 3:39 ` Wanpeng Li
2019-08-13 16:43 ` Peter Xu
2019-07-29 5:32 ` [PATCH 3/3] KVM: X86: Tune PLE Window tracepoint Peter Xu
2019-07-29 16:23 ` Sean Christopherson
2019-07-30 1:43 ` Peter Xu
2019-07-30 2:06 ` Sean Christopherson
2019-07-30 2:12 ` Peter Xu
2019-07-30 2:25 ` Peter Xu
2019-07-30 2:28 ` Sean Christopherson
2019-07-30 2:39 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729162815.GF21120@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=zhexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).