From: Peter Xu <peterx@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Peter Xu <zhexu@redhat.com>, kvm <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/3] KVM: X86: Remove tailing newline for tracepoints
Date: Tue, 13 Aug 2019 18:43:54 +0200 [thread overview]
Message-ID: <20190813164354.GA14469@xz-x1> (raw)
In-Reply-To: <CANRm+CxkdBXZ170nXiKiQ-a-xzZObEXZdBgsAx5jrE=aroTR5w@mail.gmail.com>
On Thu, Aug 01, 2019 at 11:39:04AM +0800, Wanpeng Li wrote:
> On Mon, 29 Jul 2019 at 13:35, Peter Xu <zhexu@redhat.com> wrote:
> >
> > It's done by TP_printk() already.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > arch/x86/kvm/trace.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> > index 26423d2e45df..76a39bc25b95 100644
> > --- a/arch/x86/kvm/trace.h
> > +++ b/arch/x86/kvm/trace.h
> > @@ -1323,7 +1323,7 @@ TRACE_EVENT(kvm_avic_incomplete_ipi,
> > __entry->index = index;
> > ),
> >
> > - TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u\n",
> > + TP_printk("vcpu=%u, icrh:icrl=%#010x:%08x, id=%u, index=%u",
> > __entry->vcpu, __entry->icrh, __entry->icrl,
> > __entry->id, __entry->index)
> > );
> > @@ -1348,7 +1348,7 @@ TRACE_EVENT(kvm_avic_unaccelerated_access,
> > __entry->vec = vec;
> > ),
> >
> > - TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x\n",
> > + TP_printk("vcpu=%u, offset=%#x(%s), %s, %s, vec=%#x",
> > __entry->vcpu,
> > __entry->offset,
> > __print_symbolic(__entry->offset, kvm_trace_symbol_apic),
> > @@ -1368,7 +1368,7 @@ TRACE_EVENT(kvm_hv_timer_state,
> > __entry->vcpu_id = vcpu_id;
> > __entry->hv_timer_in_use = hv_timer_in_use;
> > ),
> > - TP_printk("vcpu_id %x hv_timer %x\n",
> > + TP_printk("vcpu_id %x hv_timer %x",
> > __entry->vcpu_id,
> > __entry->hv_timer_in_use)
>
> The last one is handled by commit 7be373b6de503 .
Right, I'll rebase. Thanks.
--
Peter Xu
next prev parent reply other threads:[~2019-08-13 16:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 5:32 [PATCH 0/3] KVM: X86: Some tracepoint enhancements Peter Xu
2019-07-29 5:32 ` [PATCH 1/3] KVM: X86: Trace vcpu_id for vmexit Peter Xu
2019-07-29 16:28 ` Sean Christopherson
2019-07-30 1:49 ` Peter Xu
2019-07-31 21:49 ` Krish Sadhukhan
2019-07-29 5:32 ` [PATCH 2/3] KVM: X86: Remove tailing newline for tracepoints Peter Xu
2019-08-01 0:19 ` Krish Sadhukhan
2019-08-01 3:39 ` Wanpeng Li
2019-08-13 16:43 ` Peter Xu [this message]
2019-07-29 5:32 ` [PATCH 3/3] KVM: X86: Tune PLE Window tracepoint Peter Xu
2019-07-29 16:23 ` Sean Christopherson
2019-07-30 1:43 ` Peter Xu
2019-07-30 2:06 ` Sean Christopherson
2019-07-30 2:12 ` Peter Xu
2019-07-30 2:25 ` Peter Xu
2019-07-30 2:28 ` Sean Christopherson
2019-07-30 2:39 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813164354.GA14469@xz-x1 \
--to=peterx@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=zhexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).