* [PATCH] KVM: SVM: Remove check if APICv enabled in SVM update_cr8_intercept() handler
@ 2019-11-11 12:26 Liran Alon
2019-11-12 23:08 ` Jim Mattson
0 siblings, 1 reply; 2+ messages in thread
From: Liran Alon @ 2019-11-11 12:26 UTC (permalink / raw)
To: pbonzini, rkrcmar, kvm
Cc: sean.j.christopherson, jmattson, vkuznets, Liran Alon, Joao Martins
This check is unnecessary as x86 update_cr8_intercept() which calls
this VMX/SVM specific callback already performs this check.
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
---
arch/x86/kvm/svm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index c5673bda4b66..8d729da932cc 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -5092,8 +5092,7 @@ static void update_cr8_intercept(struct kvm_vcpu *vcpu, int tpr, int irr)
{
struct vcpu_svm *svm = to_svm(vcpu);
- if (svm_nested_virtualize_tpr(vcpu) ||
- kvm_vcpu_apicv_active(vcpu))
+ if (svm_nested_virtualize_tpr(vcpu))
return;
clr_cr_intercept(svm, INTERCEPT_CR8_WRITE);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: SVM: Remove check if APICv enabled in SVM update_cr8_intercept() handler
2019-11-11 12:26 [PATCH] KVM: SVM: Remove check if APICv enabled in SVM update_cr8_intercept() handler Liran Alon
@ 2019-11-12 23:08 ` Jim Mattson
0 siblings, 0 replies; 2+ messages in thread
From: Jim Mattson @ 2019-11-12 23:08 UTC (permalink / raw)
To: Liran Alon
Cc: Paolo Bonzini, Radim Krčmář,
kvm list, Sean Christopherson, Vitaly Kuznetsov, Joao Martins
On Mon, Nov 11, 2019 at 4:26 AM Liran Alon <liran.alon@oracle.com> wrote:
>
> This check is unnecessary as x86 update_cr8_intercept() which calls
> this VMX/SVM specific callback already performs this check.
>
> Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-12 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 12:26 [PATCH] KVM: SVM: Remove check if APICv enabled in SVM update_cr8_intercept() handler Liran Alon
2019-11-12 23:08 ` Jim Mattson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).