* [kvm-unit-tests PATCH] arm: Add missing test name prefix for pl031 and spinlock
@ 2019-11-18 2:27 kuhn.chenqun
2019-11-18 8:06 ` Andrew Jones
0 siblings, 1 reply; 2+ messages in thread
From: kuhn.chenqun @ 2019-11-18 2:27 UTC (permalink / raw)
To: kvm, kvmarm, drjones
Cc: kenny.zhangjun, kuhn.chenqun, pannengyuan, zhang.zhanghailiang
From: Chen Qun <kuhn.chenqun@huawei.com>
pl031 and spinlock testcase without prefix, when running
the unit tests in TAP mode (./run_tests.sh -t), it is
difficult to the test results.
The test results:
ok 13 - Periph/PCell IDs match
ok 14 - R/O fields are R/O
ok 15 - RTC ticks at 1HZ
ok 16 - RTC IRQ not pending yet
...
ok 24 - RTC IRQ not pending anymore
ok 25 - CPU1: Done - Errors: 0
ok 26 - CPU0: Done - Errors: 0
It should be like this:
ok 13 - pl031: Periph/PCell IDs match
ok 14 - pl031: R/O fields are R/O
ok 15 - pl031: RTC ticks at 1HZ
ok 16 - pl031: RTC IRQ not pending yet
...
ok 24 - pl031: RTC IRQ not pending anymore
ok 25 - spinlock: CPU0: Done - Errors: 0
ok 26 - spinlock: CPU1: Done - Errors: 0
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
arm/pl031.c | 1 +
arm/spinlock-test.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arm/pl031.c b/arm/pl031.c
index 5672f36..d0c9c10 100644
--- a/arm/pl031.c
+++ b/arm/pl031.c
@@ -252,6 +252,7 @@ int main(int argc, char **argv)
return 0;
}
+ report_prefix_push("pl031");
report("Periph/PCell IDs match", !check_id());
report("R/O fields are R/O", !check_ro());
report("RTC ticks at 1HZ", !check_rtc_freq());
diff --git a/arm/spinlock-test.c b/arm/spinlock-test.c
index d55471b..ff16fb0 100644
--- a/arm/spinlock-test.c
+++ b/arm/spinlock-test.c
@@ -72,6 +72,7 @@ static void test_spinlock(void *data __unused)
int main(int argc, char **argv)
{
+ report_prefix_push("spinlock");
if (argc > 1 && strcmp(argv[1], "bad") != 0) {
lock_ops.lock = gcc_builtin_lock;
lock_ops.unlock = gcc_builtin_unlock;
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kvm-unit-tests PATCH] arm: Add missing test name prefix for pl031 and spinlock
2019-11-18 2:27 [kvm-unit-tests PATCH] arm: Add missing test name prefix for pl031 and spinlock kuhn.chenqun
@ 2019-11-18 8:06 ` Andrew Jones
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jones @ 2019-11-18 8:06 UTC (permalink / raw)
To: kuhn.chenqun
Cc: kvm, kvmarm, kenny.zhangjun, pannengyuan, zhang.zhanghailiang
On Mon, Nov 18, 2019 at 10:27:20AM +0800, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> pl031 and spinlock testcase without prefix, when running
> the unit tests in TAP mode (./run_tests.sh -t), it is
> difficult to the test results.
>
> The test results:
> ok 13 - Periph/PCell IDs match
> ok 14 - R/O fields are R/O
> ok 15 - RTC ticks at 1HZ
> ok 16 - RTC IRQ not pending yet
> ...
> ok 24 - RTC IRQ not pending anymore
> ok 25 - CPU1: Done - Errors: 0
> ok 26 - CPU0: Done - Errors: 0
>
> It should be like this:
> ok 13 - pl031: Periph/PCell IDs match
> ok 14 - pl031: R/O fields are R/O
> ok 15 - pl031: RTC ticks at 1HZ
> ok 16 - pl031: RTC IRQ not pending yet
> ...
> ok 24 - pl031: RTC IRQ not pending anymore
> ok 25 - spinlock: CPU0: Done - Errors: 0
> ok 26 - spinlock: CPU1: Done - Errors: 0
>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> arm/pl031.c | 1 +
> arm/spinlock-test.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arm/pl031.c b/arm/pl031.c
> index 5672f36..d0c9c10 100644
> --- a/arm/pl031.c
> +++ b/arm/pl031.c
> @@ -252,6 +252,7 @@ int main(int argc, char **argv)
> return 0;
> }
>
> + report_prefix_push("pl031");
> report("Periph/PCell IDs match", !check_id());
> report("R/O fields are R/O", !check_ro());
> report("RTC ticks at 1HZ", !check_rtc_freq());
> diff --git a/arm/spinlock-test.c b/arm/spinlock-test.c
> index d55471b..ff16fb0 100644
> --- a/arm/spinlock-test.c
> +++ b/arm/spinlock-test.c
> @@ -72,6 +72,7 @@ static void test_spinlock(void *data __unused)
>
> int main(int argc, char **argv)
> {
> + report_prefix_push("spinlock");
> if (argc > 1 && strcmp(argv[1], "bad") != 0) {
> lock_ops.lock = gcc_builtin_lock;
> lock_ops.unlock = gcc_builtin_unlock;
> --
> 2.14.1.windows.1
>
>
Queued to https://github.com/rhdrjones/kvm-unit-tests/tree/arm/queue
Thanks,
drew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-18 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 2:27 [kvm-unit-tests PATCH] arm: Add missing test name prefix for pl031 and spinlock kuhn.chenqun
2019-11-18 8:06 ` Andrew Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).