* [PATCH] KVM: SVM: Do not setup frame pointer in __svm_vcpu_run
@ 2020-04-09 12:04 Uros Bizjak
2020-04-15 15:41 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2020-04-09 12:04 UTC (permalink / raw)
To: kvm; +Cc: Uros Bizjak, Paolo Bonzini
__svm_vcpu_run is a leaf function and does not need
a frame pointer. %rbp is also destroyed a few instructions
later when guest registers are loaded.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
---
arch/x86/kvm/svm/vmenter.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/svm/vmenter.S b/arch/x86/kvm/svm/vmenter.S
index fa1af90067e9..c87119a7a0c9 100644
--- a/arch/x86/kvm/svm/vmenter.S
+++ b/arch/x86/kvm/svm/vmenter.S
@@ -35,7 +35,6 @@
*/
SYM_FUNC_START(__svm_vcpu_run)
push %_ASM_BP
- mov %_ASM_SP, %_ASM_BP
#ifdef CONFIG_X86_64
push %r15
push %r14
--
2.25.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: SVM: Do not setup frame pointer in __svm_vcpu_run
2020-04-09 12:04 [PATCH] KVM: SVM: Do not setup frame pointer in __svm_vcpu_run Uros Bizjak
@ 2020-04-15 15:41 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-04-15 15:41 UTC (permalink / raw)
To: Uros Bizjak, kvm
On 09/04/20 14:04, Uros Bizjak wrote:
> __svm_vcpu_run is a leaf function and does not need
> a frame pointer. %rbp is also destroyed a few instructions
> later when guest registers are loaded.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> ---
> arch/x86/kvm/svm/vmenter.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm/vmenter.S b/arch/x86/kvm/svm/vmenter.S
> index fa1af90067e9..c87119a7a0c9 100644
> --- a/arch/x86/kvm/svm/vmenter.S
> +++ b/arch/x86/kvm/svm/vmenter.S
> @@ -35,7 +35,6 @@
> */
> SYM_FUNC_START(__svm_vcpu_run)
> push %_ASM_BP
> - mov %_ASM_SP, %_ASM_BP
> #ifdef CONFIG_X86_64
> push %r15
> push %r14
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 12:04 [PATCH] KVM: SVM: Do not setup frame pointer in __svm_vcpu_run Uros Bizjak
2020-04-15 15:41 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).