From: Andrew Jones <drjones@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Po-Hsu Lin <po-hsu.lin@canonical.com>,
kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCHv2] unittests.cfg: Increase timeout for apic test
Date: Tue, 20 Oct 2020 10:49:35 +0200 [thread overview]
Message-ID: <20201020084935.ltaitsuz45fr3wnm@kamzik.brq.redhat.com> (raw)
In-Reply-To: <1e37df99-2d5c-be4c-4f42-1534f6164982@redhat.com>
On Tue, Oct 20, 2020 at 07:53:49AM +0200, Thomas Huth wrote:
> On 16/10/2020 19.40, Andrew Jones wrote:
> > On Fri, Oct 16, 2020 at 07:02:57PM +0200, Paolo Bonzini wrote:
> >> On 15/10/20 18:35, Sean Christopherson wrote:
> >>> The port80 test in particular is an absolute waste of time.
> >>>
> >>
> >> True, OTOH it was meant as a benchmark. I think we can just delete it
> >> or move it to vmexit.
> >>
> >
> > If you want to keep the code, but only run it manually sometimes,
> > then you can mark the test as nodefault.
>
> Please let's avoid that. Code that does not get run by default tends to
> bitrot. I suggest to decrease the amount of loops by default, and if
> somebody still wants to run this as a kind of benchmark, maybe the amount of
> loops could be made configurable? (i.e. so that you could control it via an
> argv[] parameter?)
>
I think both make sense. Making the number of loops variable is a good
idea in order to keep the test running in CI in a reasonable amount of
time (the timeout can also be adjusted by the CI runner, of course). Also,
marking the test as nodefault makes sense if nobody really cares about
the output unless they're specifically doing some benchmarking. Nothing
stops travis or other CI from running nodefault tests, they just have to
be explicitly requested.
Thanks,
drew
next prev parent reply other threads:[~2020-10-20 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:12 [kvm-unit-tests PATCHv2] unittests.cfg: Increase timeout for apic test Po-Hsu Lin
2020-10-15 15:59 ` Vitaly Kuznetsov
2020-10-15 16:35 ` Sean Christopherson
2020-10-16 17:02 ` Paolo Bonzini
2020-10-16 17:40 ` Andrew Jones
2020-10-20 5:53 ` Thomas Huth
2020-10-20 8:49 ` Andrew Jones [this message]
2020-10-19 11:32 ` Vitaly Kuznetsov
2020-10-19 16:37 ` Christopherson, Sean J
2020-10-19 16:52 ` Nadav Amit
2020-10-20 8:48 ` Paolo Bonzini
2020-10-20 15:05 ` Christopherson, Sean J
2020-10-30 8:15 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020084935.ltaitsuz45fr3wnm@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=po-hsu.lin@canonical.com \
--cc=sean.j.christopherson@intel.com \
--cc=thuth@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).