kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nadav Amit <nadav.amit@gmail.com>
To: "Christopherson, Sean J" <sean.j.christopherson@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Po-Hsu Lin <po-hsu.lin@canonical.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCHv2] unittests.cfg: Increase timeout for apic test
Date: Mon, 19 Oct 2020 09:52:57 -0700	[thread overview]
Message-ID: <C67F3473-32FE-4099-BBB1-8BB31B1ED95D@gmail.com> (raw)
In-Reply-To: <a6e33cd7d0084d6389a02786225db0e8@intel.com>

> On Oct 19, 2020, at 9:37 AM, Christopherson, Sean J <sean.j.christopherson@intel.com> wrote:
> 
> On Mon, Oct 19, 2020 at 01:32:00PM +0200, Vitaly Kuznetsov wrote:
>> Sean Christopherson <sean.j.christopherson@intel.com> writes:
>>> E.g. does running 1M loops in test_multiple_nmi() really add value versus
>>> say 10k or 100k loops?
>> 
>> Oddly enough, I vaguely remember this particular test hanging
>> *sometimes* after a few thousand loops but I don't remember any
>> details.
> 
> Thousands still ain't millions :-D.
> 
> IMO, the unit tests should sit between a smoke test and a long running,
> intensive stress test, i.e. the default config shouldn't be trying to find
> literal one-in-a-million bugs on every run.

IIRC, this test failed on VMware, and according to our previous discussions,
does not follow the SDM as NMIs might be collapsed [1].

[1] https://marc.info/?l=kvm&m=145876994031502&w=2


  reply	other threads:[~2020-10-19 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  9:12 [kvm-unit-tests PATCHv2] unittests.cfg: Increase timeout for apic test Po-Hsu Lin
2020-10-15 15:59 ` Vitaly Kuznetsov
2020-10-15 16:35   ` Sean Christopherson
2020-10-16 17:02     ` Paolo Bonzini
2020-10-16 17:40       ` Andrew Jones
2020-10-20  5:53         ` Thomas Huth
2020-10-20  8:49           ` Andrew Jones
2020-10-19 11:32     ` Vitaly Kuznetsov
2020-10-19 16:37       ` Christopherson, Sean J
2020-10-19 16:52         ` Nadav Amit [this message]
2020-10-20  8:48           ` Paolo Bonzini
2020-10-20 15:05             ` Christopherson, Sean J
2020-10-30  8:15   ` Po-Hsu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C67F3473-32FE-4099-BBB1-8BB31B1ED95D@gmail.com \
    --to=nadav.amit@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=po-hsu.lin@canonical.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).