* [PATCH -next] KVM: SVM: Make symbol 'svm_gp_erratum_intercept' static
@ 2021-02-10 7:59 Wei Yongjun
2021-02-10 17:11 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-02-10 7:59 UTC (permalink / raw)
To: Hulk Robot, Paolo Bonzini, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Bandan Das, Wei Huang
Cc: Wei Yongjun, kvm, x86
The sparse tool complains as follows:
arch/x86/kvm/svm/svm.c:204:6: warning:
symbol 'svm_gp_erratum_intercept' was not declared. Should it be static?
This symbol is not used outside of svm.c, so this
commit marks it static.
Fixes: 82a11e9c6fa2b ("KVM: SVM: Add emulation support for #GP triggered by SVM instructions")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/x86/kvm/svm/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index 4141caea857a..4a41d11aabfe 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -201,7 +201,7 @@ module_param(sev_es, int, 0444);
bool __read_mostly dump_invalid_vmcb;
module_param(dump_invalid_vmcb, bool, 0644);
-bool svm_gp_erratum_intercept = true;
+static bool svm_gp_erratum_intercept = true;
static u8 rsm_ins_bytes[] = "\x0f\xaa";
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] KVM: SVM: Make symbol 'svm_gp_erratum_intercept' static
2021-02-10 7:59 [PATCH -next] KVM: SVM: Make symbol 'svm_gp_erratum_intercept' static Wei Yongjun
@ 2021-02-10 17:11 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-02-10 17:11 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Bandan Das, Wei Huang
Cc: kvm, x86
On 10/02/21 08:59, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> arch/x86/kvm/svm/svm.c:204:6: warning:
> symbol 'svm_gp_erratum_intercept' was not declared. Should it be static?
>
> This symbol is not used outside of svm.c, so this
> commit marks it static.
>
> Fixes: 82a11e9c6fa2b ("KVM: SVM: Add emulation support for #GP triggered by SVM instructions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/x86/kvm/svm/svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 4141caea857a..4a41d11aabfe 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -201,7 +201,7 @@ module_param(sev_es, int, 0444);
> bool __read_mostly dump_invalid_vmcb;
> module_param(dump_invalid_vmcb, bool, 0644);
>
> -bool svm_gp_erratum_intercept = true;
> +static bool svm_gp_erratum_intercept = true;
>
> static u8 rsm_ins_bytes[] = "\x0f\xaa";
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-10 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 7:59 [PATCH -next] KVM: SVM: Make symbol 'svm_gp_erratum_intercept' static Wei Yongjun
2021-02-10 17:11 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).