From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/3] libcflat: use stdbool
Date: Tue, 2 Jul 2019 18:08:44 +0200 [thread overview]
Message-ID: <206afe8e-b7f8-0501-2ee8-45c9177a079d@redhat.com> (raw)
In-Reply-To: <20190628203019.3220-2-nadav.amit@gmail.com>
On 28/06/19 22:30, Nadav Amit wrote:
> To avoid any future build errors, using stdbool instead of defining
> bool.
>
> Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
> ---
> lib/libcflat.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/lib/libcflat.h b/lib/libcflat.h
> index 7529958..b94d0ac 100644
> --- a/lib/libcflat.h
> +++ b/lib/libcflat.h
> @@ -24,6 +24,7 @@
> #include <stddef.h>
> #include <stdint.h>
> #include <string.h>
> +#include <stdbool.h>
>
> #define __unused __attribute__((__unused__))
>
> @@ -53,10 +54,6 @@ typedef uint64_t u64;
> typedef int64_t s64;
> typedef unsigned long ulong;
>
> -typedef _Bool bool;
> -#define false 0
> -#define true 1
> -
> #if __SIZEOF_LONG__ == 8
> # define __PRI32_PREFIX
> # define __PRI64_PREFIX "l"
>
Queued this one.
Paolo
next prev parent reply other threads:[~2019-07-02 16:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 20:30 [kvm-unit-tests PATCH 0/3] x86: Running tests on bare-metal Nadav Amit
2019-06-28 20:30 ` [kvm-unit-tests PATCH 1/3] libcflat: use stdbool Nadav Amit
2019-07-02 16:08 ` Paolo Bonzini [this message]
2019-06-28 20:30 ` [kvm-unit-tests PATCH 2/3] x86/vmx: Use plus for positive filters Nadav Amit
2019-06-28 20:30 ` [kvm-unit-tests PATCH 3/3] x86: Support environments without test-devices Nadav Amit
2019-07-02 16:08 ` Paolo Bonzini
2019-07-02 16:43 ` Nadav Amit
2019-07-02 17:24 ` Paolo Bonzini
2019-07-02 17:45 ` Nadav Amit
2019-07-02 18:28 ` Paolo Bonzini
2019-07-02 23:39 ` Nadav Amit
2019-07-02 23:56 ` Nadav Amit
2019-07-03 5:39 ` Paolo Bonzini
2019-07-03 6:09 ` Nadav Amit
2019-07-15 15:48 ` Andrew Jones
2019-07-15 18:08 ` Nadav Amit
2019-07-15 18:26 ` Paolo Bonzini
2019-07-15 18:43 ` Nadav Amit
2019-07-15 18:54 ` Paolo Bonzini
2019-07-21 16:40 ` Nadav Amit
2019-07-21 16:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=206afe8e-b7f8-0501-2ee8-45c9177a079d@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).