From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Andrew Jones <drjones@redhat.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: [kvm-unit-tests PATCH 3/3] x86: Support environments without test-devices
Date: Mon, 15 Jul 2019 20:54:09 +0200 [thread overview]
Message-ID: <91f59a9e-f225-b225-079b-f4ef32724163@redhat.com> (raw)
In-Reply-To: <9A78B004-E8B8-427A-B522-C0847CBEFDD3@gmail.com>
On 15/07/19 20:43, Nadav Amit wrote:
>> On Jul 15, 2019, at 11:26 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 15/07/19 20:08, Nadav Amit wrote:
>>>> This works because setup_multiboot() looks for an initrd, and then,
>>>> if present, it gets interpreted as a list of environment variables
>>>> which become the unit tests **envp.
>>>
>>> Looks like a nice solution, but Paolo preferred to see if this information
>>> can be extracted from e810 and ACPI MADT. Paolo?
>>
>> It was mostly a matter of requiring adjustments in the tests. Andrew's
>> solution would be fine!
>
> Ok, but I must be missing something, because the changes I proposed before
> did not require any changes to the tests either (when they are run on top
> of KVM).
You're right, I was confused. There were changes to a couple tests but
they are not related to fw_cfg. I only disliked having to repeat the
same information (as opposed to just the initrd path) in all the
entries. Memory map and MADT would be my preferred choice, but as a
stopgap Andrew's idea is okay.
Paolo
> Andrew’s solution would just make it easier to set “fixed” boot-loader
> entries, although they would still need a different root and
> boot-relative-path on different machines.
next prev parent reply other threads:[~2019-07-15 18:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 20:30 [kvm-unit-tests PATCH 0/3] x86: Running tests on bare-metal Nadav Amit
2019-06-28 20:30 ` [kvm-unit-tests PATCH 1/3] libcflat: use stdbool Nadav Amit
2019-07-02 16:08 ` Paolo Bonzini
2019-06-28 20:30 ` [kvm-unit-tests PATCH 2/3] x86/vmx: Use plus for positive filters Nadav Amit
2019-06-28 20:30 ` [kvm-unit-tests PATCH 3/3] x86: Support environments without test-devices Nadav Amit
2019-07-02 16:08 ` Paolo Bonzini
2019-07-02 16:43 ` Nadav Amit
2019-07-02 17:24 ` Paolo Bonzini
2019-07-02 17:45 ` Nadav Amit
2019-07-02 18:28 ` Paolo Bonzini
2019-07-02 23:39 ` Nadav Amit
2019-07-02 23:56 ` Nadav Amit
2019-07-03 5:39 ` Paolo Bonzini
2019-07-03 6:09 ` Nadav Amit
2019-07-15 15:48 ` Andrew Jones
2019-07-15 18:08 ` Nadav Amit
2019-07-15 18:26 ` Paolo Bonzini
2019-07-15 18:43 ` Nadav Amit
2019-07-15 18:54 ` Paolo Bonzini [this message]
2019-07-21 16:40 ` Nadav Amit
2019-07-21 16:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f59a9e-f225-b225-079b-f4ef32724163@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).