[PATCH] KVM: Fix apic_mmio_write return for unaligned write

[PATCH] KVM: Fix apic_mmio_write return for unaligned write

[Sheng Yang]

Some in-famous OS do unaligned writing for APIC MMIO, and the return value
has been missed in recent change, then the OS hangs.

(it's curious that the compilation warning have been ignored...)

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 arch/x86/kvm/lapic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 6f559d6..ccafe0d 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -831,7 +831,7 @@ static int apic_mmio_write(struct kvm_io_device *this,
 	if (len != 4 || (offset & 0xf)) {
 		/* Don't shout loud, $infamous_os would cause only noise. */
 		apic_debug("apic write: bad size=%d %lx\n", len, (long)address);
-		return;
+		return 0;
 	}
 
 	val = *(u32*)data;
-- 
1.5.4.5

Re: [PATCH] KVM: Fix apic_mmio_write return for unaligned write

[Avi Kivity]

On 07/06/2009 06:05 AM, Sheng Yang wrote:
> Some in-famous OS do unaligned writing for APIC MMIO, and the return value
> has been missed in recent change, then the OS hangs.
>
>    

Applied, thanks.

> (it's curious that the compilation warning have been ignored...)
>    

Yes, need to be more careful.

-- 
error compiling committee.c: too many arguments to function