From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Fam Zheng" <fam@euphon.net>,
"Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-block@nongnu.org, kvm@vger.kernel.org,
"Laurent Vivier" <lvivier@redhat.com>,
qemu-arm@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"John Snow" <jsnow@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v6 02/11] exec: Restrict TCG specific headers
Date: Mon, 01 Feb 2021 13:24:26 +0000 [thread overview]
Message-ID: <87wnvrvryj.fsf@linaro.org> (raw)
In-Reply-To: <20210131115022.242570-3-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Fixes when building with --disable-tcg on ARM:
>
> In file included from target/arm/helper.c:16:
> include/exec/helper-proto.h:42:10: fatal error: tcg-runtime.h: No such file or directory
> 42 | #include "tcg-runtime.h"
> | ^~~~~~~~~~~~~~~
I think the problem here is that we have stuff in helper.c which is
needed by non-TCG builds.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/exec/helper-proto.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/exec/helper-proto.h b/include/exec/helper-proto.h
> index 659f9298e8f..740bff3bb4d 100644
> --- a/include/exec/helper-proto.h
> +++ b/include/exec/helper-proto.h
> @@ -39,8 +39,10 @@ dh_ctype(ret) HELPER(name) (dh_ctype(t1), dh_ctype(t2), dh_ctype(t3), \
>
> #include "helper.h"
> #include "trace/generated-helpers.h"
> +#ifdef CONFIG_TCG
> #include "tcg-runtime.h"
> #include "plugin-helpers.h"
> +#endif /* CONFIG_TCG */
If we are including helper-proto.h then we are defining helpers which
are (should be) TCG only.
>
> #undef IN_HELPER_PROTO
--
Alex Bennée
next prev parent reply other threads:[~2021-02-01 13:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131115022.242570-1-f4bug@amsat.org>
[not found] ` <20210131115022.242570-6-f4bug@amsat.org>
2021-01-31 14:29 ` [PATCH v6 05/11] target/arm: Restrict ARMv6 cpus to TCG accel Claudio Fontana
2021-02-01 17:18 ` Alex Bennée
2021-01-31 14:40 ` [PATCH v6 00/11] Support disabling TCG on ARM (part 2) Claudio Fontana
2021-01-31 15:23 ` Philippe Mathieu-Daudé
[not found] ` <20210131115022.242570-2-f4bug@amsat.org>
[not found] ` <87d562ba-20e5-ee50-8793-59d77564f4da@suse.de>
2021-01-31 15:23 ` [PATCH v6 01/11] sysemu/tcg: Introduce tcg_builtin() helper Philippe Mathieu-Daudé
2021-02-01 14:29 ` Claudio Fontana
[not found] ` <20210131115022.242570-3-f4bug@amsat.org>
2021-02-01 13:24 ` Alex Bennée [this message]
[not found] ` <20210131115022.242570-7-f4bug@amsat.org>
[not found] ` <80af7db7-2311-7cc5-93a0-f0609b0222d0@redhat.com>
2021-02-01 17:37 ` [PATCH v6 06/11] target/arm: Restrict ARMv7 R-profile cpus to TCG accel Alex Bennée
[not found] ` <20210131115022.242570-4-f4bug@amsat.org>
2021-02-01 17:10 ` [PATCH v6 03/11] target/arm: Restrict ARMv4 " Alex Bennée
2021-03-04 11:55 ` Claudio Fontana
2021-03-04 19:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnvrvryj.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).