From: Claudio Fontana <cfontana@suse.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
kvm@vger.kernel.org, qemu-block@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"John Snow" <jsnow@redhat.com>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v6 00/11] Support disabling TCG on ARM (part 2)
Date: Sun, 31 Jan 2021 15:40:09 +0100 [thread overview]
Message-ID: <9924223e-3aeb-5200-c7fa-f120a7ae30fe@suse.de> (raw)
In-Reply-To: <20210131115022.242570-1-f4bug@amsat.org>
On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
> Cover from Samuel Ortiz from (part 1) [1]:
>
> This patchset allows for building and running ARM targets with TCG
> disabled. [...]
>
> The rationale behind this work comes from the NEMU project where
> we're trying to only support x86 and ARM 64-bit architectures,
> without including the TCG code base. We can only do so if we can
> build and run ARM binaries with TCG disabled.
>
> Peter mentioned in v5 [6] that since 32-bit host has been removed,
> we have to remove v7 targets. This is not done in this series, as
> linking succeeds, and there is enough material to review (no need
> to spend time on that extra patch if the current approach is not
> accepted).
>
> CI: https://gitlab.com/philmd/qemu/-/pipelines/249272441
>
> v6:
> - rebased on "target/arm/Kconfig" series
> - introduce/use tcg_builtin() for realview machines
>
> v5:
> - addressed Paolo/Richard/Thomas review comments from v4 [5].
>
> v4 almost 2 years later... [2]:
> - Rebased on Meson
> - Addressed Richard review comments
> - Addressed Claudio review comments
>
> v3 almost 18 months later [3]:
> - Rebased
> - Addressed Thomas review comments
> - Added Travis-CI job to keep building --disable-tcg on ARM
>
> v2 [4]:
> - Addressed review comments from Richard and Thomas from v1 [1]
>
> Regards,
>
> Phil.
>
> [1]: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg02451.html
> [2]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg689168.html
> [3]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg641796.html
> [4]: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg05003.html
> [5]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg746041.html
> [6]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg777669.html
>
> Based-on: <20210131111316.232778-1-f4bug@amsat.org>
> "target: Provide target-specific Kconfig"
>
> Philippe Mathieu-Daudé (9):
> sysemu/tcg: Introduce tcg_builtin() helper
> exec: Restrict TCG specific headers
> target/arm: Restrict ARMv4 cpus to TCG accel
> target/arm: Restrict ARMv5 cpus to TCG accel
> target/arm: Restrict ARMv6 cpus to TCG accel
> target/arm: Restrict ARMv7 R-profile cpus to TCG accel
> target/arm: Restrict ARMv7 M-profile cpus to TCG accel
> target/arm: Reorder meson.build rules
> .travis.yml: Add a KVM-only Aarch64 job
>
> Samuel Ortiz (1):
> target/arm: Do not build TCG objects when TCG is off
>
> Thomas Huth (1):
> target/arm: Make m_helper.c optional via CONFIG_ARM_V7M
>
> default-configs/devices/aarch64-softmmu.mak | 1 -
> default-configs/devices/arm-softmmu.mak | 27 --------
> include/exec/helper-proto.h | 2 +
> include/sysemu/tcg.h | 2 +
> target/arm/cpu.h | 12 ----
> hw/arm/realview.c | 7 +-
> target/arm/cpu_tcg.c | 4 +-
> target/arm/helper.c | 7 --
> target/arm/m_helper-stub.c | 73 +++++++++++++++++++++
> tests/qtest/cdrom-test.c | 6 +-
> .travis.yml | 32 +++++++++
> hw/arm/Kconfig | 38 +++++++++++
> target/arm/Kconfig | 17 +++++
> target/arm/meson.build | 28 +++++---
> 14 files changed, 196 insertions(+), 60 deletions(-)
> create mode 100644 target/arm/m_helper-stub.c
>
Looking at this series, just my 2 cents on how I would suggest to go forward:
I could again split my series in two parts, with only the TCG Ops in the first part.
Then this series could be merged, enabling --disable-tcg for ARM,
then I could extend the second part of my series to include ARM as well.
Wdyt? (Probably Richard?)
Thanks,
Claudio
next prev parent reply other threads:[~2021-01-31 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131115022.242570-1-f4bug@amsat.org>
[not found] ` <20210131115022.242570-6-f4bug@amsat.org>
2021-01-31 14:29 ` [PATCH v6 05/11] target/arm: Restrict ARMv6 cpus to TCG accel Claudio Fontana
2021-02-01 17:18 ` Alex Bennée
2021-01-31 14:40 ` Claudio Fontana [this message]
2021-01-31 15:23 ` [PATCH v6 00/11] Support disabling TCG on ARM (part 2) Philippe Mathieu-Daudé
[not found] ` <20210131115022.242570-2-f4bug@amsat.org>
[not found] ` <87d562ba-20e5-ee50-8793-59d77564f4da@suse.de>
2021-01-31 15:23 ` [PATCH v6 01/11] sysemu/tcg: Introduce tcg_builtin() helper Philippe Mathieu-Daudé
2021-02-01 14:29 ` Claudio Fontana
[not found] ` <20210131115022.242570-3-f4bug@amsat.org>
2021-02-01 13:24 ` [PATCH v6 02/11] exec: Restrict TCG specific headers Alex Bennée
[not found] ` <20210131115022.242570-7-f4bug@amsat.org>
[not found] ` <80af7db7-2311-7cc5-93a0-f0609b0222d0@redhat.com>
2021-02-01 17:37 ` [PATCH v6 06/11] target/arm: Restrict ARMv7 R-profile cpus to TCG accel Alex Bennée
[not found] ` <20210131115022.242570-4-f4bug@amsat.org>
2021-02-01 17:10 ` [PATCH v6 03/11] target/arm: Restrict ARMv4 " Alex Bennée
2021-03-04 11:55 ` Claudio Fontana
2021-03-04 19:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9924223e-3aeb-5200-c7fa-f120a7ae30fe@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).