* Re[PATCH 3/6] KVM: nVMX: properly handle errors in nested_vmx_handle_enlightened_vmptrld()
@ 2020-03-10 2:38 linmiaohe
0 siblings, 0 replies; only message in thread
From: linmiaohe @ 2020-03-10 2:38 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Paolo Bonzini, Jim Mattson, Sean Christopherson, kvm,
linux-kernel, Liran Alon
Hi:
Vitaly Kuznetsov <vkuznets@redhat.com> writes:
>nested_vmx_handle_enlightened_vmptrld() fails in two cases:
>- when we fail to kvm_vcpu_map() the supplied GPA
>- when revision_id is incorrect.
>Genuine Hyper-V raises #UD in the former case (at least with *some* incorrect GPAs) and does VMfailInvalid() in the later. KVM doesn't do anything so L1 just gets stuck retrying the same faulty VMLAUNCH.
>
>nested_vmx_handle_enlightened_vmptrld() has two call sites:
>nested_vmx_run() and nested_get_vmcs12_pages(). The former needs to queue do much: the failure there happens after migration when L2 was running (and
>L1 did something weird like wrote to VP assist page from a different vCPU), just kill L1 with KVM_EXIT_INTERNAL_ERROR.
>
>Reported-by: Miaohe Lin <linmiaohe@huawei.com>
>Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks for fixing this issue!:) The code looks fine for and it should works as far as I can say.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-10 2:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 2:38 Re[PATCH 3/6] KVM: nVMX: properly handle errors in nested_vmx_handle_enlightened_vmptrld() linmiaohe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).