From: Jingyi Wang <wangjingyi11@huawei.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v2 7/8] arm64: microbench: Add time limit for each individual test
Date: Thu, 2 Jul 2020 16:47:08 +0800 [thread overview]
Message-ID: <88f2e5a2-def5-81f1-eb3c-b6a12b9ea64d@huawei.com> (raw)
In-Reply-To: <20200702054857.qcmaaproewgzzljf@kamzik.brq.redhat.com>
On 7/2/2020 1:48 PM, Andrew Jones wrote:
> On Thu, Jul 02, 2020 at 11:01:31AM +0800, Jingyi Wang wrote:
>> Besides using separate running times parameter, we add time limit
>> for loop_test to make sure each test should be done in a certain
>> time(5 sec here).
>>
>> Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com>
>> ---
>> arm/micro-bench.c | 17 +++++++++++------
>> 1 file changed, 11 insertions(+), 6 deletions(-)
>>
>> diff --git a/arm/micro-bench.c b/arm/micro-bench.c
>> index 506d2f9..4c962b7 100644
>> --- a/arm/micro-bench.c
>> +++ b/arm/micro-bench.c
>> @@ -23,6 +23,7 @@
>> #include <asm/gic-v3-its.h>
>>
>> #define NTIMES (1U << 16)
>> +#define MAX_NS (5 * 1000 * 1000 * 1000UL)
>
> How about naming this something like "NS_5_SECONDS"?
>
Done, thanks for reviewing.
>>
>> static u32 cntfrq;
>>
>> @@ -258,22 +259,26 @@ static void loop_test(struct exit_test *test)
>> uint64_t start, end, total_ticks, ntimes = 0;
>> struct ns_time total_ns, avg_ns;
>>
>> + total_ticks = 0;
>> if (test->prep) {
>> if(!test->prep()) {
>> printf("%s test skipped\n", test->name);
>> return;
>> }
>> }
>> - isb();
>> - start = read_sysreg(cntpct_el0);
>> - while (ntimes < test->times) {
>> +
>> + while (ntimes < test->times && total_ns.ns < MAX_NS) {
>> + isb();
>> + start = read_sysreg(cntpct_el0);
>> test->exec();
>> + isb();
>> + end = read_sysreg(cntpct_el0);
>> +
>> ntimes++;
>> + total_ticks += (end - start);
>> + ticks_to_ns_time(total_ticks, &total_ns);
>> }
>> - isb();
>> - end = read_sysreg(cntpct_el0);
>>
>> - total_ticks = end - start;
>> ticks_to_ns_time(total_ticks, &total_ns);
>> avg_ns.ns = total_ns.ns / ntimes;
>> avg_ns.ns_frac = total_ns.ns_frac / ntimes;
>> --
>> 2.19.1
>>
>>
>
> Thanks,
> drew
>
>
> .
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-07-02 8:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 3:01 [kvm-unit-tests PATCH v2 0/8] arm/arm64: Add IPI/LPI/vtimer latency test Jingyi Wang
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 1/8] arm64: microbench: get correct ipi received num Jingyi Wang
2020-07-02 12:36 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 2/8] arm64: microbench: Use the funcions for ipi test as the general functions for gic(ipi/lpi/timer) test Jingyi Wang
2020-07-02 5:25 ` Andrew Jones
2020-07-02 8:21 ` Jingyi Wang
2020-07-02 12:36 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 3/8] arm64: microbench: gic: Add gicv4.1 support for ipi latency test Jingyi Wang
2020-07-02 8:22 ` Marc Zyngier
2020-07-02 9:02 ` Jingyi Wang
2020-07-02 9:17 ` Marc Zyngier
2020-07-02 9:29 ` Jingyi Wang
2020-07-02 12:36 ` Auger Eric
2020-07-02 13:03 ` Marc Zyngier
2020-07-02 12:57 ` Auger Eric
2020-07-02 13:08 ` Marc Zyngier
2020-07-02 13:42 ` Auger Eric
2020-07-03 3:39 ` Jingyi Wang
2020-07-02 21:33 ` Andrew Jones
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 4/8] arm64: its: Handle its command queue wrapping Jingyi Wang
2020-07-02 13:01 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 5/8] arm64: microbench: its: Add LPI latency test Jingyi Wang
2020-07-02 13:13 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 6/8] arm64: microbench: Allow each test to specify its running times Jingyi Wang
2020-07-02 5:29 ` Andrew Jones
2020-07-02 8:46 ` Jingyi Wang
2020-07-02 13:17 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 7/8] arm64: microbench: Add time limit for each individual test Jingyi Wang
2020-07-02 5:48 ` Andrew Jones
2020-07-02 8:47 ` Jingyi Wang [this message]
2020-07-02 13:23 ` Auger Eric
2020-07-03 3:42 ` Jingyi Wang
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 8/8] arm64: microbench: Add vtimer latency test Jingyi Wang
2020-07-02 5:44 ` Andrew Jones
2020-07-02 8:56 ` Jingyi Wang
2020-07-02 13:36 ` Auger Eric
2020-07-03 7:41 ` Jingyi Wang
2020-07-03 7:45 ` Auger Eric
2020-07-06 12:23 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f2e5a2-def5-81f1-eb3c-b6a12b9ea64d@huawei.com \
--to=wangjingyi11@huawei.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).