From: Jingyi Wang <wangjingyi11@huawei.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v2 6/8] arm64: microbench: Allow each test to specify its running times
Date: Thu, 2 Jul 2020 16:46:25 +0800 [thread overview]
Message-ID: <c30baed6-2ff3-7d9d-64e1-0ff2bdf2697b@huawei.com> (raw)
In-Reply-To: <20200702052942.laodlgq2yrlxwsh4@kamzik.brq.redhat.com>
On 7/2/2020 1:29 PM, Andrew Jones wrote:
> On Thu, Jul 02, 2020 at 11:01:30AM +0800, Jingyi Wang wrote:
>> For some test in micro-bench can be time consuming, we add a
>> micro-bench test parameter to allow each individual test to specify
>> its running times.
>>
>> Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com>
>> ---
>> arm/micro-bench.c | 25 ++++++++++++++-----------
>> 1 file changed, 14 insertions(+), 11 deletions(-)
>>
>> diff --git a/arm/micro-bench.c b/arm/micro-bench.c
>> index aeb60a7..506d2f9 100644
>> --- a/arm/micro-bench.c
>> +++ b/arm/micro-bench.c
>> @@ -223,17 +223,18 @@ struct exit_test {
>> const char *name;
>> bool (*prep)(void);
>> void (*exec)(void);
>> + u32 times;
>> bool run;
>> };
>>
>> static struct exit_test tests[] = {
>> - {"hvc", NULL, hvc_exec, true},
>> - {"mmio_read_user", NULL, mmio_read_user_exec, true},
>> - {"mmio_read_vgic", NULL, mmio_read_vgic_exec, true},
>> - {"eoi", NULL, eoi_exec, true},
>> - {"ipi", ipi_prep, ipi_exec, true},
>> - {"ipi_hw", ipi_hw_prep, ipi_exec, true},
>> - {"lpi", lpi_prep, lpi_exec, true},
>> + {"hvc", NULL, hvc_exec, NTIMES, true},
>> + {"mmio_read_user", NULL, mmio_read_user_exec, NTIMES, true},
>> + {"mmio_read_vgic", NULL, mmio_read_vgic_exec, NTIMES, true},
>> + {"eoi", NULL, eoi_exec, NTIMES, true},
>> + {"ipi", ipi_prep, ipi_exec, NTIMES, true},
>> + {"ipi_hw", ipi_hw_prep, ipi_exec, NTIMES, true},
>> + {"lpi", lpi_prep, lpi_exec, NTIMES, true},
>
> Now that we no longer use 'NTIMES' in functions we don't really need the
> define at all. We can just put 65536 directly into the table here for
> each test that needs 65536 times.
>
> Thanks,
> drew
>
Done, thanks for reviewing.
>> };
>>
>> struct ns_time {
>> @@ -254,7 +255,7 @@ static void ticks_to_ns_time(uint64_t ticks, struct ns_time *ns_time)
>>
>> static void loop_test(struct exit_test *test)
>> {
>> - uint64_t start, end, total_ticks, ntimes = NTIMES;
>> + uint64_t start, end, total_ticks, ntimes = 0;
>> struct ns_time total_ns, avg_ns;
>>
>> if (test->prep) {
>> @@ -265,15 +266,17 @@ static void loop_test(struct exit_test *test)
>> }
>> isb();
>> start = read_sysreg(cntpct_el0);
>> - while (ntimes--)
>> + while (ntimes < test->times) {
>> test->exec();
>> + ntimes++;
>> + }
>> isb();
>> end = read_sysreg(cntpct_el0);
>>
>> total_ticks = end - start;
>> ticks_to_ns_time(total_ticks, &total_ns);
>> - avg_ns.ns = total_ns.ns / NTIMES;
>> - avg_ns.ns_frac = total_ns.ns_frac / NTIMES;
>> + avg_ns.ns = total_ns.ns / ntimes;
>> + avg_ns.ns_frac = total_ns.ns_frac / ntimes;
>>
>> printf("%-30s%15" PRId64 ".%-15" PRId64 "%15" PRId64 ".%-15" PRId64 "\n",
>> test->name, total_ns.ns, total_ns.ns_frac, avg_ns.ns, avg_ns.ns_frac);
>> --
>> 2.19.1
>>
>>
>
>
> .
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-07-02 8:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 3:01 [kvm-unit-tests PATCH v2 0/8] arm/arm64: Add IPI/LPI/vtimer latency test Jingyi Wang
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 1/8] arm64: microbench: get correct ipi received num Jingyi Wang
2020-07-02 12:36 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 2/8] arm64: microbench: Use the funcions for ipi test as the general functions for gic(ipi/lpi/timer) test Jingyi Wang
2020-07-02 5:25 ` Andrew Jones
2020-07-02 8:21 ` Jingyi Wang
2020-07-02 12:36 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 3/8] arm64: microbench: gic: Add gicv4.1 support for ipi latency test Jingyi Wang
2020-07-02 8:22 ` Marc Zyngier
2020-07-02 9:02 ` Jingyi Wang
2020-07-02 9:17 ` Marc Zyngier
2020-07-02 9:29 ` Jingyi Wang
2020-07-02 12:36 ` Auger Eric
2020-07-02 13:03 ` Marc Zyngier
2020-07-02 12:57 ` Auger Eric
2020-07-02 13:08 ` Marc Zyngier
2020-07-02 13:42 ` Auger Eric
2020-07-03 3:39 ` Jingyi Wang
2020-07-02 21:33 ` Andrew Jones
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 4/8] arm64: its: Handle its command queue wrapping Jingyi Wang
2020-07-02 13:01 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 5/8] arm64: microbench: its: Add LPI latency test Jingyi Wang
2020-07-02 13:13 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 6/8] arm64: microbench: Allow each test to specify its running times Jingyi Wang
2020-07-02 5:29 ` Andrew Jones
2020-07-02 8:46 ` Jingyi Wang [this message]
2020-07-02 13:17 ` Auger Eric
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 7/8] arm64: microbench: Add time limit for each individual test Jingyi Wang
2020-07-02 5:48 ` Andrew Jones
2020-07-02 8:47 ` Jingyi Wang
2020-07-02 13:23 ` Auger Eric
2020-07-03 3:42 ` Jingyi Wang
2020-07-02 3:01 ` [kvm-unit-tests PATCH v2 8/8] arm64: microbench: Add vtimer latency test Jingyi Wang
2020-07-02 5:44 ` Andrew Jones
2020-07-02 8:56 ` Jingyi Wang
2020-07-02 13:36 ` Auger Eric
2020-07-03 7:41 ` Jingyi Wang
2020-07-03 7:45 ` Auger Eric
2020-07-06 12:23 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c30baed6-2ff3-7d9d-64e1-0ff2bdf2697b@huawei.com \
--to=wangjingyi11@huawei.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).