From: Auger Eric <eric.auger@redhat.com> To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, joro@8bytes.org, alex.williamson@redhat.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, will.deacon@arm.com, robin.murphy@arm.com Cc: peter.maydell@linaro.org, kevin.tian@intel.com, vincent.stehle@arm.com, ashok.raj@intel.com, marc.zyngier@arm.com, christoffer.dall@arm.com Subject: Re: [PATCH v7 05/23] iommu: Introduce cache_invalidate API Date: Thu, 2 May 2019 08:58:29 +0200 [thread overview] Message-ID: <e5d2fdd6-4ce1-863e-5198-0b05d727a5b6@redhat.com> (raw) In-Reply-To: <a9745aef-8686-c761-e3d0-dd0e98a1f5b2@arm.com> Hi Jean-Philippe, On 5/1/19 12:38 PM, Jean-Philippe Brucker wrote: > On 08/04/2019 13:18, Eric Auger wrote: >> +int iommu_cache_invalidate(struct iommu_domain *domain, struct device *dev, >> + struct iommu_cache_invalidate_info *inv_info) >> +{ >> + int ret = 0; >> + >> + if (unlikely(!domain->ops->cache_invalidate)) >> + return -ENODEV; >> + >> + ret = domain->ops->cache_invalidate(domain, dev, inv_info); >> + >> + return ret; > > Nit: you don't really need ret > > The UAPI looks good to me, so > > Reviewed-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> Just to make sure, do you accept changes proposed by Jacob in https://lkml.org/lkml/2019/4/29/659 ie. - the addition of NR_IOMMU_INVAL_GRANU in enum iommu_inv_granularity and - the addition of NR_IOMMU_CACHE_TYPE Thanks Eric >
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com> To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, joro@8bytes.org, alex.williamson@redhat.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, will.deacon@arm.com, robin.murphy@arm.com Cc: kevin.tian@intel.com, vincent.stehle@arm.com, ashok.raj@intel.com, marc.zyngier@arm.com Subject: Re: [PATCH v7 05/23] iommu: Introduce cache_invalidate API Date: Thu, 2 May 2019 08:58:29 +0200 [thread overview] Message-ID: <e5d2fdd6-4ce1-863e-5198-0b05d727a5b6@redhat.com> (raw) Message-ID: <20190502065829._GGsKynXUvUfGFJuTT54kUgW9I3f44An1AVwWgyrfx0@z> (raw) In-Reply-To: <a9745aef-8686-c761-e3d0-dd0e98a1f5b2@arm.com> Hi Jean-Philippe, On 5/1/19 12:38 PM, Jean-Philippe Brucker wrote: > On 08/04/2019 13:18, Eric Auger wrote: >> +int iommu_cache_invalidate(struct iommu_domain *domain, struct device *dev, >> + struct iommu_cache_invalidate_info *inv_info) >> +{ >> + int ret = 0; >> + >> + if (unlikely(!domain->ops->cache_invalidate)) >> + return -ENODEV; >> + >> + ret = domain->ops->cache_invalidate(domain, dev, inv_info); >> + >> + return ret; > > Nit: you don't really need ret > > The UAPI looks good to me, so > > Reviewed-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> Just to make sure, do you accept changes proposed by Jacob in https://lkml.org/lkml/2019/4/29/659 ie. - the addition of NR_IOMMU_INVAL_GRANU in enum iommu_inv_granularity and - the addition of NR_IOMMU_CACHE_TYPE Thanks Eric > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2019-05-02 6:58 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-08 12:18 [PATCH v7 00/23] SMMUv3 Nested Stage Setup Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 01/23] driver core: add per device iommu param Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 02/23] iommu: introduce device fault data Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 03/23] iommu: introduce device fault report API Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 04/23] iommu: Introduce attach/detach_pasid_table API Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-05-15 12:09 ` Jean-Philippe Brucker 2019-05-15 13:06 ` Auger Eric 2019-05-15 15:57 ` Jean-Philippe Brucker 2019-04-08 12:18 ` [PATCH v7 06/23] iommu: Introduce bind/unbind_guest_msi Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-05-08 13:59 ` Robin Murphy 2019-05-10 14:35 ` Auger Eric 2019-04-08 12:18 ` [PATCH v7 07/23] vfio: VFIO_IOMMU_ATTACH/DETACH_PASID_TABLE Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 08/23] vfio: VFIO_IOMMU_CACHE_INVALIDATE Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 10/23] iommu/arm-smmu-v3: Link domains and devices Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:18 ` [PATCH v7 11/23] iommu/arm-smmu-v3: Maintain a SID->device structure Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-05-08 14:05 ` Robin Murphy 2019-05-08 18:31 ` Jean-Philippe Brucker 2019-04-08 12:19 ` [PATCH v7 14/23] iommu/smmuv3: Implement cache_invalidate Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-05-08 15:01 ` Robin Murphy 2019-05-13 12:16 ` Auger Eric 2019-05-13 14:01 ` Robin Murphy 2019-05-13 14:04 ` Auger Eric 2019-04-08 12:19 ` [PATCH v7 15/23] dma-iommu: Implement NESTED_MSI cookie Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-05-08 16:42 ` Robin Murphy 2019-04-08 12:19 ` [PATCH v7 17/23] iommu/smmuv3: Implement bind/unbind_guest_msi Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-04-08 12:19 ` [PATCH v7 18/23] iommu/smmuv3: Report non recoverable faults Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-05-08 17:20 ` Robin Murphy 2019-05-13 7:46 ` Auger Eric 2019-05-13 11:54 ` Robin Murphy 2019-05-13 12:32 ` Auger Eric 2019-05-13 13:47 ` Robin Murphy 2019-04-08 12:19 ` [PATCH v7 19/23] vfio-pci: Add a new VFIO_REGION_TYPE_NESTED region type Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-04-08 12:19 ` [PATCH v7 20/23] vfio-pci: Register an iommu fault handler Eric Auger 2019-04-08 12:19 ` Eric Auger [not found] ` <20190408121911.24103-1-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2019-04-08 12:18 ` [PATCH v7 05/23] iommu: Introduce cache_invalidate API Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-05-01 10:38 ` Jean-Philippe Brucker 2019-05-01 10:38 ` Jean-Philippe Brucker 2019-05-02 6:58 ` Auger Eric [this message] 2019-05-02 6:58 ` Auger Eric 2019-05-02 10:53 ` Jean-Philippe Brucker 2019-05-02 10:53 ` Jean-Philippe Brucker 2019-05-02 16:46 ` Jacob Pan 2019-05-02 16:46 ` Jacob Pan 2019-05-07 11:45 ` Jean-Philippe Brucker 2019-04-08 12:18 ` [PATCH v7 09/23] vfio: VFIO_IOMMU_BIND/UNBIND_MSI Eric Auger 2019-04-08 12:18 ` Eric Auger 2019-04-08 12:19 ` [PATCH v7 12/23] iommu/smmuv3: Get prepared for nested stage support Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-05-08 14:24 ` Robin Murphy 2019-05-10 14:34 ` Auger Eric 2019-05-13 11:43 ` Robin Murphy 2019-05-13 14:40 ` Auger Eric 2019-04-08 12:19 ` [PATCH v7 13/23] iommu/smmuv3: Implement attach/detach_pasid_table Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-05-08 14:38 ` Robin Murphy 2019-05-10 14:35 ` Auger Eric 2019-05-13 12:04 ` Robin Murphy 2019-04-08 12:19 ` [PATCH v7 16/23] iommu/smmuv3: Nested mode single MSI doorbell per domain enforcement Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-04-08 12:19 ` [PATCH v7 21/23] vfio_pci: Allow to mmap the fault queue Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-04-08 12:19 ` [PATCH v7 22/23] vfio-pci: Add VFIO_PCI_DMA_FAULT_IRQ_INDEX Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-04-08 12:19 ` [PATCH v7 23/23] vfio: Document nested stage control Eric Auger 2019-04-08 12:19 ` Eric Auger 2019-04-30 7:09 ` [PATCH v7 00/23] SMMUv3 Nested Stage Setup Auger Eric 2019-04-30 7:09 ` Auger Eric
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e5d2fdd6-4ce1-863e-5198-0b05d727a5b6@redhat.com \ --to=eric.auger@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=christoffer.dall@arm.com \ --cc=eric.auger.pro@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe.brucker@arm.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=peter.maydell@linaro.org \ --cc=robin.murphy@arm.com \ --cc=vincent.stehle@arm.com \ --cc=will.deacon@arm.com \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).