Re: [PATCH v2 2/3] ACPI / PM: Introduce concept of a _PR0 dependent device

From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Bjorn Helgaas <bhelgaas@google.com>, Len Brown <lenb@kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Keith Busch <keith.busch@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Alexandru Gagniuc <mr.nuke.me@gmail.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ACPI / PM: Introduce concept of a _PR0 dependent device
Date: Wed, 19 Jun 2019 16:34:58 +0300	[thread overview]
Message-ID: <20190619133458.GD2640@lahna.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jaNpgW2=QfTVYcY=2MzTCaxNNSsVT667Lwz8HxvJT8mQ@mail.gmail.com>

On Wed, Jun 19, 2019 at 03:20:45PM +0200, Rafael J. Wysocki wrote:
> > +int acpi_device_power_add_dependent(struct acpi_device *adev,
> > +                                   struct device *dev)
> > +{
> > +       struct acpi_power_resource_entry *entry;
> > +       struct list_head *resources;
> > +       int ret;
> > +
> > +       if (!adev->power.flags.power_resources)
> > +               return 0;
> > +       if (!adev->power.states[ACPI_STATE_D0].flags.valid)
> > +               return 0;
> 
> The two checks above can be replaced with an
> adev->flags.power_manageable one AFAICS (the "valid" flag is always
> set for D0 and the list below will be empty if there are no power
> resources).
> 
> Same for acpi_device_power_remove_dependent(), of course.

OK, I'll do that in next version.

> Apart from this LGTM.

Thanks!