* [PATCH] ACPICA: drop unneeded initialization value
@ 2021-10-06 11:24 Sohaib Mohamed
0 siblings, 0 replies; 4+ messages in thread
From: Sohaib Mohamed @ 2021-10-06 11:24 UTC (permalink / raw)
Cc: Robert Moore, Rafael J. Wysocki, Len Brown, linux-acpi, devel,
linux-kernel
Do not initialise statics to NULL
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
---
drivers/acpi/acpica/dbcmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/dbcmds.c b/drivers/acpi/acpica/dbcmds.c
index 9eb68e0751c7..d0e3b874ca0e 100644
--- a/drivers/acpi/acpica/dbcmds.c
+++ b/drivers/acpi/acpica/dbcmds.c
@@ -35,7 +35,7 @@ acpi_db_device_resources(acpi_handle obj_handle,
static void acpi_db_do_one_sleep_state(u8 sleep_state);
-static char *acpi_db_trace_method_name = NULL;
+static char *acpi_db_trace_method_name;
/*******************************************************************************
*
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPICA: drop unneeded initialization value
2021-10-06 11:37 Sohaib Mohamed
@ 2021-10-07 17:14 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-10-07 17:14 UTC (permalink / raw)
To: Sohaib Mohamed
Cc: Robert Moore, Rafael J. Wysocki, Len Brown,
ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Linux Kernel Mailing List
On Wed, Oct 6, 2021 at 1:37 PM Sohaib Mohamed <sohaib.amhmd@gmail.com> wrote:
>
> Do not initialise statics to 0
>
> Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
> ---
> drivers/acpi/acpica/dbhistry.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/acpica/dbhistry.c b/drivers/acpi/acpica/dbhistry.c
> index fd813c5d3952..60b77b11c0f2 100644
> --- a/drivers/acpi/acpica/dbhistry.c
> +++ b/drivers/acpi/acpica/dbhistry.c
> @@ -24,9 +24,9 @@ typedef struct history_info {
> } HISTORY_INFO;
>
> static HISTORY_INFO acpi_gbl_history_buffer[HISTORY_SIZE];
> -static u16 acpi_gbl_lo_history = 0;
> -static u16 acpi_gbl_num_history = 0;
> -static u16 acpi_gbl_next_history_index = 0;
> +static u16 acpi_gbl_lo_history;
> +static u16 acpi_gbl_num_history;
> +static u16 acpi_gbl_next_history_index;
>
> /*******************************************************************************
> *
> --
Please submit ACPICA changes like this to the upstream ACPICA project
as per MAINTANIERS.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ACPICA: drop unneeded initialization value
@ 2021-10-06 11:37 Sohaib Mohamed
2021-10-07 17:14 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Sohaib Mohamed @ 2021-10-06 11:37 UTC (permalink / raw)
Cc: Robert Moore, Rafael J. Wysocki, Len Brown, linux-acpi, devel,
linux-kernel
Do not initialise statics to 0
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
---
drivers/acpi/acpica/dbhistry.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/acpica/dbhistry.c b/drivers/acpi/acpica/dbhistry.c
index fd813c5d3952..60b77b11c0f2 100644
--- a/drivers/acpi/acpica/dbhistry.c
+++ b/drivers/acpi/acpica/dbhistry.c
@@ -24,9 +24,9 @@ typedef struct history_info {
} HISTORY_INFO;
static HISTORY_INFO acpi_gbl_history_buffer[HISTORY_SIZE];
-static u16 acpi_gbl_lo_history = 0;
-static u16 acpi_gbl_num_history = 0;
-static u16 acpi_gbl_next_history_index = 0;
+static u16 acpi_gbl_lo_history;
+static u16 acpi_gbl_num_history;
+static u16 acpi_gbl_next_history_index;
/*******************************************************************************
*
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ACPICA: drop unneeded initialization value
@ 2021-10-06 11:20 Sohaib Mohamed
0 siblings, 0 replies; 4+ messages in thread
From: Sohaib Mohamed @ 2021-10-06 11:20 UTC (permalink / raw)
Cc: Robert Moore, Rafael J. Wysocki, Len Brown, linux-acpi, devel,
linux-kernel
Do not initialise statics to NULL
Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
---
drivers/acpi/acpica/dbcmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/dbcmds.c b/drivers/acpi/acpica/dbcmds.c
index 9eb68e0751c7..d0e3b874ca0e 100644
--- a/drivers/acpi/acpica/dbcmds.c
+++ b/drivers/acpi/acpica/dbcmds.c
@@ -35,7 +35,7 @@ acpi_db_device_resources(acpi_handle obj_handle,
static void acpi_db_do_one_sleep_state(u8 sleep_state);
-static char *acpi_db_trace_method_name = NULL;
+static char *acpi_db_trace_method_name;
/*******************************************************************************
*
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-07 17:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 11:24 [PATCH] ACPICA: drop unneeded initialization value Sohaib Mohamed
-- strict thread matches above, loose matches on Subject: below --
2021-10-06 11:37 Sohaib Mohamed
2021-10-07 17:14 ` Rafael J. Wysocki
2021-10-06 11:20 Sohaib Mohamed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).