* Re: [PATCH] PNP: isapnp: remove set but not used variable 'checksum'
[not found] <20200103121710.4761-1-yukuai3@huawei.com>
@ 2020-01-15 10:56 ` Rafael J. Wysocki
0 siblings, 0 replies; only message in thread
From: Rafael J. Wysocki @ 2020-01-15 10:56 UTC (permalink / raw)
To: yu kuai; +Cc: perex, linux-kernel, yi.zhang, zhengbin13, linux-acpi
On 1/3/2020 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/pnp/isapnp/core.c: In function ‘isapnp_build_device_list’:
> drivers/pnp/isapnp/core.c:777:27: warning: variable ‘checksum’ set
> but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/pnp/isapnp/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c
> index 179b737280e1..e39d49bceae0 100644
> --- a/drivers/pnp/isapnp/core.c
> +++ b/drivers/pnp/isapnp/core.c
> @@ -774,7 +774,7 @@ static unsigned char __init isapnp_checksum(unsigned char *data)
> static int __init isapnp_build_device_list(void)
> {
> int csn;
> - unsigned char header[9], checksum;
> + unsigned char header[9];
> struct pnp_card *card;
> u32 eisa_id;
> char id[8];
> @@ -784,7 +784,6 @@ static int __init isapnp_build_device_list(void)
> for (csn = 1; csn <= isapnp_csn_count; csn++) {
> isapnp_wake(csn);
> isapnp_peek(header, 9);
> - checksum = isapnp_checksum(header);
> eisa_id = header[0] | header[1] << 8 |
> header[2] << 16 | header[3] << 24;
> pnp_eisa_id_to_string(eisa_id, id);
Applied as 5.6 material, thanks!
Note that it is recommended to CC patches that touch the PNP code to
linux-acpi@vger.kernel.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-15 10:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200103121710.4761-1-yukuai3@huawei.com>
2020-01-15 10:56 ` [PATCH] PNP: isapnp: remove set but not used variable 'checksum' Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).